[llvm] [llvm-dwarfdump] Added --output-style option for controlling output format (PR #216559)

[James Henderson via llvm-commits]

https://github.com/jh7370 commented:

Please don't force push to PRs under active review as it trashes the ability to review the changes since the previous version. Add additional commits to the branch with any needed changes, or if a rebase is needed, prefer a merge commit from main instead. In either case, these extra commits will disappear during the "Squash and Merge" process used to land changes in LLVM.

We probably want to consider whether specific existing llvm-dwarfdump options make sense with JSON output mode and report an error when combining them (see for example the diff/verbose options that are reported immediately below your existing check for valid values).

I've added a few more reviewers who have interest in DWARF or reviewed output code within the LLVM DWARF library, to see if they have any further input at this stage.

I forget, did you post an RFC to gather feedback on this? My search-fu is failing me at the moment so I haven't been able to find it... If you did, please add a link to the PR description. If you didn't, I think you should post an RFC on LLVM's discourse forum, to gather feedback on your planned approach.

https://github.com/llvm/llvm-project/pull/216559