[llvm] [CodeGen] Replace CodeGenPassBuilder CRTP with virtual hooks (PR #216468)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 20:50:50 PDT 2026


llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/31989

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --cmake-file=AMDGPULibcBot.cmake' (failure)
...
[4405/5118] Linking CXX shared library lib/libclangToolingASTDiff.so.24.0git
[4406/5118] Building CXX object tools/clang/tools/clang-installapi/CMakeFiles/clang-installapi.dir/ClangInstallAPI.cpp.o
[4407/5118] Creating library symlink lib/libclangToolingASTDiff.so
[4408/5118] Linking CXX shared library lib/libclangInstallAPI.so.24.0git
[4409/5118] Linking CXX shared library lib/libclangASTMatchers.so.24.0git
[4410/5118] Creating library symlink lib/libclangInstallAPI.so
[4411/5118] Creating library symlink lib/libclangASTMatchers.so
[4412/5118] Linking CXX shared library lib/libclangScalableStaticAnalysisCore.so.24.0git
[4413/5118] Creating library symlink lib/libclangScalableStaticAnalysisCore.so
[4414/5118] Linking CXX shared library lib/libLLVMPasses.so.24.0git
FAILED: lib/libLLVMPasses.so.24.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMPasses.so.24.0git -o lib/libLLVMPasses.so.24.0git lib/Passes/CMakeFiles/LLVMPasses.dir/CodeGenPassBuilder.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilder.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilderBindings.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilderPipelines.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/StandardInstrumentations.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:\$ORIGIN/../lib/x86_64-unknown-linux-gnu:/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/lib:"  lib/libLLVMCFGuard.so.24.0git  lib/libLLVMGlobalISel.so.24.0git  lib/libLLVMCoroutines.so.24.0git  lib/libLLVMHipStdPar.so.24.0git  lib/libLLVMipo.so.24.0git  lib/libLLVMIRPrinter.so.24.0git  lib/libLLVMVectorize.so.24.0git  lib/libLLVMInstrumentation.so.24.0git  lib/libLLVMCodeGen.so.24.0git  lib/libLLVMObjCARCOpts.so.24.0git  lib/libLLVMTarget.so.24.0git  lib/libLLVMScalarOpts.so.24.0git  lib/libLLVMAggressiveInstCombine.so.24.0git  lib/libLLVMInstCombine.so.24.0git  lib/libLLVMTransformUtils.so.24.0git  lib/libLLVMAnalysis.so.24.0git  lib/libLLVMCore.so.24.0git  lib/libLLVMSupport.so.24.0git  -Wl,-rpath-link,/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/lib && :
/usr/bin/ld: lib/Passes/CMakeFiles/LLVMPasses.dir/CodeGenPassBuilder.cpp.o: in function `llvm::CodeGenPassBuilder::buildPipeline(llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>&, llvm::AnalysisManager<llvm::Module>&, llvm::raw_pwrite_stream&, llvm::raw_pwrite_stream*, llvm::CodeGenFileType, llvm::MCContext&)':
CodeGenPassBuilder.cpp:(.text._ZN4llvm18CodeGenPassBuilder13buildPipelineERNS_11PassManagerINS_6ModuleENS_15AnalysisManagerIS2_JEEEJEEERS4_RNS_17raw_pwrite_streamEPS8_NS_15CodeGenFileTypeERNS_9MCContextE+0x6a0): undefined reference to `llvm::AsmPrinterAnalysis::Key'
/usr/bin/ld: CodeGenPassBuilder.cpp:(.text._ZN4llvm18CodeGenPassBuilder13buildPipelineERNS_11PassManagerINS_6ModuleENS_15AnalysisManagerIS2_JEEEJEEERS4_RNS_17raw_pwrite_streamEPS8_NS_15CodeGenFileTypeERNS_9MCContextE+0xe24): undefined reference to `llvm::AsmPrinterAnalysis::Key'
collect2: error: ld returned 1 exit status
[4415/5118] Linking CXX shared library lib/libclangScalableStaticAnalysisTool.so.24.0git
[4416/5118] Linking CXX shared library lib/libclangScalableStaticAnalysisSourceTransformation.so.24.0git
[4417/5118] Linking CXX shared library lib/libclangToolingRefactoring.so.24.0git
[4418/5118] Building AMDGPUGenRegisterBank.inc...
[4419/5118] Linking CXX shared library lib/libclangAnalysis.so.24.0git
[4420/5118] Linking CXX shared library lib/libclangDynamicASTMatchers.so.24.0git
[4421/5118] Building AMDGPUGenAsmWriter.inc...
[4422/5118] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[4423/5118] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[4424/5118] Building AMDGPUGenGlobalISel.inc...
[4425/5118] Building AMDGPUGenDAGISel.inc...
[4426/5118] Building AMDGPUGenRegisterInfo.inc...
[4427/5118] Building AMDGPUGenInstrInfo.inc...
[4428/5118] Building AMDGPUGenAsmMatcher.inc...
ninja: build stopped: subcommand failed.
['ninja'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 62, in step
    yield
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 53, in main
    run_command(["ninja"])
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 75, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd
    subprocess.check_call(cmd, shell=shell, *args, **kwargs)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja']' returned non-zero exit status 1.
@@@STEP_FAILURE@@@
Step 7 (build cmake config) failure: build cmake config (failure)
...
[4405/5118] Linking CXX shared library lib/libclangToolingASTDiff.so.24.0git
[4406/5118] Building CXX object tools/clang/tools/clang-installapi/CMakeFiles/clang-installapi.dir/ClangInstallAPI.cpp.o
[4407/5118] Creating library symlink lib/libclangToolingASTDiff.so
[4408/5118] Linking CXX shared library lib/libclangInstallAPI.so.24.0git
[4409/5118] Linking CXX shared library lib/libclangASTMatchers.so.24.0git
[4410/5118] Creating library symlink lib/libclangInstallAPI.so
[4411/5118] Creating library symlink lib/libclangASTMatchers.so
[4412/5118] Linking CXX shared library lib/libclangScalableStaticAnalysisCore.so.24.0git
[4413/5118] Creating library symlink lib/libclangScalableStaticAnalysisCore.so
[4414/5118] Linking CXX shared library lib/libLLVMPasses.so.24.0git
FAILED: lib/libLLVMPasses.so.24.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMPasses.so.24.0git -o lib/libLLVMPasses.so.24.0git lib/Passes/CMakeFiles/LLVMPasses.dir/CodeGenPassBuilder.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilder.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilderBindings.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilderPipelines.cpp.o lib/Passes/CMakeFiles/LLVMPasses.dir/StandardInstrumentations.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:\$ORIGIN/../lib/x86_64-unknown-linux-gnu:/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/lib:"  lib/libLLVMCFGuard.so.24.0git  lib/libLLVMGlobalISel.so.24.0git  lib/libLLVMCoroutines.so.24.0git  lib/libLLVMHipStdPar.so.24.0git  lib/libLLVMipo.so.24.0git  lib/libLLVMIRPrinter.so.24.0git  lib/libLLVMVectorize.so.24.0git  lib/libLLVMInstrumentation.so.24.0git  lib/libLLVMCodeGen.so.24.0git  lib/libLLVMObjCARCOpts.so.24.0git  lib/libLLVMTarget.so.24.0git  lib/libLLVMScalarOpts.so.24.0git  lib/libLLVMAggressiveInstCombine.so.24.0git  lib/libLLVMInstCombine.so.24.0git  lib/libLLVMTransformUtils.so.24.0git  lib/libLLVMAnalysis.so.24.0git  lib/libLLVMCore.so.24.0git  lib/libLLVMSupport.so.24.0git  -Wl,-rpath-link,/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/lib && :
/usr/bin/ld: lib/Passes/CMakeFiles/LLVMPasses.dir/CodeGenPassBuilder.cpp.o: in function `llvm::CodeGenPassBuilder::buildPipeline(llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>&, llvm::AnalysisManager<llvm::Module>&, llvm::raw_pwrite_stream&, llvm::raw_pwrite_stream*, llvm::CodeGenFileType, llvm::MCContext&)':
CodeGenPassBuilder.cpp:(.text._ZN4llvm18CodeGenPassBuilder13buildPipelineERNS_11PassManagerINS_6ModuleENS_15AnalysisManagerIS2_JEEEJEEERS4_RNS_17raw_pwrite_streamEPS8_NS_15CodeGenFileTypeERNS_9MCContextE+0x6a0): undefined reference to `llvm::AsmPrinterAnalysis::Key'
/usr/bin/ld: CodeGenPassBuilder.cpp:(.text._ZN4llvm18CodeGenPassBuilder13buildPipelineERNS_11PassManagerINS_6ModuleENS_15AnalysisManagerIS2_JEEEJEEERS4_RNS_17raw_pwrite_streamEPS8_NS_15CodeGenFileTypeERNS_9MCContextE+0xe24): undefined reference to `llvm::AsmPrinterAnalysis::Key'
collect2: error: ld returned 1 exit status
[4415/5118] Linking CXX shared library lib/libclangScalableStaticAnalysisTool.so.24.0git
[4416/5118] Linking CXX shared library lib/libclangScalableStaticAnalysisSourceTransformation.so.24.0git
[4417/5118] Linking CXX shared library lib/libclangToolingRefactoring.so.24.0git
[4418/5118] Building AMDGPUGenRegisterBank.inc...
[4419/5118] Linking CXX shared library lib/libclangAnalysis.so.24.0git
[4420/5118] Linking CXX shared library lib/libclangDynamicASTMatchers.so.24.0git
[4421/5118] Building AMDGPUGenAsmWriter.inc...
[4422/5118] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[4423/5118] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[4424/5118] Building AMDGPUGenGlobalISel.inc...
[4425/5118] Building AMDGPUGenDAGISel.inc...
[4426/5118] Building AMDGPUGenRegisterInfo.inc...
[4427/5118] Building AMDGPUGenInstrInfo.inc...
[4428/5118] Building AMDGPUGenAsmMatcher.inc...
ninja: build stopped: subcommand failed.
['ninja'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 62, in step
    yield
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 53, in main
    run_command(["ninja"])
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/build/../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 75, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/botworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd
    subprocess.check_call(cmd, shell=shell, *args, **kwargs)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja']' returned non-zero exit status 1.
program finished with exit code 0
elapsedTime=48.535657

```

</details>

https://github.com/llvm/llvm-project/pull/216468


More information about the llvm-commits mailing list