[llvm] [SimplifyCFG] Check every sinking candidate in canSinkInstructions (PR #217372)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 136734 tests passed
* 3682 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=4294967295] bin/dexp.exe</summary>

```
FAILED: [code=4294967295] bin/dexp.exe
C:\Windows\system32\cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --msvc-ver=1944 --intdir=tools\clang\tools\extra\clangd\index\dex\dexp\CMakeFiles\dexp.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\dexp.rsp  /out:bin\dexp.exe /implib:lib\dexp.lib /pdb:bin\dexp.pdb /version:0.0 /MANIFEST:NO /Brepro /INCREMENTAL:NO /subsystem:console  /STACK:10000000 && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\dexp.rsp /out:bin\dexp.exe /implib:lib\dexp.lib /pdb:bin\dexp.pdb /version:0.0 /MANIFEST:NO /Brepro /INCREMENTAL:NO /subsystem:console /STACK:10000000" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: class llvm::Expected<class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>> __cdecl llvm::parseBitcodeFile(class llvm::MemoryBufferRef, class llvm::LLVMContext &, struct llvm::ParserCallbacks)
>>> referenced by LLVMFrontendOpenMP.lib(OMPIRBuilder.cpp.obj):(public: void __cdecl llvm::OpenMPIRBuilder::loadOffloadInfoMetadata(class llvm::vfs::FileSystem &, class llvm::StringRef))
>>> referenced by LLVMIRReader.lib(IRReader.cpp.obj):(class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>> __cdecl llvm::parseIR(class llvm::MemoryBufferRef, class llvm::SMDiagnostic &, class llvm::LLVMContext &, struct llvm::ParserCallbacks, class llvm::AsmParserContext *))

lld-link: error: undefined symbol: class std::error_code __cdecl llvm::errorToErrorCodeAndEmitErrors(class llvm::LLVMContext &, class llvm::Error)
>>> referenced by LLVMFrontendOpenMP.lib(OMPIRBuilder.cpp.obj):(class llvm::ErrorOr<class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>> __cdecl llvm::expectedToErrorOrAndEmitErrors<class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>>(class llvm::LLVMContext &, class llvm::Expected<class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>>))

lld-link: error: undefined symbol: class llvm::Expected<class std::vector<class llvm::BitcodeModule, class std::allocator<class llvm::BitcodeModule>>> __cdecl llvm::getBitcodeModuleList(class llvm::MemoryBufferRef)
>>> referenced by LLVMObject.lib(IRObjectFile.cpp.obj):(public: static class llvm::Expected<class std::unique_ptr<class llvm::object::IRObjectFile, struct std::default_delete<class llvm::object::IRObjectFile>>> __cdecl llvm::object::IRObjectFile::create(class llvm::MemoryBufferRef, class llvm::LLVMContext &))

lld-link: error: undefined symbol: public: class llvm::Expected<class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>> __cdecl llvm::BitcodeModule::getLazyModule(class llvm::LLVMContext &, bool, bool, struct llvm::ParserCallbacks)
>>> referenced by LLVMObject.lib(IRObjectFile.cpp.obj):(public: static class llvm::Expected<class std::unique_ptr<class llvm::object::IRObjectFile, struct std::default_delete<class llvm::object::IRObjectFile>>> __cdecl llvm::object::IRObjectFile::create(class llvm::MemoryBufferRef, class llvm::LLVMContext &))
>>> referenced by LLVMObject.lib(IRSymtab.cpp.obj):(class llvm::Expected<struct llvm::irsymtab::FileContents> __cdecl upgrade(class llvm::ArrayRef<class llvm::BitcodeModule>))

lld-link: error: undefined symbol: class llvm::Expected<struct llvm::BitcodeFileContents> __cdecl llvm::getBitcodeFileContents(class llvm::MemoryBufferRef)
>>> referenced by LLVMObject.lib(IRObjectFile.cpp.obj):(class llvm::Expected<struct llvm::object::IRSymtabFile> __cdecl llvm::object::readIRSymtab(class llvm::MemoryBufferRef))

lld-link: error: undefined symbol: class llvm::Expected<class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>>> __cdecl llvm::getBitcodeTargetTriple(class llvm::MemoryBufferRef)
>>> referenced by LLVMObject.lib(ArchiveWriter.cpp.obj):(class llvm::Expected<class std::vector<struct `anonymous namespace'::MemberData, class std::allocator<struct `anonymous namespace'::MemberData>>> __cdecl computeMemberData(class llvm::raw_ostream &, class llvm::raw_ostream &, enum llvm::object::Archive::Kind, bool, bool, enum llvm::SymtabWritingMode, struct SymMap *, class llvm::LLVMContext &, class llvm::ArrayRef<struct llvm::NewArchiveMember>, class std::optional<bool>, class llvm::function_ref<void __cdecl(class llvm::Error)>))
>>> referenced by LLVMObject.lib(ArchiveWriter.cpp.obj):(bool __cdecl isECObject(class llvm::object::SymbolicFile &))

lld-link: error: undefined symbol: class llvm::Expected<class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>> __cdecl llvm::getOwningLazyBitcodeModule(class std::unique_ptr<class llvm::MemoryBuffer, struct std::default_delete<class llvm::MemoryBuffer>> &&, class llvm::LLVMContext &, bool, bool, struct llvm::ParserCallbacks)
>>> referenced by LLVMIRReader.lib(IRReader.cpp.obj):(class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>> __cdecl llvm::getLazyIRModule(class std::unique_ptr<class llvm::MemoryBuffer, struct std::default_delete<class llvm::MemoryBuffer>>, class llvm::SMDiagnostic &, class llvm::LLVMContext &, bool))
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/217372