[libc] [llvm] [libc] Make sqrtf128 use emulated float128 (PR #216500)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 22:34:31 PDT 2026
https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/216500
>From 2eac153d015232d6b16b5a0e97eba4a296550da7 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Sun, 16 Aug 2026 00:58:58 +0530
Subject: [PATCH 1/7] Modify sqrtf128 for emulated float128 type
---
libc/shared/math/sqrtf128.h | 6 -
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/sqrtf128.h | 15 +-
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/sqrtf128.cpp | 5 +-
libc/src/math/sqrtf128.h | 5 +
libc/test/shared/shared_math_test.cpp | 2 +-
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/ceilf128_test.cpp | 1 +
libc/test/src/math/smoke/sqrtf128_test.cpp | 213 ++++++++++++++-------
libc/test/src/math/sqrtf128_test.cpp | 66 +++++--
11 files changed, 214 insertions(+), 103 deletions(-)
diff --git a/libc/shared/math/sqrtf128.h b/libc/shared/math/sqrtf128.h
index d91814aa377f9..39120396012ce 100644
--- a/libc/shared/math/sqrtf128.h
+++ b/libc/shared/math/sqrtf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_SQRTF128_H
#define LLVM_LIBC_SHARED_MATH_SQRTF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/sqrtf128.h"
@@ -24,6 +20,4 @@ using math::sqrtf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_SQRTF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 613e0adf385c7..b97c40bf2fe86 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -5403,7 +5403,7 @@ add_header_library(
libc.src.__support.common
libc.src.__support.macros.optimization
libc.src.__support.uint128
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
)
add_header_library(
diff --git a/libc/src/__support/math/sqrtf128.h b/libc/src/__support/math/sqrtf128.h
index b7654dce9e8a1..a1fe100ff4b22 100644
--- a/libc/src/__support/math/sqrtf128.h
+++ b/libc/src/__support/math/sqrtf128.h
@@ -9,13 +9,10 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_SQRTF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_SQRTF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/CPP/bit.h"
#include "src/__support/FPUtil/FEnvImpl.h"
#include "src/__support/FPUtil/FPBits.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/FPUtil/rounding_mode.h"
#include "src/__support/common.h"
#include "src/__support/macros/optimization.h"
@@ -58,6 +55,8 @@
namespace LIBC_NAMESPACE_DECL {
namespace math {
+using LIBC_NAMESPACE::fputil::Float128;
+
namespace sqrtf128_internal {
template <typename T, typename U = T> LIBC_INLINE constexpr T prod_hi(T, U);
@@ -280,9 +279,9 @@ LIBC_INLINE constexpr uint64_t rsqrt_approx(uint64_t m) {
} // namespace sqrtf128_internal
-LIBC_INLINE float128 sqrtf128(float128 x) {
+LIBC_INLINE Float128 sqrtf128(Float128 x) {
using namespace sqrtf128_internal;
- using FPBits = fputil::FPBits<float128>;
+ using FPBits = fputil::FPBits<Float128>;
// Get rounding mode.
uint32_t rm = fputil::get_round();
@@ -441,12 +440,10 @@ LIBC_INLINE float128 sqrtf128(float128 x) {
// if(frac) fputil::raise_except_if_required(FE_INEXACT);
v += static_cast<UInt128>(e2) << FPBits::FRACTION_LEN; // place exponent
- return cpp::bit_cast<float128>(v);
+ return cpp::bit_cast<Float128>(v);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_SQRTF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 13c4ff8126c9f..2c097ef89e473 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2699,6 +2699,7 @@ add_entrypoint_object(
../sqrtf128.h
DEPENDS
libc.src.__support.math.sqrtf128
+ libc.src.__support.CPP.bit
)
add_entrypoint_object(
diff --git a/libc/src/math/generic/sqrtf128.cpp b/libc/src/math/generic/sqrtf128.cpp
index 47e4da97581ba..3837dbc485b82 100644
--- a/libc/src/math/generic/sqrtf128.cpp
+++ b/libc/src/math/generic/sqrtf128.cpp
@@ -7,12 +7,15 @@
//===----------------------------------------------------------------------===//
#include "src/math/sqrtf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/sqrtf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, sqrtf128, (float128 x)) {
- return math::sqrtf128(x);
+ return cpp::bit_cast<float128>(math::sqrtf128(cpp::bit_cast<Float128>(x)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/sqrtf128.h b/libc/src/math/sqrtf128.h
index 81f4c12eff90d..e73f3a25c41c2 100644
--- a/libc/src/math/sqrtf128.h
+++ b/libc/src/math/sqrtf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_SQRTF128_H
#define LLVM_LIBC_SRC_MATH_SQRTF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 sqrtf128(float128 x);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index c507c51d8b48a..bb62515ba4eec 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -583,6 +583,7 @@ TEST(LlvmLibcSharedMathTest, AllLongDouble) {
TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::floorf128(Float128(0.0)));
+ EXPECT_FP_EQ(Float128(1.0), LIBC_NAMESPACE::shared::sqrtf128(Float128(1.0)));
}
#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
@@ -608,7 +609,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::logbf128(float128(1.0)));
EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dfmaf128(
float128(0.0), float128(0.0), float128(0.0)));
- EXPECT_FP_EQ(float128(1.0), LIBC_NAMESPACE::shared::sqrtf128(float128(1.0)));
EXPECT_FP_EQ(0.0, LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0)));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::llogbf128(float128(1.0)));
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index ba6d8764f1292..6e3c545a366f0 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3610,6 +3610,7 @@ add_fp_unittest(
SqrtTest.h
DEPENDS
libc.src.math.sqrtf128
+ libc.src.__support.FPUtil.float128
)
add_fp_unittest(
diff --git a/libc/test/src/math/smoke/ceilf128_test.cpp b/libc/test/src/math/smoke/ceilf128_test.cpp
index 2547e38256270..ba5a768610a65 100644
--- a/libc/test/src/math/smoke/ceilf128_test.cpp
+++ b/libc/test/src/math/smoke/ceilf128_test.cpp
@@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//
#include "CeilTest.h"
+
#include "src/__support/FPUtil/float128.h"
#include "src/math/ceilf128.h"
diff --git a/libc/test/src/math/smoke/sqrtf128_test.cpp b/libc/test/src/math/smoke/sqrtf128_test.cpp
index 2fca74842d313..e2fa9bad8674c 100644
--- a/libc/test/src/math/smoke/sqrtf128_test.cpp
+++ b/libc/test/src/math/smoke/sqrtf128_test.cpp
@@ -8,9 +8,17 @@
#include "SqrtTest.h"
+#include "src/__support/FPUtil/float128.h"
+#include "src/__support/integer_literals.h"
#include "src/__support/uint128.h"
#include "src/math/sqrtf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
+using LIBC_NAMESPACE::operator""_u128;
+
LIST_SQRT_TESTS(float128, LIBC_NAMESPACE::sqrtf128);
TEST_F(LlvmLibcSqrtTest, HardToRound) {
@@ -24,69 +32,129 @@ TEST_F(LlvmLibcSqrtTest, HardToRound) {
// cases for the round to nearest mode but also the directional
// modes.
float128 HARD_TO_ROUND[][2] = {
- {0x0.000000dee2f5b6a26c8f07f05442p-16382q,
- -0x1.ddbd8763a617cff753e2a31083p-8204q},
- {0x0.000000c86d174c5ad8ae54a548e7p-16382q,
- 0x1.c507bb538940719890851ec1ca88p-8204q},
- {0x0.000020ab15cfe0b8e488e128f535p-16382q,
- -0x1.6dccb402560213bc0d62d62e910bp-8201q},
- {0x0.0000219e97732a9970f2511989bap-16382q,
- 0x1.73163d28be706f4b5052791e28a5p-8201q},
- {0x0.000026e477546ae99ef57066f9fdp-16382q,
- -0x1.8f20dd0d0c570a23ea59bc2bf009p-8201q},
- {0x0.00002d0f88d27a496b3e533f5067p-16382q,
- 0x1.ad9d4abe9f047225a7352bcc52c1p-8201q},
- {0x1.0000000000000000000000000001p+0q, 0x1p+0q},
- {0x1.0000000000000000000000000002p+0q,
- -0x1.0000000000000000000000000001p+0q},
- {0x1.0000000000000000000000000003p+0q,
- 0x1.0000000000000000000000000001p+0q},
- {0x1.0000000000000000000000000005p+0q,
- 0x1.0000000000000000000000000002p+0q},
- {0x1.0000000000000000000000000006p+0q,
- -0x1.0000000000000000000000000003p+0q},
- {0x1.1d4c381cbf3a0aa15b9aee344892p+0q,
- 0x1.0e408c3fadc5e64b449c63673f4bp+0q},
- {0x1.2af17a4ae6f93d11310c49c11b59p+0q,
- -0x1.14a3bdf0ea5231f12d421a5dbe33p+0q},
- {0x1.96f893bf29fb91e0fbe19a46d0c8p+0q,
- 0x1.42c6bf6202e66f2295807dee44d9p+0q},
- {0x1.97fb3839925b66804c429289cce8p+0q,
- -0x1.432d4049ac1c85a241f333d326e9p+0q},
- {0x1.be1d900eaeb1533f0f19cc15c7e6p+0q,
- 0x1.51f1715154da44f3bf11f3d96c2dp+0q},
- {0x1.c4f5074269525063a26051a0ad27p+0q,
- 0x1.54864e9b1daa4d9135ff00663366p+0q},
- {0x1.035cb5f298a801dc4be9b1f8cd97p+1q,
- -0x1.6c688775bffcb3f507ba11d0abb9p+0q},
- {0x1.274be02380427e709beab4dedeb4p+1q,
- -0x1.84d5763281f2318422392e506b1cp+0q},
- {0x1.64e797cfdbaa3f7e2f33279dbc6p+1q,
- 0x1.ab79b164e255b26eca00ff99cc99p+0q},
- {0x1.693a741358c9dac44a570a7e9f6cp+1q,
- 0x1.ae0e8eaeab25bb0c40ee0c2693d3p+0q},
- {0x1.8275db3fc4d822596047adcb71b9p+1q,
- -0x1.bcd2bfb653e37a5dbe0ccc2cd917p+0q},
- {0x1.83280bb98c4a7b88bd6f535899d9p+1q,
- 0x1.bd39409dfd1990dd6a7f8211bb27p+0q},
- {0x1.d78d8352b48608b510bfd5c75315p+1q,
- -0x1.eb5c420f15adce0ed2bde5a241cep+0q},
- {0x1.e3e4774f564b526edff84ce46668p+1q,
- 0x1.f1bf73c0523a19b4bb639c98c0b5p+0q},
- {0x1.fffffffffffffffffffffffffffap+1q,
- -0x1.fffffffffffffffffffffffffffdp+0q},
- {0x1.fffffffffffffffffffffffffffbp+1q,
- 0x1.fffffffffffffffffffffffffffdp+0q},
- {0x1.fffffffffffffffffffffffffffdp+1q,
- 0x1.fffffffffffffffffffffffffffep+0q},
- {0x1.fffffffffffffffffffffffffffep+1q,
- -0x1.ffffffffffffffffffffffffffffp+0q},
- {0x1.ffffffffffffffffffffffffffffp+1q,
- 0x1.ffffffffffffffffffffffffffffp+0q},
+ {FPBits(0x00000000'00dee2f5'b6a26c8f'07f05442_u128)
+ .get_val(), // 0x0.000000dee2f5b6a26c8f07f05442p-16382q
+ FPBits(0x9ff3ddbd'8763a617'cff753e2'a3108300_u128)
+ .get_val()}, // -0x1.ddbd8763a617cff753e2a31083p-8204q
+ {FPBits(0x00000000'00c86d17'4c5ad8ae'54a548e7_u128)
+ .get_val(), // 0x0.000000c86d174c5ad8ae54a548e7p-16382q
+ FPBits(0x1ff3c507'bb538940'71989085'1ec1ca88_u128)
+ .get_val()}, // 0x1.c507bb538940719890851ec1ca88p-8204q
+ {FPBits(0x00000000'20ab15cf'e0b8e488'e128f535_u128)
+ .get_val(), // 0x0.000020ab15cfe0b8e488e128f535p-16382q
+ FPBits(0x9ff66dcc'b4025602'13bc0d62'd62e910b_u128)
+ .get_val()}, // -0x1.6dccb402560213bc0d62d62e910bp-8201q
+ {FPBits(0x00000000'219e9773'2a9970f2'511989ba_u128)
+ .get_val(), // 0x0.0000219e97732a9970f2511989bap-16382q
+ FPBits(0x1ff67316'3d28be70'6f4b5052'791e28a5_u128)
+ .get_val()}, // 0x1.73163d28be706f4b5052791e28a5p-8201q
+ {FPBits(0x00000000'26e47754'6ae99ef5'7066f9fd_u128)
+ .get_val(), // 0x0.000026e477546ae99ef57066f9fdp-16382q
+ FPBits(0x9ff68f20'dd0d0c57'0a23ea59'bc2bf009_u128)
+ .get_val()}, // -0x1.8f20dd0d0c570a23ea59bc2bf009p-8201q
+ {FPBits(0x00000000'2d0f88d2'7a496b3e'533f5067_u128)
+ .get_val(), // 0x0.00002d0f88d27a496b3e533f5067p-16382q
+ FPBits(0x1ff6ad9d'4abe9f04'7225a735'2bcc52c1_u128)
+ .get_val()}, // 0x1.ad9d4abe9f047225a7352bcc52c1p-8201q
+ {FPBits(0x3fff0000'00000000'00000000'00000001_u128)
+ .get_val(), // 0x1.0000000000000000000000000001p+0q
+ FPBits(0x3fff0000'00000000'00000000'00000000_u128).get_val()}, // 0x1p+0q
+ {FPBits(0x3fff0000'00000000'00000000'00000002_u128)
+ .get_val(), // 0x1.0000000000000000000000000002p+0q
+ FPBits(0xbfff0000'00000000'00000000'00000001_u128)
+ .get_val()}, // -0x1.0000000000000000000000000001p+0q
+ {FPBits(0x3fff0000'00000000'00000000'00000003_u128)
+ .get_val(), // 0x1.0000000000000000000000000003p+0q
+ FPBits(0x3fff0000'00000000'00000000'00000001_u128)
+ .get_val()}, // 0x1.0000000000000000000000000001p+0q
+ {FPBits(0x3fff0000'00000000'00000000'00000005_u128)
+ .get_val(), // 0x1.0000000000000000000000000005p+0q
+ FPBits(0x3fff0000'00000000'00000000'00000002_u128)
+ .get_val()}, // 0x1.0000000000000000000000000002p+0q
+ {FPBits(0x3fff0000'00000000'00000000'00000006_u128)
+ .get_val(), // 0x1.0000000000000000000000000006p+0q
+ FPBits(0xbfff0000'00000000'00000000'00000003_u128)
+ .get_val()}, // -0x1.0000000000000000000000000003p+0q
+ {FPBits(0x3fff1d4c'381cbf3a'0aa15b9a'ee344892_u128)
+ .get_val(), // 0x1.1d4c381cbf3a0aa15b9aee344892p+0q
+ FPBits(0x3fff0e40'8c3fadc5'e64b449c'63673f4b_u128)
+ .get_val()}, // 0x1.0e408c3fadc5e64b449c63673f4bp+0q
+ {FPBits(0x3fff2af1'7a4ae6f9'3d11310c'49c11b59_u128)
+ .get_val(), // 0x1.2af17a4ae6f93d11310c49c11b59p+0q
+ FPBits(0xbfff14a3'bdf0ea52'31f12d42'1a5dbe33_u128)
+ .get_val()}, // -0x1.14a3bdf0ea5231f12d421a5dbe33p+0q
+ {FPBits(0x3fff96f8'93bf29fb'91e0fbe1'9a46d0c8_u128)
+ .get_val(), // 0x1.96f893bf29fb91e0fbe19a46d0c8p+0q
+ FPBits(0x3fff42c6'bf6202e6'6f229580'7dee44d9_u128)
+ .get_val()}, // 0x1.42c6bf6202e66f2295807dee44d9p+0q
+ {FPBits(0x3fff97fb'3839925b'66804c42'9289cce8_u128)
+ .get_val(), // 0x1.97fb3839925b66804c429289cce8p+0q
+ FPBits(0xbfff432d'4049ac1c'85a241f3'33d326e9_u128)
+ .get_val()}, // -0x1.432d4049ac1c85a241f333d326e9p+0q
+ {FPBits(0x3fffbe1d'900eaeb1'533f0f19'cc15c7e6_u128)
+ .get_val(), // 0x1.be1d900eaeb1533f0f19cc15c7e6p+0q
+ FPBits(0x3fff51f1'715154da'44f3bf11'f3d96c2d_u128)
+ .get_val()}, // 0x1.51f1715154da44f3bf11f3d96c2dp+0q
+ {FPBits(0x3fffc4f5'07426952'5063a260'51a0ad27_u128)
+ .get_val(), // 0x1.c4f5074269525063a26051a0ad27p+0q
+ FPBits(0x3fff5486'4e9b1daa'4d9135ff'00663366_u128)
+ .get_val()}, // 0x1.54864e9b1daa4d9135ff00663366p+0q
+ {FPBits(0x4000035c'b5f298a8'01dc4be9'b1f8cd97_u128)
+ .get_val(), // 0x1.035cb5f298a801dc4be9b1f8cd97p+1q
+ FPBits(0xbfff6c68'8775bffc'b3f507ba'11d0abb9_u128)
+ .get_val()}, // -0x1.6c688775bffcb3f507ba11d0abb9p+0q
+ {FPBits(0x4000274b'e0238042'7e709bea'b4dedeb4_u128)
+ .get_val(), // 0x1.274be02380427e709beab4dedeb4p+1q
+ FPBits(0xbfff84d5'763281f2'31842239'2e506b1c_u128)
+ .get_val()}, // -0x1.84d5763281f2318422392e506b1cp+0q
+ {FPBits(0x400064e7'97cfdbaa'3f7e2f33'279dbc60_u128)
+ .get_val(), // 0x1.64e797cfdbaa3f7e2f33279dbc6p+1q
+ FPBits(0x3fffab79'b164e255'b26eca00'ff99cc99_u128)
+ .get_val()}, // 0x1.ab79b164e255b26eca00ff99cc99p+0q
+ {FPBits(0x4000693a'741358c9'dac44a57'0a7e9f6c_u128)
+ .get_val(), // 0x1.693a741358c9dac44a570a7e9f6cp+1q
+ FPBits(0x3fffae0e'8eaeab25'bb0c40ee'0c2693d3_u128)
+ .get_val()}, // 0x1.ae0e8eaeab25bb0c40ee0c2693d3p+0q
+ {FPBits(0x40008275'db3fc4d8'22596047'adcb71b9_u128)
+ .get_val(), // 0x1.8275db3fc4d822596047adcb71b9p+1q
+ FPBits(0xbfffbcd2'bfb653e3'7a5dbe0c'cc2cd917_u128)
+ .get_val()}, // -0x1.bcd2bfb653e37a5dbe0ccc2cd917p+0q
+ {FPBits(0x40008328'0bb98c4a'7b88bd6f'535899d9_u128)
+ .get_val(), // 0x1.83280bb98c4a7b88bd6f535899d9p+1q
+ FPBits(0x3fffbd39'409dfd19'90dd6a7f'8211bb27_u128)
+ .get_val()}, // 0x1.bd39409dfd1990dd6a7f8211bb27p+0q
+ {FPBits(0x4000d78d'8352b486'08b510bf'd5c75315_u128)
+ .get_val(), // 0x1.d78d8352b48608b510bfd5c75315p+1q
+ FPBits(0xbfffeb5c'420f15ad'ce0ed2bd'e5a241ce_u128)
+ .get_val()}, // -0x1.eb5c420f15adce0ed2bde5a241cep+0q
+ {FPBits(0x4000e3e4'774f564b'526edff8'4ce46668_u128)
+ .get_val(), // 0x1.e3e4774f564b526edff84ce46668p+1q
+ FPBits(0x3ffff1bf'73c0523a'19b4bb63'9c98c0b5_u128)
+ .get_val()}, // 0x1.f1bf73c0523a19b4bb639c98c0b5p+0q
+ {FPBits(0x4000ffff'ffffffff'ffffffff'fffffffa_u128)
+ .get_val(), // 0x1.fffffffffffffffffffffffffffap+1q
+ FPBits(0xbfffffff'ffffffff'ffffffff'fffffffd_u128)
+ .get_val()}, // -0x1.fffffffffffffffffffffffffffdp+0q
+ {FPBits(0x4000ffff'ffffffff'ffffffff'fffffffb_u128)
+ .get_val(), // 0x1.fffffffffffffffffffffffffffbp+1q
+ FPBits(0x3fffffff'ffffffff'ffffffff'fffffffd_u128)
+ .get_val()}, // 0x1.fffffffffffffffffffffffffffdp+0q
+ {FPBits(0x4000ffff'ffffffff'ffffffff'fffffffd_u128)
+ .get_val(), // 0x1.fffffffffffffffffffffffffffdp+1q
+ FPBits(0x3fffffff'ffffffff'ffffffff'fffffffe_u128)
+ .get_val()}, // 0x1.fffffffffffffffffffffffffffep+0q
+ {FPBits(0x4000ffff'ffffffff'ffffffff'fffffffe_u128)
+ .get_val(), // 0x1.fffffffffffffffffffffffffffep+1q
+ FPBits(0xbfffffff'ffffffff'ffffffff'ffffffff_u128)
+ .get_val()}, // -0x1.ffffffffffffffffffffffffffffp+0q
+ {FPBits(0x4000ffff'ffffffff'ffffffff'ffffffff_u128)
+ .get_val(), // 0x1.ffffffffffffffffffffffffffffp+1q
+ FPBits(0x3fffffff'ffffffff'ffffffff'ffffffff_u128)
+ .get_val()}, // 0x1.ffffffffffffffffffffffffffffp+0q
};
auto rnd = [](float128 x, RoundingMode rm) -> float128 {
- bool is_neg = x < 0;
+ bool is_neg = x < float128(0);
float128 y = is_neg ? -x : x;
FPBits ybits(y);
@@ -108,11 +176,26 @@ TEST_F(LlvmLibcSqrtTest, HardToRound) {
// Exact results for subnormal arguments
float128 EXACT_SUBNORMAL[][2] = {
- {0x0.0000000000000000000000000001p-16382q, 0x1p-8247q},
- {0x0.0000000000000000000000000004p-16382q, 0x1p-8246q},
- {0x0.0000000000001000000000000000p-16382q, 0x1p-8217q},
- {0x0.0000000000010000000000000000p-16382q, 0x1p-8215q},
- {0x0.0000000000100000000000000000p-16382q, 0x1p-8213q},
+ {FPBits(0x00000000'00000000'00000000'00000001_u128)
+ .get_val(), // 0x0.0000000000000000000000000001p-16382q
+ FPBits(0x1fc80000'00000000'00000000'00000000_u128)
+ .get_val()}, // 0x1p-8247q
+ {FPBits(0x00000000'00000000'00000000'00000004_u128)
+ .get_val(), // 0x0.0000000000000000000000000004p-16382q
+ FPBits(0x1fc90000'00000000'00000000'00000000_u128)
+ .get_val()}, // 0x1p-8246q
+ {FPBits(0x00000000'00000000'10000000'00000000_u128)
+ .get_val(), // 0x0.0000000000001000000000000000p-16382q
+ FPBits(0x1fe60000'00000000'00000000'00000000_u128)
+ .get_val()}, // 0x1p-8217q
+ {FPBits(0x00000000'00000001'00000000'00000000_u128)
+ .get_val(), // 0x0.0000000000010000000000000000p-16382q
+ FPBits(0x1fe80000'00000000'00000000'00000000_u128)
+ .get_val()}, // 0x1p-8215q
+ {FPBits(0x00000000'00000010'00000000'00000000_u128)
+ .get_val(), // 0x0.0000000000100000000000000000p-16382q
+ FPBits(0x1fea0000'00000000'00000000'00000000_u128)
+ .get_val()}, // 0x1p-8213q
};
for (auto t : EXACT_SUBNORMAL)
diff --git a/libc/test/src/math/sqrtf128_test.cpp b/libc/test/src/math/sqrtf128_test.cpp
index 25229f834d33c..a04d21f040075 100644
--- a/libc/test/src/math/sqrtf128_test.cpp
+++ b/libc/test/src/math/sqrtf128_test.cpp
@@ -8,32 +8,58 @@
#include "SqrtTest.h"
+#include "src/__support/FPUtil/float128.h"
+#include "src/__support/integer_literals.h"
#include "src/math/sqrtf128.h"
-#include "src/__support/integer_literals.h"
+using LIBC_NAMESPACE::operator""_u128;
+
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
LIST_SQRT_TESTS(float128, LIBC_NAMESPACE::sqrtf128)
TEST_F(LlvmLibcSqrtTest, SpecialInputs) {
- constexpr float128 INPUTS[] = {
- 0x0.000000dee2f5b6a26c8f07f05442p-16382q,
- 0x0.000000c86d174c5ad8ae54a548e7p-16382q,
- 0x0.000020ab15cfe0b8e488e128f535p-16382q,
- 0x0.0000219e97732a9970f2511989bap-16382q,
- 0x0.000026e477546ae99ef57066f9fdp-16382q,
- 0x0.00002d0f88d27a496b3e533f5067p-16382q,
- 0x1.0000000000000000000000000001p+0q,
- 0x1.0000000000000000000000000003p+0q,
- 0x1.0000000000000000000000000005p+0q,
- 0x1.2af17a4ae6f93d11310c49c11b59p+0q,
- 0x1.c4f5074269525063a26051a0ad27p+0q,
- 0x1.035cb5f298a801dc4be9b1f8cd97p+1q,
- 0x1.274be02380427e709beab4dedeb4p+1q,
- 0x1.64e797cfdbaa3f7e2f33279dbc6p+1q,
- 0x1.d78d8352b48608b510bfd5c75315p+1q,
- 0x1.fffffffffffffffffffffffffffbp+1q,
- 0x1.fffffffffffffffffffffffffffdp+1q,
- 0x1.ffffffffffffffffffffffffffffp+1q,
+ using FPBits = LIBC_NAMESPACE::fputil::FPBits<float128>;
+
+ float128 INPUTS[] = {
+ FPBits(0x00000000'00dee2f5'b6a26c8f'07f05442_u128)
+ .get_val(), // 0x0.000000dee2f5b6a26c8f07f05442p-16382q
+ FPBits(0x00000000'00c86d17'4c5ad8ae'54a548e7_u128)
+ .get_val(), // 0x0.000000c86d174c5ad8ae54a548e7p-16382q
+ FPBits(0x00000000'20ab15cf'e0b8e488'e128f535_u128)
+ .get_val(), // 0x0.000020ab15cfe0b8e488e128f535p-16382q
+ FPBits(0x00000000'219e9773'2a9970f2'511989ba_u128)
+ .get_val(), // 0x0.0000219e97732a9970f2511989bap-16382q
+ FPBits(0x00000000'26e47754'6ae99ef5'7066f9fd_u128)
+ .get_val(), // 0x0.000026e477546ae99ef57066f9fdp-16382q
+ FPBits(0x00000000'2d0f88d2'7a496b3e'533f5067_u128)
+ .get_val(), // 0x0.00002d0f88d27a496b3e533f5067p-16382q
+ FPBits(0x3fff0000'00000000'00000000'00000001_u128)
+ .get_val(), // 0x1.0000000000000000000000000001p+0q
+ FPBits(0x3fff0000'00000000'00000000'00000003_u128)
+ .get_val(), // 0x1.0000000000000000000000000003p+0q
+ FPBits(0x3fff0000'00000000'00000000'00000005_u128)
+ .get_val(), // 0x1.0000000000000000000000000005p+0q
+ FPBits(0x3fff2af1'7a4ae6f9'3d11310c'49c11b59_u128)
+ .get_val(), // 0x1.2af17a4ae6f93d11310c49c11b59p+0q
+ FPBits(0x3fffc4f5'07426952'5063a260'51a0ad27_u128)
+ .get_val(), // 0x1.c4f5074269525063a26051a0ad27p+0q
+ FPBits(0x4000035c'b5f298a8'01dc4be9'b1f8cd97_u128)
+ .get_val(), // 0x1.035cb5f298a801dc4be9b1f8cd97p+1q
+ FPBits(0x4000274b'e0238042'7e709bea'b4dedeb4_u128)
+ .get_val(), // 0x1.274be02380427e709beab4dedeb4p+1q
+ FPBits(0x400064e7'97cfdbaa'3f7e2f33'279dbc60_u128)
+ .get_val(), // 0x1.64e797cfdbaa3f7e2f33279dbc6p+1q
+ FPBits(0x4000d78d'8352b486'08b510bf'd5c75315_u128)
+ .get_val(), // 0x1.d78d8352b48608b510bfd5c75315p+1q
+ FPBits(0x4000ffff'ffffffff'ffffffff'fffffffb_u128)
+ .get_val(), // 0x1.fffffffffffffffffffffffffffbp+1q
+ FPBits(0x4000ffff'ffffffff'ffffffff'fffffffd_u128)
+ .get_val(), // 0x1.fffffffffffffffffffffffffffdp+1q
+ FPBits(0x4000ffff'ffffffff'ffffffff'ffffffff_u128)
+ .get_val(), // 0x1.ffffffffffffffffffffffffffffp+1q
};
for (auto input : INPUTS) {
>From 2bc72da0d462387d9caa6754bc394c6117c3663c Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Sun, 16 Aug 2026 01:11:18 +0530
Subject: [PATCH 2/7] entrypoints
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 2 +-
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
13 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 09b81be24c8d8..ac91edabb3ef6 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -569,6 +569,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -790,7 +791,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index d6cb433ba01a5..143bf6c552545 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -581,6 +581,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -801,7 +802,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index b7a7b9aa7142b..9ade4f9954d7e 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -577,6 +577,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -798,7 +799,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 9642dacf6426d..4f04feafb3dab 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -388,6 +388,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -610,7 +611,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 9ece581ce10eb..370299bc7f71b 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -224,6 +224,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.sinf
#libc.src.math.sqrt
#libc.src.math.sqrtf
+ libc.src.math.sqrtf128
#libc.src.math.sqrtl
#libc.src.math.tanf
#libc.src.math.tanhf
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index bb468f0467d23..4497748fc7443 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -282,6 +282,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinhf
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -548,7 +549,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index e44147e9699f4..83c44d37bc5b7 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -512,6 +512,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index efd4fb8fc5682..2d7e824d54d8c 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -509,6 +509,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 04dbcb4e4cf9e..61e8fd2205bde 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -723,6 +723,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -938,7 +939,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 83c3b65498f0c..381fab85d46d4 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -539,6 +539,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinhf
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 81ef813a1fa64..157c5ba4e0606 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -796,6 +796,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -1028,7 +1029,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 37576491a73bb..a20c6e569d684 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -801,6 +801,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinpif
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
@@ -1033,7 +1034,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.scalbnf128
libc.src.math.setpayloadf128
libc.src.math.setpayloadsigf128
- libc.src.math.sqrtf128
libc.src.math.totalorderf128
libc.src.math.totalordermagf128
libc.src.math.truncf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index bdc209bd330b5..3c7bb5968b433 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -315,6 +315,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.sinhf
libc.src.math.sqrt
libc.src.math.sqrtf
+ libc.src.math.sqrtf128
libc.src.math.sqrtl
libc.src.math.tan
libc.src.math.tanf
>From f729bbae0aac90e0adc3702fd646cfd3f3f032d4 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Sun, 16 Aug 2026 01:23:03 +0530
Subject: [PATCH 3/7] nits
---
libc/test/src/math/CMakeLists.txt | 2 ++
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/sqrtf128_test.cpp | 1 -
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libc/test/src/math/CMakeLists.txt b/libc/test/src/math/CMakeLists.txt
index 17029bdcefd46..362eb946a02f6 100644
--- a/libc/test/src/math/CMakeLists.txt
+++ b/libc/test/src/math/CMakeLists.txt
@@ -1807,6 +1807,8 @@ add_fp_unittest(
SqrtTest.h
DEPENDS
libc.src.math.sqrtf128
+ libc.src.__support.FPUtil.float128
+ libc.src.__support.integer_literals
)
add_fp_unittest(
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 6e3c545a366f0..2d56d2df78a18 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3611,6 +3611,7 @@ add_fp_unittest(
DEPENDS
libc.src.math.sqrtf128
libc.src.__support.FPUtil.float128
+ libc.src.__support.integer_literals
)
add_fp_unittest(
diff --git a/libc/test/src/math/smoke/sqrtf128_test.cpp b/libc/test/src/math/smoke/sqrtf128_test.cpp
index e2fa9bad8674c..646be121c903a 100644
--- a/libc/test/src/math/smoke/sqrtf128_test.cpp
+++ b/libc/test/src/math/smoke/sqrtf128_test.cpp
@@ -10,7 +10,6 @@
#include "src/__support/FPUtil/float128.h"
#include "src/__support/integer_literals.h"
-#include "src/__support/uint128.h"
#include "src/math/sqrtf128.h"
#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
>From 821af0a4f0f2f4839a307de5f0bcdc34d231cdbe Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Sun, 16 Aug 2026 01:38:59 +0530
Subject: [PATCH 4/7] generic_sqrtf128
---
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/generic_sqrtf128_test.cpp | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 2d56d2df78a18..1b055a4743c3e 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3681,6 +3681,7 @@ add_fp_unittest(
# The dependency on sqrtf128 is used to disable the test when float128
# support is not available.
libc.src.math.sqrtf128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
${libc_opt_high_flag}
diff --git a/libc/test/src/math/smoke/generic_sqrtf128_test.cpp b/libc/test/src/math/smoke/generic_sqrtf128_test.cpp
index 790ff0a47bd3a..e35d522597fa1 100644
--- a/libc/test/src/math/smoke/generic_sqrtf128_test.cpp
+++ b/libc/test/src/math/smoke/generic_sqrtf128_test.cpp
@@ -8,6 +8,11 @@
#include "SqrtTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/FPUtil/generic/sqrt.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_SQRT_TESTS(float128, LIBC_NAMESPACE::fputil::sqrt<float128>);
>From 5fa1a8d4ec13465ae4b8362f766779bfa12f88b0 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Tue, 18 Aug 2026 12:58:54 +0530
Subject: [PATCH 5/7] nits
---
libc/config/darwin/x86_64/entrypoints.txt | 2 +-
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/math/generic/CMakeLists.txt | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 370299bc7f71b..f5a0cab82b26a 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -224,7 +224,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.sinf
#libc.src.math.sqrt
#libc.src.math.sqrtf
- libc.src.math.sqrtf128
+ #libc.src.math.sqrtf128
#libc.src.math.sqrtl
#libc.src.math.tanf
#libc.src.math.tanhf
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index b97c40bf2fe86..681e12527458e 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -5398,12 +5398,12 @@ add_header_library(
DEPENDS
libc.src.__support.CPP.bit
libc.src.__support.FPUtil.fenv_impl
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.rounding_mode
libc.src.__support.common
libc.src.__support.macros.optimization
libc.src.__support.uint128
- libc.src.__support.FPUtil.float128
)
add_header_library(
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 2c097ef89e473..70a65cfb07b71 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2698,8 +2698,8 @@ add_entrypoint_object(
HDRS
../sqrtf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.sqrtf128
- libc.src.__support.CPP.bit
)
add_entrypoint_object(
>From 81cfc7f2dd82ca23fa86027112ba2a9ae53c2260 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Tue, 18 Aug 2026 21:23:20 +0530
Subject: [PATCH 6/7] bazel
---
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++-
.../llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 28c017fb6779c..9c4f81cb6cd3a 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -9391,11 +9391,11 @@ libc_support_library(
":__support_common",
":__support_cpp_bit",
":__support_fputil_fenv_impl",
+ ":__support_fputil_float128",
":__support_fputil_fp_bits",
":__support_fputil_rounding_mode",
":__support_macros_optimization",
":__support_uint128",
- ":llvm_libc_types_float128",
],
)
@@ -13567,6 +13567,8 @@ libc_math_function(
libc_math_function(
name = "sqrtf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_sqrtf128",
],
)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index 2eb58f3f66807..33b708e2e2e6b 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -297,6 +297,9 @@ math_test(
math_test(
name = "sqrtf128",
hdrs = ["SqrtTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
)
math_test(
>From 0ee7bd3ce0af1d3ebfb783be89e8e9a2480f25ab Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Wed, 19 Aug 2026 11:04:01 +0530
Subject: [PATCH 7/7] remove dep from bazel
---
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 1 -
1 file changed, 1 deletion(-)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 9c4f81cb6cd3a..7a618340d6f46 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -13568,7 +13568,6 @@ libc_math_function(
name = "sqrtf128",
additional_deps = [
":__support_cpp_bit",
- ":__support_fputil_float128",
":__support_math_sqrtf128",
],
)
More information about the llvm-commits
mailing list