[llvm] [RISCV][MC] Prioritize features in MultiMismatchFallback (PR #215737)

via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 16 23:19:11 PDT 2026


================
@@ -3455,6 +3455,32 @@ getNameForFeatureBitset(ArrayRef<const Record *> FeatureBitset) {
   return Name;
 }
 
+static void emitFeatureCheck(raw_ostream &OS, bool ReportMultipleNearMisses) {
----------------
saloni-shinde-Q wrote:

Thanks for the suggestion. I noticed that emitMnemonicChecker and emitMatchClassKindNames are also implemented as separate file-local static helpers, even though each is called only once from AsmMatcherEmitter::run(...). I followed the same existing pattern for emitFeatureCheck, keeping the code-emission logic in a separate helper rather than embedding it in a lambda. Based on this pattern, I thought a separate static helper would be consistent with the surrounding code. Do you still prefer moving it into a lambda inside run(), or would keeping it as a file-local helper be acceptable?

https://github.com/llvm/llvm-project/pull/215737


More information about the llvm-commits mailing list