[llvm] preserve numeric operand sign in minimumnum & maximumnum (PR #216561)

via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 16 04:40:19 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/X86/X86ISelLowering.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index e5908c0b9..100f666a3 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -30213,8 +30213,7 @@ static SDValue LowerFMINIMUM_FMAXIMUM(SDValue Op, const X86Subtarget &Subtarget,
   // Signed-zero correction above can change the sign of the numeric operand
   // when NewX is NaN. For minimumnum/maximumnum, restore NewY in that case.
   if (ShouldHandleZeros && IsNum && !IgnoreNaN && !IsXNeverNaN) {
-    SDValue IsXNaN =
-        DAG.getSetCC(DL, SetCCType, NewX, NewX, ISD::SETUO);
+    SDValue IsXNaN = DAG.getSetCC(DL, SetCCType, NewX, NewX, ISD::SETUO);
     MinMax = DAG.getSelect(DL, VT, IsXNaN, NewY, MinMax);
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/216561


More information about the llvm-commits mailing list