[llvm] [llvm][utils] Correct release package links for Windows (PR #215770)
Cullen Rhodes via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 12 04:54:10 PDT 2026
================
@@ -144,11 +148,24 @@ def generate_download_links(release):
)
markdown_lines = []
+ # Windows installers use Wix which does not support version strings with
+ # characters. To work around this, "X.1.0-rcZ" is changed to "X.0.0.Z".
+ # Equivalent to what is done in .github/workflows/release-binaries.yml.
+ windows_release = release
+ if "-rc" in windows_release:
+ version, rc = windows_release.split("-")
+ major_version = version.split(".")[0]
+ rc_number = rc.replace("rc", "")
+ windows_release = f"{major_version}.0.0.{rc_number}"
+
for section in release_links:
for line in section:
comment_tag, format_string, files = line
markdown_line = f"<!-- {comment_tag} "
- files = [base_url + f.format(release=release) for f in files]
+ files = [
+ base_url + f.format(release=release, windows_release=release)
----------------
c-rhodes wrote:
should be?
```suggestion
base_url + f.format(release=release, windows_release=windows_release)
```
https://github.com/llvm/llvm-project/pull/215770
More information about the llvm-commits
mailing list