[llvm] fd6a100 - [IR][NFC] Remove unused helpers for inserting dbg intrinsics (#212304)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 01:56:45 PDT 2026
Author: Marc Auberer
Date: 2026-08-11T10:56:41+02:00
New Revision: fd6a1005763547465f30576080e2120570867b39
URL: https://github.com/llvm/llvm-project/commit/fd6a1005763547465f30576080e2120570867b39
DIFF: https://github.com/llvm/llvm-project/commit/fd6a1005763547465f30576080e2120570867b39.diff
LOG: [IR][NFC] Remove unused helpers for inserting dbg intrinsics (#212304)
As a result of the almost complete transition from debug intrinsics to
debug records, a few functions are now unused in the public API. This
patch removes those.
Added:
Modified:
llvm/include/llvm/IR/DIBuilder.h
llvm/lib/IR/DIBuilder.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/IR/DIBuilder.h b/llvm/include/llvm/IR/DIBuilder.h
index 3acb9c5f955e8..c4aef337eb3cd 100644
--- a/llvm/include/llvm/IR/DIBuilder.h
+++ b/llvm/include/llvm/IR/DIBuilder.h
@@ -90,12 +90,6 @@ namespace llvm {
void insertDbgVariableRecord(DbgVariableRecord *DVR,
InsertPosition InsertPt);
- /// Internal helper with common code used by insertDbg{Value,Addr}Intrinsic.
- Instruction *insertDbgIntrinsic(llvm::Function *Intrinsic, llvm::Value *Val,
- DILocalVariable *VarInfo,
- DIExpression *Expr, const DILocation *DL,
- InsertPosition InsertPt);
-
public:
/// Construct a builder for a module.
///
diff --git a/llvm/lib/IR/DIBuilder.cpp b/llvm/lib/IR/DIBuilder.cpp
index fb18fc3cc90c5..4ad668866d7ef 100644
--- a/llvm/lib/IR/DIBuilder.cpp
+++ b/llvm/lib/IR/DIBuilder.cpp
@@ -17,7 +17,6 @@
#include "llvm/BinaryFormat/Dwarf.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DebugInfo.h"
-#include "llvm/IR/IRBuilder.h"
#include "llvm/IR/Module.h"
#include <optional>
@@ -1181,19 +1180,6 @@ DbgRecord *DIBuilder::insertDbgAssign(Instruction *LinkedInstr, Value *Val,
return DVR;
}
-/// Initialize IRBuilder for inserting dbg.declare and dbg.value intrinsics.
-/// This abstracts over the various ways to specify an insert position.
-static void initIRBuilder(IRBuilder<> &Builder, const DILocation *DL,
- InsertPosition InsertPt) {
- Builder.SetInsertPoint(InsertPt.getBasicBlock(), InsertPt);
- Builder.SetCurrentDebugLocation(DL);
-}
-
-static Value *getDbgIntrinsicValueImpl(LLVMContext &VMContext, Value *V) {
- assert(V && "no value passed to dbg intrinsic");
- return MetadataAsValue::get(VMContext, ValueAsMetadata::get(V));
-}
-
DbgRecord *DIBuilder::insertDbgValue(Value *Val, DILocalVariable *VarInfo,
DIExpression *Expr, const DILocation *DL,
InsertPosition InsertPt) {
@@ -1248,31 +1234,6 @@ void DIBuilder::insertDbgVariableRecord(DbgVariableRecord *DVR,
BB->insertDbgRecordBefore(DVR, InsertPt);
}
-Instruction *DIBuilder::insertDbgIntrinsic(llvm::Function *IntrinsicFn,
- Value *V, DILocalVariable *VarInfo,
- DIExpression *Expr,
- const DILocation *DL,
- InsertPosition InsertPt) {
- assert(IntrinsicFn && "must pass a non-null intrinsic function");
- assert(V && "must pass a value to a dbg intrinsic");
- assert(VarInfo &&
- "empty or invalid DILocalVariable* passed to debug intrinsic");
- assert(DL && "Expected debug loc");
- assert(DL->getScope()->getSubprogram() ==
- VarInfo->getScope()->getSubprogram() &&
- "Expected matching subprograms");
-
- trackIfUnresolved(VarInfo);
- trackIfUnresolved(Expr);
- Value *Args[] = {getDbgIntrinsicValueImpl(VMContext, V),
- MetadataAsValue::get(VMContext, VarInfo),
- MetadataAsValue::get(VMContext, Expr)};
-
- IRBuilder<> B(DL->getContext());
- initIRBuilder(B, DL, InsertPt);
- return B.CreateCall(IntrinsicFn, Args);
-}
-
DbgRecord *DIBuilder::insertLabel(DILabel *LabelInfo, const DILocation *DL,
InsertPosition InsertPt) {
assert(LabelInfo && "empty or invalid DILabel* passed to dbg.label");
More information about the llvm-commits
mailing list