[llvm] workflows/release-binaries: Fixup Windows version string for release candidates (PR #215030)
Cullen Rhodes via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 01:27:03 PDT 2026
================
@@ -375,7 +384,9 @@ jobs:
- name: Upload Artifacts
uses: $/.github/workflows/upload-release-artifact
with:
- release-version: ${{ needs.prepare.outputs.release-version }}
+ # We need to use the inputs.release-version here, because on Windows we
+ # need to fixup the rc version that's stored in needs.prepare.outputs.release-version
+ release-version: ${{ inputs.release-version }}
----------------
c-rhodes wrote:
IIUC for scheduled builds this can be empty but will still get validated on upload: https://github.com/llvm/llvm-project/blob/a5aa84c94a80ed6ffd99dddfc38cc8a499123f76/.github/workflows/release-binaries-all.yml#L90-L94
in which case it would grab source version: https://github.com/llvm/llvm-project/blob/a5aa84c94a80ed6ffd99dddfc38cc8a499123f76/.github/workflows/release-binaries.yml#L110-L111
becoming output here: https://github.com/llvm/llvm-project/blob/a5aa84c94a80ed6ffd99dddfc38cc8a499123f76/.github/workflows/release-binaries.yml#L130
e.g. for this build where release version is empty, then it becomes 24.0.0: https://github.com/llvm/llvm-project/actions/runs/31229160581/job/93041020844
should this account for empty release version by falling back to output one?
```suggestion
release-version: ${{ inputs.release-version || needs.prepare.outputs.release-version }}
```
https://github.com/llvm/llvm-project/pull/215030
More information about the llvm-commits
mailing list