[llvm] [SystemZ][z/OS] Support emitting common symbols in HLASM (PR #215278)

[Maryam Moghadas via llvm-commits]

================
@@ -73,33 +73,38 @@ bool MCGOFFStreamer::emitSymbolAttribute(MCSymbol *Sym,
   return static_cast<MCSymbolGOFF *>(Sym)->setSymbolAttribute(Attribute);
 }
 
-void MCGOFFStreamer::emitCommonSymbol(MCSymbol *S, uint64_t Size,
-                                      Align ByteAlignment) {
-  auto *Symbol = static_cast<MCSymbolGOFF *>(S);
-
-  MCSectionGOFF *SD = getContext().getGOFFSection(
+void MCGOFFStreamer::emitCommonSymbolImpl(MCStreamer *Streamer,
+                                          MCSymbolGOFF *Symbol, uint64_t Size,
----------------
maryammo wrote:

Nit: could `emitCommonSymbolImpl` take `MCSymbol *` instead of `MCSymbolGOFF *`, and do the static_cast internally? That would remove the duplicate cast at both call sites.

https://github.com/llvm/llvm-project/pull/215278