[llvm] 9d3101b - [GlobalISel] Fix vector.deinterleave2 with <1 x float> results (#214718)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 05:06:21 PDT 2026
Author: Mészáros Gergely
Date: 2026-08-10T12:06:15Z
New Revision: 9d3101b4f1d61906cfbdc7d7f8fcb775ddccf236
URL: https://github.com/llvm/llvm-project/commit/9d3101b4f1d61906cfbdc7d7f8fcb775ddccf236
DIFF: https://github.com/llvm/llvm-project/commit/9d3101b4f1d61906cfbdc7d7f8fcb775ddccf236.diff
LOG: [GlobalISel] Fix vector.deinterleave2 with <1 x float> results (#214718)
`translateVectorDeinterleave2Intrinsic` used to try to build
`G_SHUFFLE_VECTOR`
with a scalar result type, which is not valid.
This was the case because the LLT that corresponds to the `<1 x float>`
IR type is a scalar type, not a vector type.
Add a special case for scalar result types to build
`G_EXTRACT_VECTOR_ELT` instead.
Fixes: #214713
Added:
Modified:
llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-vector-deinterleave2.ll
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
index 11e5ac36fc569..221e42b6c09e4 100644
--- a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
@@ -1900,6 +1900,14 @@ bool IRTranslator::translateVectorDeinterleave2Intrinsic(
ArrayRef<Register> Res = getOrCreateVRegs(CI);
LLT ResTy = MRI->getType(Res[0]);
+ if (ResTy.isScalar()) {
+ MIRBuilder.buildExtractVectorElementConstant(Res[0], Op, 0);
+ MIRBuilder.buildExtractVectorElementConstant(Res[1], Op, 1);
+
+ return true;
+ }
+
+ assert(ResTy.isVector() && "Expected vector result type");
MIRBuilder.buildShuffleVector(Res[0], Op, Undef,
createStrideMask(0, 2, ResTy.getNumElements()));
MIRBuilder.buildShuffleVector(Res[1], Op, Undef,
diff --git a/llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-vector-deinterleave2.ll b/llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-vector-deinterleave2.ll
index d818bcb17e1a8..235137273f851 100644
--- a/llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-vector-deinterleave2.ll
+++ b/llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-vector-deinterleave2.ll
@@ -1,6 +1,25 @@
; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 4
; RUN: llc -O0 -mtriple=aarch64-- --global-isel --verify-machineinstrs --stop-after=irtranslator %s -o - | FileCheck %s
+; Check that vector.deinterleave2 with <1 x float> results does not crash in GlobalISel.
+; We used to try to build G_SHUFFLE_VECTOR with a scalar result type, which is not valid.
+define void @vector_deinterleave2_v2f32(<2 x float> %a) {
+ ; CHECK-LABEL: name: vector_deinterleave2_v2f32
+ ; CHECK: bb.1 (%ir-block.0):
+ ; CHECK-NEXT: liveins: $d0
+ ; CHECK-NEXT: {{ $}}
+ ; CHECK-NEXT: [[COPY:%[0-9]+]]:_(<2 x i32>) = COPY $d0
+ ; CHECK-NEXT: [[BITCAST:%[0-9]+]]:_(<2 x f32>) = G_BITCAST [[COPY]](<2 x i32>)
+ ; CHECK-NEXT: [[DEF:%[0-9]+]]:_(<2 x f32>) = G_IMPLICIT_DEF
+ ; CHECK-NEXT: [[C:%[0-9]+]]:_(i64) = G_CONSTANT i64 0
+ ; CHECK-NEXT: [[EVEC:%[0-9]+]]:_(f32) = G_EXTRACT_VECTOR_ELT [[BITCAST]](<2 x f32>), [[C]](i64)
+ ; CHECK-NEXT: [[C1:%[0-9]+]]:_(i64) = G_CONSTANT i64 1
+ ; CHECK-NEXT: [[EVEC1:%[0-9]+]]:_(f32) = G_EXTRACT_VECTOR_ELT [[BITCAST]](<2 x f32>), [[C1]](i64)
+ ; CHECK-NEXT: RET_ReallyLR
+ %res = call { <1 x float>, <1 x float> } @llvm.vector.deinterleave2.v2f32(<2 x float> %a)
+ ret void
+}
+
define void @vector_deinterleave2_v4i32(<4 x i32> %a) {
; CHECK-LABEL: name: vector_deinterleave2_v4i32
; CHECK: bb.1 (%ir-block.0):
More information about the llvm-commits
mailing list