[llvm] [AMDGPU][MC] Return fail when the decoding is not an VGPR (PR #215101)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 9 07:32:49 PDT 2026


https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/215101

Fixes #215000.


>From 3b0bb10f2bdcb94d1ad07c4cf09d11b8d61c0227 Mon Sep 17 00:00:00 2001
From: Shilei Tian <i at tianshilei.me>
Date: Sun, 9 Aug 2026 10:32:06 -0400
Subject: [PATCH] [AMDGPU][MC] Return fail when the decoding is not an VGPR

Fixes #215000.
---
 .../AMDGPU/Disassembler/AMDGPUDisassembler.cpp      |  3 ++-
 llvm/test/MC/Disassembler/AMDGPU/decode-err.txt     | 13 +++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
index d05997cacba0a..ead98879d19ef 100644
--- a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
+++ b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
@@ -396,7 +396,8 @@ static DecodeStatus decodeOperand_VGPR_16(MCInst &Inst, unsigned Imm,
                                           uint64_t /*Addr*/,
                                           const MCDisassembler *Decoder) {
   assert(isUInt<10>(Imm) && "10-bit encoding expected");
-  assert(Imm & AMDGPU::EncValues::IS_VGPR && "VGPR expected");
+  if (!(Imm & AMDGPU::EncValues::IS_VGPR))
+    return MCDisassembler::Fail;
 
   const auto *DAsm = static_cast<const AMDGPUDisassembler *>(Decoder);
 
diff --git a/llvm/test/MC/Disassembler/AMDGPU/decode-err.txt b/llvm/test/MC/Disassembler/AMDGPU/decode-err.txt
index de9bf7bac9548..a24d5769c63b9 100644
--- a/llvm/test/MC/Disassembler/AMDGPU/decode-err.txt
+++ b/llvm/test/MC/Disassembler/AMDGPU/decode-err.txt
@@ -17,6 +17,19 @@
 # GFX12-ERR: [[@LINE+1]]:1: warning: invalid instruction encoding
 0xfa,0x00,0x80,0xd6,0x01,0x00,0x01,0x02
 
+# VINTERP true16 source operands must have the VGPR selector bit set.
+# GFX12-ERR: [[@LINE+1]]:1: warning: invalid instruction encoding
+0x00,0x00,0x02,0xcd,0x00,0x00,0x00,0x00
+
+# GFX12-ERR: [[@LINE+1]]:1: warning: invalid instruction encoding
+0x00,0x00,0x03,0xcd,0x00,0x00,0x00,0x00
+
+# GFX12-ERR: [[@LINE+1]]:1: warning: invalid instruction encoding
+0x00,0x00,0x04,0xcd,0x00,0x00,0x00,0x00
+
+# GFX12-ERR: [[@LINE+1]]:1: warning: invalid instruction encoding
+0x00,0x00,0x05,0xcd,0x00,0x00,0x00,0x00
+
 # this is s_waitcnt_vscnt exec_hi, 0x1234, which is valid on gfx11, but not on gfx12
 # GFX12-ERR: [[@LINE+1]]:1: warning: invalid instruction encoding
 0x34,0x12,0x7f,0xbc



More information about the llvm-commits mailing list