[llvm] [LAA][NFC] Factor out MemoryDepChecker::isStoreLoadForwardingConflict (PR #212085)

via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 8 18:53:52 PDT 2026


mbhade-amd wrote:

> Unfortunately, the function is already incorrect, and Andrei is working on fixing it (see https://github.com/llvm/llvm-project/pull/208791/changes#r3633845688). I don't think factoring out code from it is productive in this state?

Thanks — [#208791](https://github.com/llvm/llvm-project/pull/208791) has now merged (Aug 3). It only added the CommonStride parameter and a separate post-loop strided block; the inner predicate this PR extracts is unchanged, so the factor-out is still NFC. I've rebased onto current main and also addressed the review comment — the helper now asserts VectorStoreSize != 0 and drops the runtime guard. PTAL.

https://github.com/llvm/llvm-project/pull/212085


More information about the llvm-commits mailing list