[llvm] [VectorCombine] Fold Deinterleave/Interleave Pairs (PR #211022)
Jacob Crawley via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 7 09:09:32 PDT 2026
================
----------------
jacob-crawley wrote:
I'm fairly torn on this myself too :sweat_smile:
I agree having the class makes the main function more concise, but its not really adding much more than that.
The previous version did feel like a very bulky function but the class hasn't cut down on the amount of code, its just been moved elsewhere.
Although it doesn't flow as well going between the fold and class functions, I think having the class functions provide a clear name for what each section is doing has some value.
I don't have a particularly strong opinion either way here so I'm open to any suggestions.
https://github.com/llvm/llvm-project/pull/211022
More information about the llvm-commits
mailing list