[clang] [llvm] [LLVMOffload] Add more error types + GetLastError/PeekAtLastError (PR #213389)
Kevin Sala Penades via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 7 07:21:21 PDT 2026
================
@@ -36,12 +37,12 @@ using ThreadState = llvm::offload::ThreadStateTy;
Error_t Malloc(void **DevPtr, size_t Size) {
ol_device_handle_t Device = ThreadState::getDefaultDevice();
ol_result_t Result = olMemAlloc(Device, OL_ALLOC_TYPE_DEVICE, Size, DevPtr);
- return convertResult(Result);
+ return SetLastError(convertResult(Result));
}
Error_t Free(void *DevPtr) {
ol_result_t Result = olMemFree(DevPtr);
- return convertResult(Result);
+ return SetLastError(convertResult(Result));
----------------
kevinsala wrote:
I see many cases like `SetLastError(convertResult(Result))`. Would it be worth adding an overloaded function that accepts the ol_result_t and converts it directly?
https://github.com/llvm/llvm-project/pull/213389
More information about the llvm-commits
mailing list