[llvm] [Transforms][Utils] Handle live-outs not defined in the loop in LoopSplitUtils (PR #214453)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 04:03:35 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Ashutosh Nema (nema-ashutosh)
<details>
<summary>Changes</summary>
Such a value is identical in every partition and needs no per-partition
reconstruction, so replace its LCSSA phi is enough.
---
Full diff: https://github.com/llvm/llvm-project/pull/214453.diff
4 Files Affected:
- (modified) llvm/lib/Transforms/Utils/LoopSplitUtils.cpp (+12-2)
- (added) llvm/test/Transforms/LoopSplit/constant-live-out.ll (+59)
- (added) llvm/test/Transforms/LoopSplit/outside-def-live-out.ll (+57)
- (modified) llvm/test/Transforms/LoopSplit/reduction.ll (+133)
``````````diff
diff --git a/llvm/lib/Transforms/Utils/LoopSplitUtils.cpp b/llvm/lib/Transforms/Utils/LoopSplitUtils.cpp
index db07e3f571f66..951057fa662fe 100644
--- a/llvm/lib/Transforms/Utils/LoopSplitUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopSplitUtils.cpp
@@ -364,13 +364,23 @@ void LoopSplitUtils::collectEscapingValues(SplitState &S) {
assert(LCSSAPhi.getNumIncomingValues() == 1 &&
"exit block not in LCSSA form");
Value *LiveOutDef = LCSSAPhi.getIncomingValue(0);
+ LCSSAPhi.replaceAllUsesWith(LiveOutDef);
+ LCSSAPhi.eraseFromParent();
+
+ // A live-out not defined inside the loop (constant or loop-invariant) holds
+ // the same value in every partition, so the replaceAllUsesWith above is
+ // already correct and it needs no per-partition reconstruction. Skipping it
+ // also avoids walking uses() on a constant (which has no use list) and
+ // rewriting any pre-loop uses of an outside definition.
+ auto *DefInst = dyn_cast<Instruction>(LiveOutDef);
+ if (!DefInst || !L->contains(DefInst))
+ continue;
+
auto Existing = CarriedDefToEscapingIdx.find(LiveOutDef);
auto &EV = Existing != CarriedDefToEscapingIdx.end()
? S.Escaping[Existing->second]
: S.addEscaping(LiveOutDef);
EV.EscapesOutside = true;
- LCSSAPhi.replaceAllUsesWith(LiveOutDef);
- LCSSAPhi.eraseFromParent();
}
// Seed partition 0 with the originals; later partitions are filled when
diff --git a/llvm/test/Transforms/LoopSplit/constant-live-out.ll b/llvm/test/Transforms/LoopSplit/constant-live-out.ll
new file mode 100644
index 0000000000000..0f5d51a3612e5
--- /dev/null
+++ b/llvm/test/Transforms/LoopSplit/constant-live-out.ll
@@ -0,0 +1,59 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
+; RUN: opt -passes=loop-split-utils -loop-split-points=50 -S < %s | FileCheck %s
+
+; A live-out whose exit value is a constant is not defined inside the loop, so
+; it needs no per-partition reconstruction. The transform must not treat it as
+; an escaping value (which would walk uses() on a constant and crash).
+
+define i64 @const_live_out(ptr %a, i64 %n) {
+; CHECK-LABEL: define i64 @const_live_out(
+; CHECK-SAME: ptr [[A:%.*]], i64 [[N:%.*]]) {
+; CHECK-NEXT: [[LS_GUARD0:.*:]]
+; CHECK-NEXT: [[SMAX:%.*]] = call i64 @llvm.smax.i64(i64 [[N]], i64 1)
+; CHECK-NEXT: [[TMP0:%.*]] = add nsw i64 [[SMAX]], -1
+; CHECK-NEXT: [[SMIN:%.*]] = call i64 @llvm.smin.i64(i64 [[TMP0]], i64 49)
+; CHECK-NEXT: [[ITR_CHK:%.*]] = icmp sle i64 0, [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK]], label %[[ENTRY:.*]], label %[[LS_GUARD1:.*]]
+; CHECK: [[ENTRY]]:
+; CHECK-NEXT: br label %[[LOOP:.*]]
+; CHECK: [[LOOP]]:
+; CHECK-NEXT: [[IV:%.*]] = phi i64 [ 0, %[[ENTRY]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
+; CHECK-NEXT: [[P:%.*]] = getelementptr i64, ptr [[A]], i64 [[IV]]
+; CHECK-NEXT: store i64 [[IV]], ptr [[P]], align 4
+; CHECK-NEXT: [[IV_NEXT]] = add i64 [[IV]], 1
+; CHECK-NEXT: [[ITR_CHK1:%.*]] = icmp sle i64 [[IV_NEXT]], [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK1]], label %[[LOOP]], label %[[EXIT:.*]]
+; CHECK: [[EXIT]]:
+; CHECK-NEXT: br label %[[LS_GUARD1]]
+; CHECK: [[LS_GUARD1]]:
+; CHECK-NEXT: [[ITR_CHK2:%.*]] = icmp sle i64 50, [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK2]], label %[[ENTRY_LS1:.*]], label %[[LS_FINAL_EXIT:.*]]
+; CHECK: [[ENTRY_LS1]]:
+; CHECK-NEXT: br label %[[LOOP_LS1:.*]]
+; CHECK: [[LOOP_LS1]]:
+; CHECK-NEXT: [[IV_LS1:%.*]] = phi i64 [ 50, %[[ENTRY_LS1]] ], [ [[IV_NEXT_LS1:%.*]], %[[LOOP_LS1]] ]
+; CHECK-NEXT: [[P_LS1:%.*]] = getelementptr i64, ptr [[A]], i64 [[IV_LS1]]
+; CHECK-NEXT: store i64 [[IV_LS1]], ptr [[P_LS1]], align 4
+; CHECK-NEXT: [[IV_NEXT_LS1]] = add i64 [[IV_LS1]], 1
+; CHECK-NEXT: [[ITR_CHK3:%.*]] = icmp sle i64 [[IV_NEXT_LS1]], [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK3]], label %[[LOOP_LS1]], label %[[LS_EXIT1:.*]]
+; CHECK: [[LS_EXIT1]]:
+; CHECK-NEXT: br label %[[LS_FINAL_EXIT]]
+; CHECK: [[LS_FINAL_EXIT]]:
+; CHECK-NEXT: ret i64 42
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %p = getelementptr i64, ptr %a, i64 %iv
+ store i64 %iv, ptr %p
+ %iv.next = add i64 %iv, 1
+ %ec = icmp slt i64 %iv.next, %n
+ br i1 %ec, label %loop, label %exit
+
+exit:
+ %lo = phi i64 [ 42, %loop ]
+ ret i64 %lo
+}
diff --git a/llvm/test/Transforms/LoopSplit/outside-def-live-out.ll b/llvm/test/Transforms/LoopSplit/outside-def-live-out.ll
new file mode 100644
index 0000000000000..7ebe33d78cd90
--- /dev/null
+++ b/llvm/test/Transforms/LoopSplit/outside-def-live-out.ll
@@ -0,0 +1,57 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
+; RUN: opt -passes=loop-split-utils -loop-split-points=50 -S < %s | FileCheck %s
+
+; The live-out value is defined outside the loop and also has a use before the
+; loop. Such a value is identical in every partition, so it must not be rebuilt
+; per-partition; in particular the pre-loop use must not be rewritten to poison.
+
+define i64 @outside_def_live_out(ptr %a, i64 %n, i64 %x) {
+; CHECK-LABEL: define i64 @outside_def_live_out(
+; CHECK-SAME: ptr [[A:%.*]], i64 [[N:%.*]], i64 [[X:%.*]]) {
+; CHECK-NEXT: [[LS_GUARD0:.*:]]
+; CHECK-NEXT: [[PRE:%.*]] = add i64 [[X]], 7
+; CHECK-NEXT: store i64 [[PRE]], ptr [[A]], align 4
+; CHECK-NEXT: [[SMAX:%.*]] = call i64 @llvm.smax.i64(i64 [[N]], i64 1)
+; CHECK-NEXT: [[TMP0:%.*]] = add nsw i64 [[SMAX]], -1
+; CHECK-NEXT: [[SMIN:%.*]] = call i64 @llvm.smin.i64(i64 [[TMP0]], i64 49)
+; CHECK-NEXT: [[ITR_CHK:%.*]] = icmp sle i64 0, [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK]], label %[[ENTRY:.*]], label %[[LS_GUARD1:.*]]
+; CHECK: [[ENTRY]]:
+; CHECK-NEXT: br label %[[LOOP:.*]]
+; CHECK: [[LOOP]]:
+; CHECK-NEXT: [[IV:%.*]] = phi i64 [ 0, %[[ENTRY]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
+; CHECK-NEXT: [[IV_NEXT]] = add i64 [[IV]], 1
+; CHECK-NEXT: [[ITR_CHK1:%.*]] = icmp sle i64 [[IV_NEXT]], [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK1]], label %[[LOOP]], label %[[EXIT:.*]]
+; CHECK: [[EXIT]]:
+; CHECK-NEXT: br label %[[LS_GUARD1]]
+; CHECK: [[LS_GUARD1]]:
+; CHECK-NEXT: [[ITR_CHK2:%.*]] = icmp sle i64 50, [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK2]], label %[[ENTRY_LS1:.*]], label %[[LS_FINAL_EXIT:.*]]
+; CHECK: [[ENTRY_LS1]]:
+; CHECK-NEXT: br label %[[LOOP_LS1:.*]]
+; CHECK: [[LOOP_LS1]]:
+; CHECK-NEXT: [[IV_LS1:%.*]] = phi i64 [ 50, %[[ENTRY_LS1]] ], [ [[IV_NEXT_LS1:%.*]], %[[LOOP_LS1]] ]
+; CHECK-NEXT: [[IV_NEXT_LS1]] = add i64 [[IV_LS1]], 1
+; CHECK-NEXT: [[ITR_CHK3:%.*]] = icmp sle i64 [[IV_NEXT_LS1]], [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK3]], label %[[LOOP_LS1]], label %[[LS_EXIT1:.*]]
+; CHECK: [[LS_EXIT1]]:
+; CHECK-NEXT: br label %[[LS_FINAL_EXIT]]
+; CHECK: [[LS_FINAL_EXIT]]:
+; CHECK-NEXT: ret i64 [[PRE]]
+;
+entry:
+ %pre = add i64 %x, 7
+ store i64 %pre, ptr %a
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %iv.next = add i64 %iv, 1
+ %ec = icmp slt i64 %iv.next, %n
+ br i1 %ec, label %loop, label %exit
+
+exit:
+ %lo = phi i64 [ %pre, %loop ]
+ ret i64 %lo
+}
diff --git a/llvm/test/Transforms/LoopSplit/reduction.ll b/llvm/test/Transforms/LoopSplit/reduction.ll
index c9cd745469323..8c5f6ee68683b 100644
--- a/llvm/test/Transforms/LoopSplit/reduction.ll
+++ b/llvm/test/Transforms/LoopSplit/reduction.ll
@@ -69,3 +69,136 @@ exit:
%sum.lcssa = phi i64 [ %sum.next, %loop ]
ret i64 %sum.lcssa
}
+
+; A live-out that is computed in the loop but is not a carried header PHI value.
+; It has no value before any partition runs, so its chain entry is poison rather
+; than a PHI's initial value.
+
+define i64 @non_carried_live_out(ptr %a, i64 %n) {
+; CHECK-LABEL: define i64 @non_carried_live_out(
+; CHECK-SAME: ptr [[A:%.*]], i64 [[N:%.*]]) {
+; CHECK-NEXT: [[LS_GUARD0:.*]]:
+; CHECK-NEXT: [[SMAX:%.*]] = call i64 @llvm.smax.i64(i64 [[N]], i64 1)
+; CHECK-NEXT: [[TMP0:%.*]] = add nsw i64 [[SMAX]], -1
+; CHECK-NEXT: [[SMIN:%.*]] = call i64 @llvm.smin.i64(i64 [[TMP0]], i64 49)
+; CHECK-NEXT: [[ITR_CHK:%.*]] = icmp sle i64 0, [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK]], label %[[ENTRY:.*]], label %[[LS_GUARD1:.*]]
+; CHECK: [[ENTRY]]:
+; CHECK-NEXT: br label %[[LOOP:.*]]
+; CHECK: [[LOOP]]:
+; CHECK-NEXT: [[I:%.*]] = phi i64 [ 0, %[[ENTRY]] ], [ [[I_NEXT:%.*]], %[[LOOP]] ]
+; CHECK-NEXT: [[SCALED:%.*]] = mul i64 [[I]], 3
+; CHECK-NEXT: [[P:%.*]] = getelementptr i64, ptr [[A]], i64 [[I]]
+; CHECK-NEXT: store i64 [[SCALED]], ptr [[P]], align 4
+; CHECK-NEXT: [[I_NEXT]] = add i64 [[I]], 1
+; CHECK-NEXT: [[ITR_CHK1:%.*]] = icmp sle i64 [[I_NEXT]], [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK1]], label %[[LOOP]], label %[[EXIT:.*]]
+; CHECK: [[EXIT]]:
+; CHECK-NEXT: br label %[[LS_GUARD1]]
+; CHECK: [[LS_GUARD1]]:
+; CHECK-NEXT: [[SCALED5:%.*]] = phi i64 [ [[SCALED]], %[[EXIT]] ], [ poison, %[[LS_GUARD0]] ]
+; CHECK-NEXT: [[ITR_CHK2:%.*]] = icmp sle i64 50, [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK2]], label %[[ENTRY_LS1:.*]], label %[[LS_FINAL_EXIT:.*]]
+; CHECK: [[ENTRY_LS1]]:
+; CHECK-NEXT: br label %[[LOOP_LS1:.*]]
+; CHECK: [[LOOP_LS1]]:
+; CHECK-NEXT: [[I_LS1:%.*]] = phi i64 [ 50, %[[ENTRY_LS1]] ], [ [[I_NEXT_LS1:%.*]], %[[LOOP_LS1]] ]
+; CHECK-NEXT: [[SCALED_LS1:%.*]] = mul i64 [[I_LS1]], 3
+; CHECK-NEXT: [[P_LS1:%.*]] = getelementptr i64, ptr [[A]], i64 [[I_LS1]]
+; CHECK-NEXT: store i64 [[SCALED_LS1]], ptr [[P_LS1]], align 4
+; CHECK-NEXT: [[I_NEXT_LS1]] = add i64 [[I_LS1]], 1
+; CHECK-NEXT: [[ITR_CHK3:%.*]] = icmp sle i64 [[I_NEXT_LS1]], [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK3]], label %[[LOOP_LS1]], label %[[LS_EXIT1:.*]]
+; CHECK: [[LS_EXIT1]]:
+; CHECK-NEXT: br label %[[LS_FINAL_EXIT]]
+; CHECK: [[LS_FINAL_EXIT]]:
+; CHECK-NEXT: [[SCALED4:%.*]] = phi i64 [ [[SCALED_LS1]], %[[LS_EXIT1]] ], [ [[SCALED5]], %[[LS_GUARD1]] ]
+; CHECK-NEXT: ret i64 [[SCALED4]]
+;
+entry:
+ br label %loop
+
+loop:
+ %i = phi i64 [ 0, %entry ], [ %i.next, %loop ]
+ %scaled = mul i64 %i, 3
+ %p = getelementptr i64, ptr %a, i64 %i
+ store i64 %scaled, ptr %p
+ %i.next = add i64 %i, 1
+ %c = icmp slt i64 %i.next, %n
+ br i1 %c, label %loop, label %exit
+
+exit:
+ %scaled.lcssa = phi i64 [ %scaled, %loop ]
+ ret i64 %scaled.lcssa
+}
+
+; A non-induction header PHI whose backedge value is also its initial value. It
+; holds the same value in every iteration, so there is nothing to carry into a
+; later partition.
+
+define i64 @invariant_carried_phi(ptr %a, i64 %n, i64 %m) {
+; CHECK-LABEL: define i64 @invariant_carried_phi(
+; CHECK-SAME: ptr [[A:%.*]], i64 [[N:%.*]], i64 [[M:%.*]]) {
+; CHECK-NEXT: [[LS_GUARD0:.*]]:
+; CHECK-NEXT: [[SMAX:%.*]] = call i64 @llvm.smax.i64(i64 [[N]], i64 1)
+; CHECK-NEXT: [[TMP0:%.*]] = add nsw i64 [[SMAX]], -1
+; CHECK-NEXT: [[SMIN:%.*]] = call i64 @llvm.smin.i64(i64 [[TMP0]], i64 49)
+; CHECK-NEXT: [[ITR_CHK:%.*]] = icmp sle i64 0, [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK]], label %[[ENTRY:.*]], label %[[LS_GUARD1:.*]]
+; CHECK: [[ENTRY]]:
+; CHECK-NEXT: br label %[[LOOP:.*]]
+; CHECK: [[LOOP]]:
+; CHECK-NEXT: [[I:%.*]] = phi i64 [ 0, %[[ENTRY]] ], [ [[I_NEXT:%.*]], %[[LOOP]] ]
+; CHECK-NEXT: [[INV:%.*]] = phi i64 [ [[M]], %[[ENTRY]] ], [ [[M]], %[[LOOP]] ]
+; CHECK-NEXT: [[SUM:%.*]] = phi i64 [ 0, %[[ENTRY]] ], [ [[SUM_NEXT:%.*]], %[[LOOP]] ]
+; CHECK-NEXT: [[P:%.*]] = getelementptr i64, ptr [[A]], i64 [[I]]
+; CHECK-NEXT: [[V:%.*]] = load i64, ptr [[P]], align 4
+; CHECK-NEXT: [[SCALED:%.*]] = mul i64 [[V]], [[INV]]
+; CHECK-NEXT: [[SUM_NEXT]] = add i64 [[SUM]], [[SCALED]]
+; CHECK-NEXT: [[I_NEXT]] = add i64 [[I]], 1
+; CHECK-NEXT: [[ITR_CHK1:%.*]] = icmp sle i64 [[I_NEXT]], [[SMIN]]
+; CHECK-NEXT: br i1 [[ITR_CHK1]], label %[[LOOP]], label %[[EXIT:.*]]
+; CHECK: [[EXIT]]:
+; CHECK-NEXT: br label %[[LS_GUARD1]]
+; CHECK: [[LS_GUARD1]]:
+; CHECK-NEXT: [[SUM_NEXT5:%.*]] = phi i64 [ [[SUM_NEXT]], %[[EXIT]] ], [ 0, %[[LS_GUARD0]] ]
+; CHECK-NEXT: [[ITR_CHK2:%.*]] = icmp sle i64 50, [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK2]], label %[[ENTRY_LS1:.*]], label %[[LS_FINAL_EXIT:.*]]
+; CHECK: [[ENTRY_LS1]]:
+; CHECK-NEXT: br label %[[LOOP_LS1:.*]]
+; CHECK: [[LOOP_LS1]]:
+; CHECK-NEXT: [[I_LS1:%.*]] = phi i64 [ 50, %[[ENTRY_LS1]] ], [ [[I_NEXT_LS1:%.*]], %[[LOOP_LS1]] ]
+; CHECK-NEXT: [[INV_LS1:%.*]] = phi i64 [ [[M]], %[[ENTRY_LS1]] ], [ [[M]], %[[LOOP_LS1]] ]
+; CHECK-NEXT: [[SUM_LS1:%.*]] = phi i64 [ [[SUM_NEXT5]], %[[ENTRY_LS1]] ], [ [[SUM_NEXT_LS1:%.*]], %[[LOOP_LS1]] ]
+; CHECK-NEXT: [[P_LS1:%.*]] = getelementptr i64, ptr [[A]], i64 [[I_LS1]]
+; CHECK-NEXT: [[V_LS1:%.*]] = load i64, ptr [[P_LS1]], align 4
+; CHECK-NEXT: [[SCALED_LS1:%.*]] = mul i64 [[V_LS1]], [[INV_LS1]]
+; CHECK-NEXT: [[SUM_NEXT_LS1]] = add i64 [[SUM_LS1]], [[SCALED_LS1]]
+; CHECK-NEXT: [[I_NEXT_LS1]] = add i64 [[I_LS1]], 1
+; CHECK-NEXT: [[ITR_CHK3:%.*]] = icmp sle i64 [[I_NEXT_LS1]], [[TMP0]]
+; CHECK-NEXT: br i1 [[ITR_CHK3]], label %[[LOOP_LS1]], label %[[LS_EXIT1:.*]]
+; CHECK: [[LS_EXIT1]]:
+; CHECK-NEXT: br label %[[LS_FINAL_EXIT]]
+; CHECK: [[LS_FINAL_EXIT]]:
+; CHECK-NEXT: [[SUM_NEXT4:%.*]] = phi i64 [ [[SUM_NEXT_LS1]], %[[LS_EXIT1]] ], [ [[SUM_NEXT5]], %[[LS_GUARD1]] ]
+; CHECK-NEXT: ret i64 [[SUM_NEXT4]]
+;
+entry:
+ br label %loop
+
+loop:
+ %i = phi i64 [ 0, %entry ], [ %i.next, %loop ]
+ %inv = phi i64 [ %m, %entry ], [ %m, %loop ]
+ %sum = phi i64 [ 0, %entry ], [ %sum.next, %loop ]
+ %p = getelementptr i64, ptr %a, i64 %i
+ %v = load i64, ptr %p
+ %scaled = mul i64 %v, %inv
+ %sum.next = add i64 %sum, %scaled
+ %i.next = add i64 %i, 1
+ %c = icmp slt i64 %i.next, %n
+ br i1 %c, label %loop, label %exit
+
+exit:
+ %sum.lcssa = phi i64 [ %sum.next, %loop ]
+ ret i64 %sum.lcssa
+}
``````````
</details>
https://github.com/llvm/llvm-project/pull/214453
More information about the llvm-commits
mailing list