[llvm] [orc-rt] keeping the header list up to date (PR #213917)

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 05:32:04 PDT 2026


================
@@ -71,7 +71,10 @@ target_include_directories(orc-rt-executor-impl-headers INTERFACE
 
 # Apply RTTI and exceptions compile flags
 target_compile_options(orc-rt-executor PRIVATE ${ORC_RT_COMPILE_FLAGS})
-# TODO: Use common runtimes infrastructure for output and install paths
+# TODO?: Use common runtimes infrastructure for output and install paths
+# jared:
+# We need to decide where we want this to end up
+# For now we will leave it as is until we make that call
----------------
lhames wrote:

Can this be a general "TODO?" with a reference to the original commit? E.g.

```cmake
# TODO? Should we use the common runtimes infrastructure for output and install
#       paths here? (see afb80bddf147c)
```

It looks orthogonal to the header change too -- I'd be inclined to land it as a separate commit. (No need for further review if you do that: you can just go ahead and land it)

https://github.com/llvm/llvm-project/pull/213917


More information about the llvm-commits mailing list