[compiler-rt] [sanitizer-common][rtsan] Mark unsupported tests (PR #213404)

Chris Apple via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 07:39:11 PDT 2026


cjappl wrote:

> > > This LGTM, but let's wait for feedback from Vitaly and Florian before merging
> > 
> > 
> > Sounds good. The main feedback I want for this is the OVERALL feedback from that other review, that is "should rtsan be a part of the sanitizer common tests?"
> > My opinion is yes, it gives us better coverage and makes us more conformant with standard expectations. It pointed out a couple bugs that we have had in there for years, and it may have made our life easier implementing some of the standard stuff originally. I also believe rtsan to be the only sanitizer not in this group right now.
> > The downside is just more runtime, adding another sanitizer means more test time for any CI using this suite.
> 
> What is fraction % of tests you had to mark UNSUPPORTED?

@vitalybuka 

Darwin:
New tests that run and pass: 249
UNSUPPORTED: 26
Total: 275
UNSUPPORTED percentage: 9.5%

Linux is about the same, few additional unsupported:
New tests that run and pass: 249
UNSUPPORTED: 40
Total: 289
UNSUPPORTED percentage 13.8%

Again, some of these UNSUPPORTED are temporary, and we'll go back through and clean them up (or at least discuss suport) so I expect this percentage to go down over time

https://github.com/llvm/llvm-project/pull/213404


More information about the llvm-commits mailing list