[llvm] [LV] Make greater use of ScalarEvolution in addDiffRuntimeChecks (PR #213668)

[Graham Hunter via llvm-commits]

================
@@ -2319,6 +2313,7 @@ Value *llvm::addDiffRuntimeChecks(
 
     // Use (Diff - 1) <u (Threshold - 1), equivalent to 0 < Diff <u Threshold,
     // to exclude Diff == 0 (equal pointers are safe).
+    Value *One = ConstantInt::get(Ty, 1);
----------------
huntergr-arm wrote:

nit: 'One' is only used in the line below, not sure if it's worth creating the local for that?

https://github.com/llvm/llvm-project/pull/213668