[llvm] f7213d8 - [MemorySSA] Clarify `getClobberingMemoryAccess(MA, Loc)` overload does not accept MemoryUse (NFC) (#212512)

via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 2 23:57:22 PDT 2026


Author: Antonio Frighetto
Date: 2026-08-03T08:57:16+02:00
New Revision: f7213d839614c3103f4be28a1459e7f12c44dc77

URL: https://github.com/llvm/llvm-project/commit/f7213d839614c3103f4be28a1459e7f12c44dc77
DIFF: https://github.com/llvm/llvm-project/commit/f7213d839614c3103f4be28a1459e7f12c44dc77.diff

LOG: [MemorySSA] Clarify `getClobberingMemoryAccess(MA, Loc)` overload does not accept MemoryUse (NFC) (#212512)

Outdated comment has been updated to match the implementation, which
asserts on MemoryUse.

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/MemorySSA.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/MemorySSA.h b/llvm/include/llvm/Analysis/MemorySSA.h
index b95a8d0a80e9f..14b49648fcc7a 100644
--- a/llvm/include/llvm/Analysis/MemorySSA.h
+++ b/llvm/include/llvm/Analysis/MemorySSA.h
@@ -1050,11 +1050,11 @@ class MemorySSAWalker {
   ///
   /// This version of the function is mainly used to disambiguate phi translated
   /// pointers, where the value of a pointer may have changed from the initial
-  /// memory access. Note that this expects to be handed either a MemoryUse,
-  /// or an already potentially clobbering access. Unlike the above API, if
-  /// given a MemoryDef that clobbers the pointer as the starting access, it
-  /// will return that MemoryDef, whereas the above would return the clobber
-  /// starting from the use side of  the memory def.
+  /// memory access. Note that this expects to be handed a potentially
+  /// clobbering access (either a MemoryDef or a MemoryPhi). Unlike the above
+  /// API, if given a MemoryDef that clobbers the pointer as the starting
+  /// access, it will return that MemoryDef, whereas the above would return the
+  /// clobber starting from the use side of the memory def.
   virtual MemoryAccess *getClobberingMemoryAccess(MemoryAccess *,
                                                   const MemoryLocation &,
                                                   BatchAAResults &AA) = 0;


        


More information about the llvm-commits mailing list