[lld] [NFC][ELF] Avoid need to copy Symbol in replaceWithDefined (PR #210612)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lld` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/21326

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: lang/c/vla/TestVLA.py (860 of 2660)
SKIPPED: lldb-api :: lang/cpp/abi_tag_lookup/TestAbiTagLookup.py (861 of 2660)
XFAIL: lldb-api :: lang/cpp/abi_tag_structors/TestAbiTagStructors.py (862 of 2660)
SKIPPED: lldb-api :: lang/cpp/accelerator-table/TestCPPAccelerator.py (863 of 2660)
PASS: lldb-api :: lang/cpp/alignas_base_class/TestAlignAsBaseClass.py (864 of 2660)
PASS: lldb-api :: lang/cpp/auto/TestCPPAuto.py (865 of 2660)
PASS: lldb-api :: lang/cpp/bitfields/TestCppBitfields.py (866 of 2660)
PASS: lldb-api :: lang/cpp/bool/TestCPPBool.py (867 of 2660)
PASS: lldb-api :: lang/cpp/break-on-initializers/TestBreakOnCPP11Initializers.py (868 of 2660)
TIMEOUT: lldb-api :: functionalities/breakpoint/two_hits_one_actual/TestTwoHitsOneActual.py (869 of 2660)
******************** TEST 'lldb-api :: functionalities/breakpoint/two_hits_one_actual/TestTwoHitsOneActual.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --triple aarch64-pc-windows-msvc --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --lldb-python-dir C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\Lib\site-packages --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --cmake-build-type Release --skip-category=watchpoint --env LLDB_LAUNCH_FLAG_USE_PIPES=1 C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\breakpoint\two_hits_one_actual -p TestTwoHitsOneActual.py
--
Exit Code: 15
Timeout: Reached timeout of 600 seconds


********************
UNSUPPORTED: lldb-api :: lang/cpp/breakpoint_in_member_func_w_non_primitive_params/TestBreakpointInMemberFuncWNonPrimitiveParams.py (870 of 2660)
PASS: lldb-api :: lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py (871 of 2660)
PASS: lldb-api :: lang/cpp/builtin_types/char/TestCharTypes.py (872 of 2660)
PASS: lldb-api :: lang/cpp/builtin_types/int/TestIntTypes.py (873 of 2660)
PASS: lldb-api :: lang/cpp/builtin_types/long_int/TestLongIntTypes.py (874 of 2660)
PASS: lldb-api :: lang/cpp/call-function/TestCallCPPFunction.py (875 of 2660)
PASS: lldb-api :: lang/cpp/chained-calls/TestCppChainedCalls.py (876 of 2660)
PASS: lldb-api :: lang/cpp/char1632_t/TestChar1632T.py (877 of 2660)
PASS: lldb-api :: lang/cpp/char8_t/TestCxxChar8_t.py (878 of 2660)
PASS: lldb-api :: lang/cpp/class-loading-via-member-typedef/TestClassLoadingViaMemberTypedef.py (879 of 2660)
PASS: lldb-api :: lang/cpp/class-template-non-type-parameter-pack/TestClassTemplateNonTypeParameterPack.py (880 of 2660)
PASS: lldb-api :: lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py (881 of 2660)
PASS: lldb-api :: lang/cpp/class-template-parameter-pack/TestTemplatePackArgs.py (882 of 2660)
PASS: lldb-api :: lang/cpp/class-template-type-parameter-pack/TestClassTemplateTypeParameterPack.py (883 of 2660)
PASS: lldb-api :: lang/cpp/class_static/TestStaticVariables.py (884 of 2660)
PASS: lldb-api :: lang/cpp/class_types/TestClassTypes.py (885 of 2660)
PASS: lldb-api :: lang/cpp/class_types/TestClassTypesDisassembly.py (886 of 2660)
PASS: lldb-api :: lang/cpp/complete-type-check/TestCppIsTypeComplete.py (887 of 2660)
PASS: lldb-api :: lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py (888 of 2660)
PASS: lldb-api :: lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py (889 of 2660)
PASS: lldb-api :: lang/cpp/constructors/TestCppConstructors.py (890 of 2660)
PASS: lldb-api :: lang/cpp/const_this/TestConstThis.py (891 of 2660)
PASS: lldb-api :: lang/cpp/covariant-return-types/TestCovariantReturnTypes.py (892 of 2660)
SKIPPED: lldb-api :: lang/cpp/decl-from-submodule/TestDeclFromSubmodule.py (893 of 2660)
PASS: lldb-api :: lang/cpp/default-template-args/TestDefaultTemplateArgs.py (894 of 2660)
PASS: lldb-api :: lang/cpp/dereferencing_references/TestCPPDereferencingReferences.py (895 of 2660)
PASS: lldb-api :: lang/cpp/crtp/TestCppCRTP.py (896 of 2660)
PASS: lldb-api :: lang/cpp/diamond/TestCppDiamond.py (897 of 2660)
PASS: lldb-api :: lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py (898 of 2660)

```

</details>

https://github.com/llvm/llvm-project/pull/210612