[clang] [llvm] [LLVMOffload] Get LastError for bad Kernels (PR #213390)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions inc,cpp,c,h -- offload/languages/cuda/src/cuda_runtime.cpp offload/languages/hip/src/hip_runtime.cpp offload/languages/include/cuda/cuda_runtime.h offload/languages/include/hip/hip_runtime.h offload/languages/include/kernel/DefineLanguageNames.inc offload/languages/include/kernel/LanguageRuntime.h offload/languages/include/kernel/Types.h offload/languages/include/kernel/UndefineLanguageNames.inc offload/languages/kernel/include/LanguageAliases.h offload/languages/kernel/include/LanguageLaunch.h offload/languages/kernel/include/LanguageRegistration.h offload/languages/kernel/include/LanguageUtils.h offload/languages/kernel/include/Registration.h offload/languages/kernel/include/RuntimeAPI.h offload/languages/kernel/include/State.h offload/languages/kernel/src/LanguageCommon.cpp offload/languages/kernel/src/LanguageLaunch.cpp offload/languages/kernel/src/LanguageRegistration.cpp offload/languages/kernel/src/LanguageRuntime.cpp offload/languages/kernel/src/LanguageUtils.cpp offload/languages/kernel/src/RuntimeAPI.cpp offload/languages/kernel/src/State.cpp offload/test/offloading/HIP/kernel_tu.hip.inc clang/include/clang/Driver/CommonArgs.h clang/lib/CodeGen/CGCUDANV.cpp clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/Cuda.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Linux.cpp clang/lib/Headers/__clang_gpu_builtin_vars.h clang/test/CodeGenCUDA/Inputs/cuda.h clang/test/OffloadTools/clang-linker-wrapper/linker-wrapper-image.c clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp llvm/lib/Frontend/Offloading/OffloadWrapper.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/offload/languages/hip/src/hip_runtime.cpp b/offload/languages/hip/src/hip_runtime.cpp
index faa9df1e8..f2291b15f 100644
--- a/offload/languages/hip/src/hip_runtime.cpp
+++ b/offload/languages/hip/src/hip_runtime.cpp
@@ -18,12 +18,12 @@
 
 extern "C" {
 #define HIP_LAUNCH_KERNEL(SUFFIX)                                              \
-  hipError_t hipLaunchKernel##SUFFIX(                                          \
-      const char *KernelID, dim3 GridDim, dim3 BlockDim, void *KernelArgsPtr,  \
-      size_t DynamicSharedMem, void *Stream) {                                 \
+  hipError_t hipLaunchKernel##SUFFIX(const char *KernelID, dim3 GridDim,       \
+                                     dim3 BlockDim, void *KernelArgsPtr,       \
+                                     size_t DynamicSharedMem, void *Stream) {  \
     return LastError = convertResult(__llvmLaunchKernelImpl(                   \
-        KernelID, GridDim, BlockDim, KernelArgsPtr, DynamicSharedMem,          \
-        Stream));                                                              \
+               KernelID, GridDim, BlockDim, KernelArgsPtr, DynamicSharedMem,   \
+               Stream));                                                       \
   }
 
 HIP_LAUNCH_KERNEL()
diff --git a/offload/languages/kernel/src/LanguageUtils.cpp b/offload/languages/kernel/src/LanguageUtils.cpp
index 4433db994..f4fdea178 100644
--- a/offload/languages/kernel/src/LanguageUtils.cpp
+++ b/offload/languages/kernel/src/LanguageUtils.cpp
@@ -78,9 +78,7 @@ Error_t GetLastError() {
   return Error;
 }
 
-Error_t PeekAtLastError() {
-  return LastError;
-}
+Error_t PeekAtLastError() { return LastError; }
 
 static Error_t getQueueFromStream(Stream_t Stream, ol_queue_handle_t *Queue) {
   if (!Stream)

``````````

</details>


https://github.com/llvm/llvm-project/pull/213390