[llvm] [AMDGPU] Do not treat LDSDMA as VALU in several passes (PR #212866)

[Jeffrey Byrnes via llvm-commits]

jrbyrnes wrote:

> > > I also don't really love isVALU having a super specific exception parameter. This should be a distinct predicate method
> > 
> > 
> > I agree, I think `isVALU` is probably too coarse of a check in most of these places. I think a better pattern is to have a separate `isLDSDMA` and if something wants to exclude LDSDMA, they can just do `isVALU && !isLDSDMA`.
> 
> I thought this was the intended migration path? First change most users to pass in "false" (as in this PR) and then make the argument default to false or remove it altogether.

Please see https://github.com/llvm/llvm-project/pull/203548 for more context - this is the intended migration path.

The API is not great , but we have had multiple occasions where we have seen correctness issues / bugs in upstream because isVALU picks up isLDSDMA without users knowledge / code makes it through review. Clearly, it is not realistic to expect users to always remember this behavior from isVALU.

https://github.com/llvm/llvm-project/pull/212866