[llvm] [TableGen] Speed up intrinsic lookups with DenseMap (NFC) (PR #213198)
Manasij Mukherjee via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 31 01:02:15 PDT 2026
https://github.com/manasij7479 updated https://github.com/llvm/llvm-project/pull/213198
>From 3fe3f5cecf0597c4b65c4898ed38b0576b0d194f Mon Sep 17 00:00:00 2001
From: Manasij Mukherjee <manasijm at nvidia.com>
Date: Fri, 31 Jul 2026 04:20:39 +0000
Subject: [PATCH 1/2] [TableGen] Speed up intrinsic lookups with DenseMap
Store in DenseMap, avoids linear lookups.
Speeds up NVPTX -gen-dag-isel and -gen-instr-info by 10%.
RISCV shows similar gains.
Neutral or marginally beneficial for other targets.
---
.../utils/TableGen/Common/CodeGenDAGPatterns.cpp | 4 ++++
llvm/utils/TableGen/Common/CodeGenDAGPatterns.h | 16 ++++++++--------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index eac04afc06cb6..8278f63eb4041 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -3354,6 +3354,10 @@ CodeGenDAGPatterns::CodeGenDAGPatterns(const RecordKeeper &R, bool ExpandHwMode)
: Records(R), Target(R), Intrinsics(R),
LegalVTS(Target.getLegalValueTypes()),
LegalPtrVTS(ComputeLegalPtrTypes()) {
+ IntrinsicIDs.reserve(Intrinsics.size());
+ for (auto [ID, Intrinsic] : enumerate(Intrinsics))
+ IntrinsicIDs.try_emplace(Intrinsic.TheDef, ID);
+
ParseNodeInfo();
ParseNodeTransforms();
ParseComplexPatterns();
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
index 7d93e9ce126d5..6789b2aca9d81 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
@@ -17,6 +17,7 @@
#include "Basic/CodeGenIntrinsics.h"
#include "Basic/SDNodeProperties.h"
#include "CodeGenTarget.h"
+#include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/IntrusiveRefCntPtr.h"
#include "llvm/ADT/MapVector.h"
#include "llvm/ADT/PointerUnion.h"
@@ -1101,6 +1102,7 @@ class CodeGenDAGPatterns {
const RecordKeeper &Records;
CodeGenTarget Target;
CodeGenIntrinsicTable Intrinsics;
+ DenseMap<const Record *, unsigned> IntrinsicIDs;
std::map<const Record *, SDNodeInfo, LessRecordByID> SDNodes;
@@ -1155,10 +1157,9 @@ class CodeGenDAGPatterns {
}
const CodeGenIntrinsic &getIntrinsic(const Record *R) const {
- for (const CodeGenIntrinsic &Intrinsic : Intrinsics)
- if (Intrinsic.TheDef == R)
- return Intrinsic;
- llvm_unreachable("Unknown intrinsic!");
+ auto I = IntrinsicIDs.find(R);
+ assert(I != IntrinsicIDs.end() && "Unknown intrinsic!");
+ return Intrinsics[I->second];
}
const CodeGenIntrinsic &getIntrinsicInfo(unsigned IID) const {
@@ -1168,10 +1169,9 @@ class CodeGenDAGPatterns {
}
unsigned getIntrinsicID(const Record *R) const {
- for (unsigned i = 0, e = Intrinsics.size(); i != e; ++i)
- if (Intrinsics[i].TheDef == R)
- return i;
- llvm_unreachable("Unknown intrinsic!");
+ auto I = IntrinsicIDs.find(R);
+ assert(I != IntrinsicIDs.end() && "Unknown intrinsic!");
+ return I->second;
}
const DAGDefaultOperand &getDefaultOperand(const Record *R) const {
>From bfe5e6e55379e76a34658b80ed135af6243f1373 Mon Sep 17 00:00:00 2001
From: Manasij Mukherjee <manasijm at nvidia.com>
Date: Fri, 31 Jul 2026 08:04:45 +0000
Subject: [PATCH 2/2] Use getIntrinsicID directly
---
llvm/utils/TableGen/Common/CodeGenDAGPatterns.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
index 6789b2aca9d81..1aee697e5d203 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
@@ -1157,9 +1157,7 @@ class CodeGenDAGPatterns {
}
const CodeGenIntrinsic &getIntrinsic(const Record *R) const {
- auto I = IntrinsicIDs.find(R);
- assert(I != IntrinsicIDs.end() && "Unknown intrinsic!");
- return Intrinsics[I->second];
+ return Intrinsics[getIntrinsicID(R)];
}
const CodeGenIntrinsic &getIntrinsicInfo(unsigned IID) const {
More information about the llvm-commits
mailing list