[llvm] [Bazel] Fix Host target's exported headers to include windows (PR #213018)

David Young via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 06:14:49 PDT 2026


https://github.com/youngd007 created https://github.com/llvm/llvm-project/pull/213018

When PR# 201283 added windows os select to the build of the Host target, it missed the exported headers since the CI checks run only linux and mac (and I hadn't gotten to this in my slow slog of windows bazel lldb support).  I found when translating to BUCK and running into this compilation error on windows for buck2 built lldb.  
Still cannot build and claude tells me the exclude is necessary to avoid a duplicate.

claude assisted with bazel rule creation

>From 5a615cc9ba275c67d59ad8912aec5cb0a8e31acc Mon Sep 17 00:00:00 2001
From: David Young <davidayoung at meta.com>
Date: Thu, 30 Jul 2026 06:04:32 -0700
Subject: [PATCH] [Bazel] Fix Host target's exported headers to include windows

---
 utils/bazel/llvm-project-overlay/lldb/BUILD.bazel | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel b/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
index b56fb5933c05c..a4b7a05a9bffd 100644
--- a/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
@@ -648,6 +648,10 @@ cc_library(
             "include/lldb/Host/linux/*.h",
             "include/lldb/Host/posix/*.h",
         ]),
+        "@platforms//os:windows": glob(
+            ["include/lldb/Host/windows/*.h"],
+            exclude = ["include/lldb/Host/windows/ConPTYUtils.h"],
+        ),
     }) + select({
         ":libedit_enabled": ["include/lldb/Host/Editline.h"],
         "//conditions:default": [],



More information about the llvm-commits mailing list