[llvm] fc764a7 - ARM: Mark more generic libgcc functions as available (#210961)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 30 00:55:07 PDT 2026
Author: Matt Arsenault
Date: 2026-07-30T09:55:03+02:00
New Revision: fc764a7c2b12c508c72e04a606dd2d2c815e2d94
URL: https://github.com/llvm/llvm-project/commit/fc764a7c2b12c508c72e04a606dd2d2c815e2d94
DIFF: https://github.com/llvm/llvm-project/commit/fc764a7c2b12c508c72e04a606dd2d2c815e2d94.diff
LOG: ARM: Mark more generic libgcc functions as available (#210961)
Generic libgcc/compiler-rt functions coexist with aeabi variants
(e.g., __divsi3 and __aeabi_idiv) according to my reading of the
build. At least in compiler-rt, some are aliases.
They were previously removed from the available set on AEABI+AAPCS
targets to force selection of the preferred __aeabi_* variants, back when
only one implementation per libcall could be recorded.
Now that multiple implementations can be available per libcall, stop
hiding the generics and select the __aeabi_* variant explicitly as the
preferred implementation. This reduces the number of special cases to
consider for future libcalls info improvements.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
Added:
Modified:
llvm/include/llvm/IR/RuntimeLibcalls.td
llvm/lib/Target/ARM/ARMSubtarget.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index 4b3e3b2ae76ea..74c51391aad2d 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -2637,13 +2637,7 @@ def ARMSystemLibrary
EABIHalfConvertCalls,
GNUEABIHalfConvertCalls,
ARMDoubleToHalfCalls,
-
- LibcallImpls<(add AEABIOverrides),
- RuntimeLibcallAvailability<
- (all_of (any_of (not (any_of IsTargetAEABI, IsTargetGNUAEABI,
- IsTargetMuslAEABI, IsOSFuchsia, IsAndroid)),
- (not IsAAPCS_ABI)),
- (not IsOSWindows))>>,
+ LibcallImpls<(add AEABIOverrides), isNotOSWindows>,
// Use divmod compiler-rt calls for iOS 5.0 and later.
LibcallImpls<(add __divmodsi4, __udivmodsi4),
RuntimeLibcallAvailability<
diff --git a/llvm/lib/Target/ARM/ARMSubtarget.cpp b/llvm/lib/Target/ARM/ARMSubtarget.cpp
index 00ec0b749fb37..57cfd8ec71a97 100644
--- a/llvm/lib/Target/ARM/ARMSubtarget.cpp
+++ b/llvm/lib/Target/ARM/ARMSubtarget.cpp
@@ -197,6 +197,77 @@ void ARMSubtarget::initLibcallLoweringInfo(LibcallLoweringInfo &Info) const {
Info.setLibcallImpl(LC.Op, LC.Impl);
}
}
+
+ static const struct {
+ const RTLIB::Libcall Op;
+ const RTLIB::LibcallImpl Impl;
+ } AEABISelected[] = {
+ // Double-precision arithmetic.
+ {RTLIB::ADD_F64, RTLIB::impl___aeabi_dadd},
+ {RTLIB::DIV_F64, RTLIB::impl___aeabi_ddiv},
+ {RTLIB::MUL_F64, RTLIB::impl___aeabi_dmul},
+ {RTLIB::SUB_F64, RTLIB::impl___aeabi_dsub},
+ // Double-precision comparisons.
+ {RTLIB::OEQ_F64, RTLIB::impl___aeabi_dcmpeq},
+ {RTLIB::OLT_F64, RTLIB::impl___aeabi_dcmplt},
+ {RTLIB::OLE_F64, RTLIB::impl___aeabi_dcmple},
+ {RTLIB::OGE_F64, RTLIB::impl___aeabi_dcmpge},
+ {RTLIB::OGT_F64, RTLIB::impl___aeabi_dcmpgt},
+ {RTLIB::UO_F64, RTLIB::impl___aeabi_dcmpun},
+ // Single-precision arithmetic.
+ {RTLIB::ADD_F32, RTLIB::impl___aeabi_fadd},
+ {RTLIB::DIV_F32, RTLIB::impl___aeabi_fdiv},
+ {RTLIB::MUL_F32, RTLIB::impl___aeabi_fmul},
+ {RTLIB::SUB_F32, RTLIB::impl___aeabi_fsub},
+ // Single-precision comparisons.
+ {RTLIB::OEQ_F32, RTLIB::impl___aeabi_fcmpeq},
+ {RTLIB::OLT_F32, RTLIB::impl___aeabi_fcmplt},
+ {RTLIB::OLE_F32, RTLIB::impl___aeabi_fcmple},
+ {RTLIB::OGE_F32, RTLIB::impl___aeabi_fcmpge},
+ {RTLIB::OGT_F32, RTLIB::impl___aeabi_fcmpgt},
+ {RTLIB::UO_F32, RTLIB::impl___aeabi_fcmpun},
+ // Floating-point to integer conversions.
+ {RTLIB::FPTOSINT_F64_I32, RTLIB::impl___aeabi_d2iz},
+ {RTLIB::FPTOUINT_F64_I32, RTLIB::impl___aeabi_d2uiz},
+ {RTLIB::FPTOSINT_F64_I64, RTLIB::impl___aeabi_d2lz},
+ {RTLIB::FPTOUINT_F64_I64, RTLIB::impl___aeabi_d2ulz},
+ {RTLIB::FPTOSINT_F32_I32, RTLIB::impl___aeabi_f2iz},
+ {RTLIB::FPTOUINT_F32_I32, RTLIB::impl___aeabi_f2uiz},
+ {RTLIB::FPTOSINT_F32_I64, RTLIB::impl___aeabi_f2lz},
+ {RTLIB::FPTOUINT_F32_I64, RTLIB::impl___aeabi_f2ulz},
+ // Integer to floating-point conversions.
+ {RTLIB::SINTTOFP_I32_F64, RTLIB::impl___aeabi_i2d},
+ {RTLIB::UINTTOFP_I32_F64, RTLIB::impl___aeabi_ui2d},
+ {RTLIB::SINTTOFP_I64_F64, RTLIB::impl___aeabi_l2d},
+ {RTLIB::UINTTOFP_I64_F64, RTLIB::impl___aeabi_ul2d},
+ {RTLIB::SINTTOFP_I32_F32, RTLIB::impl___aeabi_i2f},
+ {RTLIB::UINTTOFP_I32_F32, RTLIB::impl___aeabi_ui2f},
+ {RTLIB::SINTTOFP_I64_F32, RTLIB::impl___aeabi_l2f},
+ {RTLIB::UINTTOFP_I64_F32, RTLIB::impl___aeabi_ul2f},
+ // Long long helpers.
+ {RTLIB::MUL_I64, RTLIB::impl___aeabi_lmul},
+ {RTLIB::SHL_I64, RTLIB::impl___aeabi_llsl},
+ {RTLIB::SRL_I64, RTLIB::impl___aeabi_llsr},
+ {RTLIB::SRA_I64, RTLIB::impl___aeabi_lasr},
+ // Integer division.
+ {RTLIB::SDIV_I32, RTLIB::impl___aeabi_idiv},
+ {RTLIB::UDIV_I32, RTLIB::impl___aeabi_uidiv},
+ };
+
+ const RTLIB::RuntimeLibcallsInfo &RTLCI = Info.getRuntimeLibcallsInfo();
+ for (const auto &LC : AEABISelected) {
+ if (RTLCI.isAvailable(LC.Impl))
+ Info.setLibcallImpl(LC.Op, LC.Impl);
+ }
+
+ // AEABI provides an ordered-equal compare (__aeabi_{f,d}cmpeq) but no
+ // not-equal compare. Clear the unordered-not-equal libcall so UNE will lower
+ // as !OEQ using the AEABI compare, rather than emitting the now-available
+ // generic __nesf2/__nedf2.
+ if (RTLCI.isAvailable(RTLIB::impl___aeabi_fcmpeq))
+ Info.setLibcallImpl(RTLIB::UNE_F32, RTLIB::Unsupported);
+ if (RTLCI.isAvailable(RTLIB::impl___aeabi_dcmpeq))
+ Info.setLibcallImpl(RTLIB::UNE_F64, RTLIB::Unsupported);
}
bool ARMSubtarget::isXRaySupported() const {
More information about the llvm-commits
mailing list