[llvm] [llvm-nm][GOFF] Support symbol types and sizes (PR #207119)

[Amy Kwan via llvm-commits]

================
@@ -1013,6 +1014,23 @@ static char getSymbolNMTypeChar(COFFImportFile &Obj) {
   return '?';
 }
 
+static char getSymbolNMTypeChar(GOFFObjectFile &, basic_symbol_iterator I) {
+  GOFFSymbolRef Ref(*I);
+  Expected<SymbolRef::Type> Type = Ref.getSymbolGOFFType();
+  if (!Type) {
+    consumeError(Type.takeError());
+    return '?';
+  }
+  switch (*Type) {
+  case SymbolRef::ST_Data:
+    return 'd';
+  case SymbolRef::ST_Function:
+    return 't';
+  default:
+    return '?';
----------------
amy-kwan wrote:

That's a good point. To my knowledge, all of the current code paths have been implemented in this function, so I've added an `llvm_unreachable`.

https://github.com/llvm/llvm-project/pull/207119