[llvm] [HLSL][DirectX] Lower llvm.dx.load.input and llvm.dx.store.output to DXIL (PR #208871)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 10 20:25:37 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp llvm/lib/Target/DirectX/DXILOpLowering.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp b/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
index f48e95512..85997a3ef 100644
--- a/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
+++ b/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
@@ -1293,11 +1293,14 @@ static bool expandStoreOutput(CallInst *Orig) {
M, Intrinsic::dx_store_output, {ScalarTy});
for (unsigned I = 0; I < NumElems; ++I) {
- Value *Scalar = Builder.CreateExtractElement(Data, ConstantInt::get(Int32Ty, I));
- Value *ColIdx = Builder.CreateAdd(StartColI32, ConstantInt::get(Int32Ty, I));
+ Value *Scalar =
+ Builder.CreateExtractElement(Data, ConstantInt::get(Int32Ty, I));
+ Value *ColIdx =
+ Builder.CreateAdd(StartColI32, ConstantInt::get(Int32Ty, I));
Value *ColI8 = Builder.CreateTrunc(ColIdx, Int8Ty);
- // Args: (outputSigId, rowIndex, colIndex:i32, startCol:i8, unused:i32, value)
- // startCol (arg 3) carries the per-component column used by lowerStoreOutput.
+ // Args: (outputSigId, rowIndex, colIndex:i32, startCol:i8, unused:i32,
+ // value) startCol (arg 3) carries the per-component column used by
+ // lowerStoreOutput.
Builder.CreateCall(ScalarFn,
{OutputSigId, RowIndex, ColIdx, ColI8, Unused, Scalar});
}
@@ -1331,14 +1334,15 @@ static Value *expandLoadInput(CallInst *Orig) {
Value *Vec = UndefValue::get(VT);
for (unsigned I = 0; I < NumElems; ++I) {
- Value *ColIdx = Builder.CreateAdd(StartColI32, ConstantInt::get(Int32Ty, I));
+ Value *ColIdx =
+ Builder.CreateAdd(StartColI32, ConstantInt::get(Int32Ty, I));
Value *ColI8 = Builder.CreateTrunc(ColIdx, Int8Ty);
// Args: (inputSigId, rowIndex, colIndex:i32, startCol:i8, unused:i32)
// colIndex (arg 2) carries the per-component column used by lowerLoadInput.
Value *Scalar = Builder.CreateCall(
ScalarFn, {InputSigId, RowIndex, ColIdx, ColI8, Unused});
- Vec = Builder.CreateInsertElement(Vec, Scalar,
- ConstantInt::get(Int32Ty, I));
+ Vec =
+ Builder.CreateInsertElement(Vec, Scalar, ConstantInt::get(Int32Ty, I));
}
return Vec;
diff --git a/llvm/lib/Target/DirectX/DXILOpLowering.cpp b/llvm/lib/Target/DirectX/DXILOpLowering.cpp
index 3bd40577a..49e64cd92 100644
--- a/llvm/lib/Target/DirectX/DXILOpLowering.cpp
+++ b/llvm/lib/Target/DirectX/DXILOpLowering.cpp
@@ -1024,9 +1024,8 @@ public:
Type *ScalarTy = CI->getType();
SmallVector<Value *, 3> Args{InputSigId, RowIndex, ColI8};
- Expected<CallInst *> OpCall =
- OpBuilder.tryCreateOp(dxil::OpCode::LoadInput, Args, CI->getName(),
- ScalarTy);
+ Expected<CallInst *> OpCall = OpBuilder.tryCreateOp(
+ dxil::OpCode::LoadInput, Args, CI->getName(), ScalarTy);
if (Error E = OpCall.takeError())
return E;
``````````
</details>
https://github.com/llvm/llvm-project/pull/208871
More information about the llvm-commits
mailing list