[llvm] [cmake] Fix VSINSTALLDIR check in FindDIASDK module (PR #208524)

Fri Jul 10 18:02:07 PDT 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `llvm` at step 16 "test-check-lldb-unit".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/17075

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 16 (test-check-lldb-unit) failure: Test just built components: check-lldb-unit completed (failure)
...
33.700 [37/46/249]Performing build step for 'runtimes-aarch64-unknown-linux-gnu'
34.598 [35/44/254]Building CXX object tools\lldb\unittests\Target\CMakeFiles\TargetTests.dir\MemoryTest.cpp.obj
34.958 [34/43/255]No install step for 'runtimes-aarch64-unknown-linux-gnu'
35.084 [33/43/257]Completed 'runtimes-aarch64-unknown-linux-gnu'
35.214 [33/42/258]Building CXX object tools\lldb\unittests\Instruction\CMakeFiles\EmulatorTests.dir\RISCV\TestRISCVEmulator.cpp.obj
35.429 [33/41/259]Building CXX object tools\lldb\unittests\Target\CMakeFiles\TargetTests.dir\RemoteAwarePlatformTest.cpp.obj
36.019 [33/40/260]Linking CXX executable tools\lldb\unittests\ObjectFile\PECOFF\ObjectFilePECOFFTests.exe
36.550 [32/40/261]Building CXX object tools\lldb\unittests\Language\CPlusPlus\CMakeFiles\LanguageCPlusPlusTests.dir\LibStdcppTupleTest.cpp.obj
36.600 [32/39/262]Building CXX object tools\lldb\unittests\Process\CMakeFiles\ProcessTests.dir\ProcessTraceTest.cpp.obj
36.844 [32/38/263]Building CXX object tools\lldb\unittests\SymbolFile\PDB\CMakeFiles\SymbolFilePDBTests.dir\SymbolFilePDBTests.cpp.obj
FAILED: tools/lldb/unittests/SymbolFile/PDB/CMakeFiles/SymbolFilePDBTests.dir/SymbolFilePDBTests.cpp.obj 
ccache C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\cl.exe  /nologo /TP -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\unittests\SymbolFile\PDB -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\SymbolFile\PDB -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\llvm\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\llvm\..\clang\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\..\clang\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\third-party\unittest\googletest\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\third-party\unittest\googlemock\include -external:I"C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\include" -external:W0 -D__OPTIMIZE__ /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4146 -wd4244 -wd4267 -wd4456 -wd4457 -wd4458 -wd4459 -wd4624 -wd4100 -wd4127 -wd4505 -wd4702 -wd4245 -wd4310 -wd4701 -wd4703 -wd4389 -wd4805 -wd4577 -wd4319 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG /EHs-c- /GR- /YuC:/buildbot/as-builder-10/lldb-x-aarch64/build/lib/Support/CMakeFiles/LLVMSupport.dir/cmake_pch.hxx /FpC:/buildbot/as-builder-10/lldb-x-aarch64/build/lib/Support/CMakeFiles/LLVMSupport.dir/./cmake_pch.cxx.pch /FIC:/buildbot/as-builder-10/lldb-x-aarch64/build/lib/Support/CMakeFiles/LLVMSupport.dir/cmake_pch.hxx /showIncludes /Fotools\lldb\unittests\SymbolFile\PDB\CMakeFiles\SymbolFilePDBTests.dir\SymbolFilePDBTests.cpp.obj /Fdtools\lldb\unittests\SymbolFile\PDB\LLVMSupport.pdb /FS -c C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\SymbolFile\PDB\SymbolFilePDBTests.cpp
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\SymbolFile\PDB\SymbolFilePDBTests.cpp(97): error C2678: binary '&&': no operator found which takes a left-hand operand of type 'llvm::StringRef' (or there is no acceptable conversion)
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\SymbolFile\PDB\SymbolFilePDBTests.cpp(97): note: could be 'built-in C++ operator&&(bool, bool)'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\SymbolFile\PDB\SymbolFilePDBTests.cpp(97): note: '&&': cannot convert argument 1 from 'llvm::StringRef' to 'bool'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\SymbolFile\PDB\SymbolFilePDBTests.cpp(97): note: while trying to match the argument list '(llvm::StringRef, llvm::StringRef)'
36.926 [32/37/264]Building CXX object tools\lldb\unittests\Core\CMakeFiles\LLDBCoreTests.dir\MangledTest.cpp.obj
36.978 [32/36/265]Building CXX object tools\lldb\unittests\Expression\CMakeFiles\ExpressionTests.dir\IRMemoryMapTest.cpp.obj
37.671 [32/35/266]Linking CXX executable tools\lldb\unittests\ObjectFile\ELF\ObjectFileELFTests.exe
37.911 [32/34/267]Building CXX object tools\lldb\unittests\Core\CMakeFiles\LLDBCoreTests.dir\Value.cpp.obj
38.013 [32/33/268]Building CXX object tools\lldb\unittests\Symbol\CMakeFiles\SymbolTests.dir\SymtabTest.cpp.obj
38.032 [32/32/269]Building CXX object tools\lldb\unittests\Target\CMakeFiles\TargetTests.dir\ExecutionContextTest.cpp.obj
38.121 [32/31/270]Linking CXX executable tools\lldb\unittests\Process\minidump\LLDBMinidumpTests.exe
38.571 [32/30/271]Building CXX object tools\lldb\unittests\DataFormatter\CMakeFiles\LLDBFormatterTests.dir\FormatterSectionTest.cpp.obj
38.591 [32/29/272]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\SymbolFileDWARFTests.cpp.obj
38.833 [32/28/273]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\DWARF64UnitTest.cpp.obj
39.014 [32/27/274]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\XcodeSDKModuleTests.cpp.obj
39.299 [32/26/275]Building CXX object tools\lldb\unittests\Platform\CMakeFiles\LLDBPlatformTests.dir\PlatformSiginfoTest.cpp.obj
39.340 [32/25/276]Building CXX object tools\lldb\unittests\Target\CMakeFiles\TargetTests.dir\StackFrameRecognizerTest.cpp.obj
39.378 [32/24/277]Linking CXX executable tools\lldb\unittests\UnwindAssembly\x86-but-no-x86-target\UnwindAssemblyX86ButNoX86TargetTests.exe
39.397 [32/23/278]Building CXX object tools\lldb\tools\lldb-test\CMakeFiles\lldb-test.dir\lldb-test.cpp.obj
39.652 [32/22/279]Building CXX object tools\lldb\unittests\Target\CMakeFiles\TargetTests.dir\LocateModuleCallbackTest.cpp.obj
39.844 [32/21/280]Building CXX object tools\lldb\unittests\SymbolFile\NativePDB\CMakeFiles\SymbolFileNativePDBTests.dir\UdtRecordCompleterTests.cpp.obj
40.177 [32/20/281]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\DWARFUnitTest.cpp.obj
40.180 [32/19/282]Building CXX object tools\lldb\unittests\Platform\Android\CMakeFiles\AdbClientTests.dir\PlatformAndroidTest.cpp.obj
40.219 [32/18/283]Building CXX object tools\lldb\unittests\Expression\CMakeFiles\ExpressionTests.dir\ClangExpressionDeclMapTest.cpp.obj
40.280 [32/17/284]Linking CXX executable tools\lldb\unittests\Process\gdb-remote\ProcessGdbRemoteTests.exe
40.289 [32/16/285]Linking CXX executable tools\lldb\unittests\Platform\gdb-server\PlatformGdbRemoteTests.exe
40.884 [32/15/286]Building CXX object tools\lldb\unittests\Thread\CMakeFiles\ThreadTests.dir\ThreadTest.cpp.obj
41.002 [32/14/287]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\DWARFDebugNamesIndexTest.cpp.obj
41.151 [32/13/288]Building CXX object tools\lldb\unittests\Symbol\CMakeFiles\SymbolTests.dir\TestTypeSystemClang.cpp.obj
41.332 [32/12/289]Linking CXX executable tools\lldb\unittests\Callback\LLDBCallbackTests.exe
41.475 [32/11/290]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\DWARFDIETest.cpp.obj
41.660 [32/10/291]Building CXX object tools\lldb\unittests\SymbolFile\DWARF\CMakeFiles\SymbolFileDWARFTests.dir\DWARFIndexCachingTest.cpp.obj
41.978 [32/9/292]Building CXX object tools\lldb\unittests\ValueObject\CMakeFiles\LLDBValueObjectTests.dir\DumpValueObjectOptionsTests.cpp.obj
42.038 [32/8/293]Building CXX object tools\lldb\unittests\TestingSupport\Symbol\CMakeFiles\lldbSymbolHelpers.dir\YAMLModuleTester.cpp.obj
42.179 [32/7/294]Building CXX object tools\lldb\unittests\Expression\CMakeFiles\ExpressionTests.dir\DWARFExpressionTest.cpp.obj
42.923 [32/6/295]Linking CXX executable tools\lldb\unittests\Interpreter\InterpreterTests.exe
43.703 [32/5/296]Building CXX object tools\lldb\unittests\Symbol\CMakeFiles\SymbolTests.dir\TestClangASTImporter.cpp.obj

```

</details>

https://github.com/llvm/llvm-project/pull/208524