[llvm] 3595454 - MC: Start some error messages with a lowercase (#208570)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 00:49:19 PDT 2026


Author: Matt Arsenault
Date: 2026-07-10T07:49:14Z
New Revision: 3595454d79c9bc4253f70961e32516e23805b982

URL: https://github.com/llvm/llvm-project/commit/3595454d79c9bc4253f70961e32516e23805b982
DIFF: https://github.com/llvm/llvm-project/commit/3595454d79c9bc4253f70961e32516e23805b982.diff

LOG: MC: Start some error messages with a lowercase (#208570)

Also add a missing test for one of them.

Added: 
    llvm/test/MC/ELF/size-expression-must-be-absolute.s

Modified: 
    llvm/lib/MC/ELFObjectWriter.cpp
    llvm/lib/MC/MachObjectWriter.cpp
    llvm/test/MC/X86/check-end-of-data-region.s

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp
index f47bfdee42c62..3af4851d39d94 100644
--- a/llvm/lib/MC/ELFObjectWriter.cpp
+++ b/llvm/lib/MC/ELFObjectWriter.cpp
@@ -457,7 +457,7 @@ void ELFWriter::writeSymbol(SymbolTableWriter &Writer, uint32_t StringIndex,
   if (ESize) {
     int64_t Res;
     if (!ESize->evaluateKnownAbsolute(Res, Asm))
-      report_fatal_error("Size expression must be absolute.");
+      report_fatal_error("size expression must be absolute");
     Size = Res;
   }
 

diff  --git a/llvm/lib/MC/MachObjectWriter.cpp b/llvm/lib/MC/MachObjectWriter.cpp
index b42155d18bf0a..e274d886c22d8 100644
--- a/llvm/lib/MC/MachObjectWriter.cpp
+++ b/llvm/lib/MC/MachObjectWriter.cpp
@@ -1060,7 +1060,7 @@ uint64_t MachObjectWriter::writeObject() {
     if (Data.End)
       End = getSymbolAddress(*Data.End);
     else
-      report_fatal_error("Data region not terminated");
+      report_fatal_error("data region not terminated");
 
     LLVM_DEBUG(dbgs() << "data in code region-- kind: " << Data.Kind
                       << "  start: " << Start << "(" << Data.Start->getName()

diff  --git a/llvm/test/MC/ELF/size-expression-must-be-absolute.s b/llvm/test/MC/ELF/size-expression-must-be-absolute.s
new file mode 100644
index 0000000000000..769df52d9bb44
--- /dev/null
+++ b/llvm/test/MC/ELF/size-expression-must-be-absolute.s
@@ -0,0 +1,6 @@
+// RUN: not --crash llvm-mc -triple=x86_64 -filetype=obj -o /dev/null %s 2>&1 | FileCheck %s
+
+a: b:
+.size a, b
+
+// CHECK: LLVM ERROR: size expression must be absolute

diff  --git a/llvm/test/MC/X86/check-end-of-data-region.s b/llvm/test/MC/X86/check-end-of-data-region.s
index 50f5dab73d352..f0cf67bf7ed32 100644
--- a/llvm/test/MC/X86/check-end-of-data-region.s
+++ b/llvm/test/MC/X86/check-end-of-data-region.s
@@ -5,4 +5,4 @@
 foo:
      .long 0
 
-// CHECK-ERROR: LLVM ERROR: Data region not terminated
+// CHECK-ERROR: LLVM ERROR: data region not terminated


        


More information about the llvm-commits mailing list