[llvm] [NFC][SPIRV] Remove dead helper `addStringImm(const StringRef &Str, IRBuilder<> &B, std::vector<Value *> &Args)` (PR #207923)

Juan Manuel Martinez CaamaƱo via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 01:16:21 PDT 2026


https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/207923

The helper was unused.

>From 36e81b8bcc610862d676669fc9a25417f15bb82f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?=
 <jmartinezcaamao at gmail.com>
Date: Tue, 7 Jul 2026 10:13:29 +0200
Subject: [PATCH] [NFC][SPIRV] Remove dead helper

---
 llvm/lib/Target/SPIRV/SPIRVUtils.cpp | 9 ---------
 llvm/lib/Target/SPIRV/SPIRVUtils.h   | 2 --
 2 files changed, 11 deletions(-)

diff --git a/llvm/lib/Target/SPIRV/SPIRVUtils.cpp b/llvm/lib/Target/SPIRV/SPIRVUtils.cpp
index ecb095b5f09cf..cbb8fb1deeb29 100644
--- a/llvm/lib/Target/SPIRV/SPIRVUtils.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVUtils.cpp
@@ -187,15 +187,6 @@ void addStringImm(const StringRef &Str, MachineInstrBuilder &MIB) {
   }
 }
 
-void addStringImm(const StringRef &Str, IRBuilder<> &B,
-                  std::vector<Value *> &Args) {
-  const size_t PaddedLen = getPaddedLen(Str);
-  for (unsigned i = 0; i < PaddedLen; i += 4) {
-    // Add a vector element for the 32-bits of chars or padding.
-    Args.push_back(B.getInt32(convertCharsToWord(Str, i)));
-  }
-}
-
 std::string getStringImm(const MachineInstr &MI, unsigned StartIndex) {
   return getSPIRVStringOperand(MI, StartIndex);
 }
diff --git a/llvm/lib/Target/SPIRV/SPIRVUtils.h b/llvm/lib/Target/SPIRV/SPIRVUtils.h
index b67287c628a33..c9f25d733d983 100644
--- a/llvm/lib/Target/SPIRV/SPIRVUtils.h
+++ b/llvm/lib/Target/SPIRV/SPIRVUtils.h
@@ -177,8 +177,6 @@ StringRef getOriginalAsmConstraints(const CallBase &CB);
 // little-endian words.
 void addStringImm(const StringRef &Str, MCInst &Inst);
 void addStringImm(const StringRef &Str, MachineInstrBuilder &MIB);
-void addStringImm(const StringRef &Str, IRBuilder<> &B,
-                  std::vector<Value *> &Args);
 
 // Read the series of integer operands back as a null-terminated string using
 // the reverse of the logic in addStringImm.



More information about the llvm-commits mailing list