[llvm] Require GraphHasNodeNumbers in llvm::LoopInfoBase; drop the DenseMap fallback (PR #207905)

Tue Jul 7 00:11:51 PDT 2026

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 134215 tests passed
* 3086 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/CFGLoopInfo.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/CFGLoopInfo.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\lib\Analysis -IC:\_work\llvm-project\llvm-project\mlir\lib\Analysis -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\lib\Analysis\CMakeFiles\obj.MLIRAnalysis.dir\CFGLoopInfo.cpp.obj /Fdtools\mlir\lib\Analysis\CMakeFiles\obj.MLIRAnalysis.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Analysis\CFGLoopInfo.cpp
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\Analysis\CFGLoopInfo.cpp:9:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/Analysis/CFGLoopInfo.h:20:
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/GenericLoopInfo.h(527,17): error: static assertion failed due to requirement 'GraphHasNodeNumbers<const mlir::Block *>': LoopInfo requires GraphTraits<BlockT *>::getNumber (see GraphHasNodeNumbers)
527 |   static_assert(GraphHasNodeNumbers<const BlockT *>,
|                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\mlir\include\mlir/Analysis/CFGLoopInfo.h(30,23): note: in instantiation of template class 'llvm::LoopInfoBase<mlir::Block, mlir::CFGLoop>' requested here
30 | extern template class LoopInfoBase<mlir::Block, mlir::CFGLoop>;
|                       ^
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\Analysis\CFGLoopInfo.cpp:10:
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/GenericLoopInfoImpl.h(287,23): error: no viable overloaded operator[] for type 'LoopInfoBase<mlir::Block, mlir::CFGLoop>'
287 |     auto SameHeader = LIB[getHeader()];
|                       ^~~ ~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\mlir\lib\Analysis\CFGLoopInfo.cpp(14,22): note: in instantiation of member function 'llvm::LoopBase<mlir::Block, mlir::CFGLoop>::addBasicBlockToLoop' requested here
14 | template class llvm::LoopBase<mlir::Block, mlir::CFGLoop>;
|                      ^
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\Analysis\CFGLoopInfo.cpp:10:
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/GenericLoopInfoImpl.h(293,11): error: no viable overloaded operator[] for type 'LoopInfoBase<mlir::Block, mlir::CFGLoop>'
293 |   assert(!LIB[NewBB] && "BasicBlock already in the loop!");
|           ^~~ ~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/GenericLoopInfoImpl.h(298,7): error: no member named 'changeLoopFor' in 'llvm::LoopInfoBase<mlir::Block, mlir::CFGLoop>'
298 |   LIB.changeLoopFor(NewBB, L);
|   ~~~ ^
C:\_work\llvm-project\llvm-project\mlir\lib\Analysis\CFGLoopInfo.cpp(24,3): error: use of undeclared identifier 'analyze'
24 |   analyze(domTree);
|   ^~~~~~~
5 errors generated.
```
</details>
<details>
<summary>[code=1] tools/mlir/test/lib/Analysis/CMakeFiles/MLIRTestAnalysis.dir/TestCFGLoopInfo.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/test/lib/Analysis/CMakeFiles/MLIRTestAnalysis.dir/TestCFGLoopInfo.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DMLIR_INCLUDE_TESTS -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\test\lib\Analysis -IC:\_work\llvm-project\llvm-project\mlir\test\lib\Analysis -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\mlir\test\lib\Analysis\..\Dialect\Test -IC:\_work\llvm-project\llvm-project\build\tools\mlir\test\lib\Analysis\..\Dialect\Test /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\test\lib\Analysis\CMakeFiles\MLIRTestAnalysis.dir\TestCFGLoopInfo.cpp.obj /Fdtools\mlir\test\lib\Analysis\CMakeFiles\MLIRTestAnalysis.dir\MLIRTestAnalysis.pdb -c -- C:\_work\llvm-project\llvm-project\mlir\test\lib\Analysis\TestCFGLoopInfo.cpp
In file included from C:\_work\llvm-project\llvm-project\mlir\test\lib\Analysis\TestCFGLoopInfo.cpp:13:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/Analysis/CFGLoopInfo.h:20:
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/GenericLoopInfo.h(527,17): error: static assertion failed due to requirement 'GraphHasNodeNumbers<const mlir::Block *>': LoopInfo requires GraphTraits<BlockT *>::getNumber (see GraphHasNodeNumbers)
527 |   static_assert(GraphHasNodeNumbers<const BlockT *>,
|                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\mlir\include\mlir/Analysis/CFGLoopInfo.h(30,23): note: in instantiation of template class 'llvm::LoopInfoBase<mlir::Block, mlir::CFGLoop>' requested here
30 | extern template class LoopInfoBase<mlir::Block, mlir::CFGLoop>;
|                       ^
C:\_work\llvm-project\llvm-project\mlir\test\lib\Analysis\TestCFGLoopInfo.cpp(65,16): error: no member named 'getTopLevelLoops' in 'mlir::CFGLoopInfo'
65 |   if (loopInfo.getTopLevelLoops().empty())
|       ~~~~~~~~ ^
C:\_work\llvm-project\llvm-project\mlir\test\lib\Analysis\TestCFGLoopInfo.cpp(68,14): error: no member named 'print' in 'mlir::CFGLoopInfo'
68 |     loopInfo.print(llvm::errs());
|     ~~~~~~~~ ^
3 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/207905