[llvm] IR: Use switch in getFloatingPointType (PR #207750)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 08:04:34 PDT 2026


https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/207750

None

>From 0d87d2486d87d9b66923631f7df33f92a1d3523b Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Mon, 6 Jul 2026 13:54:34 +0200
Subject: [PATCH] IR: Use switch in getFloatingPointType

---
 llvm/lib/IR/Type.cpp | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index d5f4671487acb..8c108a4d1f275 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -123,24 +123,24 @@ bool Type::isScalableTargetExtTy() const {
 }
 
 Type *Type::getFloatingPointTy(LLVMContext &C, const fltSemantics &S) {
-  Type *Ty;
-  if (&S == &APFloat::IEEEhalf())
-    Ty = Type::getHalfTy(C);
-  else if (&S == &APFloat::BFloat())
-    Ty = Type::getBFloatTy(C);
-  else if (&S == &APFloat::IEEEsingle())
-    Ty = Type::getFloatTy(C);
-  else if (&S == &APFloat::IEEEdouble())
-    Ty = Type::getDoubleTy(C);
-  else if (&S == &APFloat::x87DoubleExtended())
-    Ty = Type::getX86_FP80Ty(C);
-  else if (&S == &APFloat::IEEEquad())
-    Ty = Type::getFP128Ty(C);
-  else {
-    assert(&S == &APFloat::PPCDoubleDouble() && "Unknown FP format");
-    Ty = Type::getPPC_FP128Ty(C);
+  switch (llvm::APFloat::SemanticsToEnum(S)) {
+  case llvm::APFloat::S_IEEEhalf:
+    return llvm::Type::getHalfTy(C);
+  case llvm::APFloat::S_BFloat:
+    return llvm::Type::getBFloatTy(C);
+  case llvm::APFloat::S_IEEEsingle:
+    return llvm::Type::getFloatTy(C);
+  case llvm::APFloat::S_IEEEdouble:
+    return llvm::Type::getDoubleTy(C);
+  case llvm::APFloat::S_IEEEquad:
+    return llvm::Type::getFP128Ty(C);
+  case llvm::APFloat::S_PPCDoubleDouble:
+    return llvm::Type::getPPC_FP128Ty(C);
+  case llvm::APFloat::S_x87DoubleExtended:
+    return llvm::Type::getX86_FP80Ty(C);
+  default:
+    llvm_unreachable("unhandled float format");
   }
-  return Ty;
 }
 
 bool Type::isRISCVVectorTupleTy() const {



More information about the llvm-commits mailing list