[llvm] [AMDGPU][NPM] Complete AsmPrinter support (PR #203509)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 5 11:34:44 PDT 2026


================
@@ -2406,15 +2415,16 @@ void AMDGPUCodeGenPassBuilder::addILPOpts(PassManagerWrapper &PMW) const {
 
 void AMDGPUCodeGenPassBuilder::addAsmPrinterBegin(
     PassManagerWrapper &PMW) const {
-  // TODO: Add AsmPrinterBegin
+  addModulePass(AMDGPUAsmPrinterBeginPass(), PMW,
+                /*Force=*/true);
 }
 
 void AMDGPUCodeGenPassBuilder::addAsmPrinter(PassManagerWrapper &PMW) const {
-  // TODO: Add AsmPrinter.
+  addMachineFunctionPass(AMDGPUAsmPrinterPass(), PMW);
 }
 
 void AMDGPUCodeGenPassBuilder::addAsmPrinterEnd(PassManagerWrapper &PMW) const {
-  // TODO: Add AsmPrinterEnd
+  addModulePass(AMDGPUAsmPrinterEndPass(), PMW, /*Force=*/true);
----------------
boomanaiden154 wrote:

I don't think we want to force `AsmPrinterEnd`. Otherwise we add it if we run `llc` with `-stop-after`/`-stop-before` in the middle of the pipeline.

I still need to fix this for one or two other targets.

https://github.com/llvm/llvm-project/pull/203509


More information about the llvm-commits mailing list