[llvm] [InstCombine] Recognize abs through positive-K nsw multiply. (PR #207539)

via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 4 13:50:14 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Analysis/ValueTracking.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index f242fdeef..772cccdbd 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -9012,10 +9012,9 @@ static SelectPatternResult matchSelectPattern(CmpInst::Predicate Pred,
         m_CombineOr(m_Specific(CmpLHS), m_SExt(m_Specific(CmpLHS)));
     auto MaybeSExtCmpLHS = m_CombineOr(
         CmpLHSOrSExt,
-        m_CombineOr(
-            m_CombineOr(m_NSWMul(CmpLHSOrSExt, m_StrictlyPositive()),
-                        m_NSWMul(m_StrictlyPositive(), CmpLHSOrSExt)),
-            m_NSWShl(CmpLHSOrSExt, m_NonNegative())));
+        m_CombineOr(m_CombineOr(m_NSWMul(CmpLHSOrSExt, m_StrictlyPositive()),
+                                m_NSWMul(m_StrictlyPositive(), CmpLHSOrSExt)),
+                    m_NSWShl(CmpLHSOrSExt, m_NonNegative())));
     auto ZeroOrAllOnes = m_CombineOr(m_ZeroInt(), m_AllOnes());
     auto ZeroOrOne = m_CombineOr(m_ZeroInt(), m_One());
     if (match(TrueVal, MaybeSExtCmpLHS)) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/207539


More information about the llvm-commits mailing list