[llvm] [BOLT] Prevent .rela.plt reordering (PR #207412)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,c,cpp -- bolt/test/runtime/X86/rela-plt-order.c bolt/include/bolt/Rewrite/RewriteInstance.h bolt/lib/Rewrite/RewriteInstance.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp
index 359074ab0..9ac5b58a2 100644
--- a/bolt/lib/Rewrite/RewriteInstance.cpp
+++ b/bolt/lib/Rewrite/RewriteInstance.cpp
@@ -5891,12 +5891,11 @@ RewriteInstance::patchELFAllocatableRelaSections(ELFObjectFile<ELFT> *File) {
 
   {
     for (const uint64_t Address : DynamicRelocationOrder) {
-      ErrorOr<BinarySection &> SectionOrError = BC->getSectionForAddress(Address);
+      ErrorOr<BinarySection &> SectionOrError =
+          BC->getSectionForAddress(Address);
       if (!SectionOrError) {
-        BC->errs()
-          << "Cannot find section for dynamic relocation at 0x"
-          << Twine::utohexstr(Address)
-          << "\n";
+        BC->errs() << "Cannot find section for dynamic relocation at 0x"
+                   << Twine::utohexstr(Address) << "\n";
         exit(1);
       }
 
@@ -5906,7 +5905,8 @@ RewriteInstance::patchELFAllocatableRelaSections(ELFObjectFile<ELFT> *File) {
       if (!SectionAddress)
         SectionAddress = SectionInputAddress;
 
-      const Relocation &Rel = *Section.getDynamicRelocationAt(Address - SectionInputAddress);
+      const Relocation &Rel =
+          *Section.getDynamicRelocationAt(Address - SectionInputAddress);
 
       {
         const bool IsRelative = Rel.isRelative();

``````````

</details>


https://github.com/llvm/llvm-project/pull/207412