[llvm] [VPlan] Introduce VPConstant VPIRValue (NFC) (PR #207387)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 3 05:57:58 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Ramkumar Ramachandra (artagnon)
<details>
<summary>Changes</summary>
There a gap in the VPIRValue class hierarchy, where constant live-ins are absent, when this is in fact a very common case. The motivation of introducing this new class is to refine optimizations to account for the fact that live-ins need broadcast.
---
Full diff: https://github.com/llvm/llvm-project/pull/207387.diff
2 Files Affected:
- (modified) llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp (+3-4)
- (modified) llvm/lib/Transforms/Vectorize/VPlanValue.h (+19-5)
``````````diff
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index 3e6761a161ad0..0e061e096e035 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -1992,8 +1992,8 @@ static void narrowToSingleScalarRecipes(VPlan &Plan) {
return false;
// Non-constant live-ins require broadcasts, while constants do not
// need explicit broadcasts.
- auto *IRV = dyn_cast<VPIRValue>(Op);
- bool LiveInNeedsBroadcast = IRV && !isa<Constant>(IRV->getValue());
+ bool LiveInNeedsBroadcast =
+ isa<VPIRValue>(Op) && !isa<VPConstant>(Op);
auto *OpR = dyn_cast<VPReplicateRecipe>(Op);
return LiveInNeedsBroadcast || (OpR && OpR->isSingleScalar());
}))
@@ -5103,8 +5103,7 @@ void VPlanTransforms::materializeBroadcasts(VPlan &Plan) {
auto *VectorPreheader = Plan.getVectorPreheader();
for (VPValue *VPV : VPValues) {
- if (vputils::onlyScalarValuesUsed(VPV) ||
- (isa<VPIRValue>(VPV) && isa<Constant>(VPV->getLiveInIRValue())))
+ if (vputils::onlyScalarValuesUsed(VPV) || isa<VPConstant>(VPV))
continue;
// Add explicit broadcast at the insert point that dominates all users.
diff --git a/llvm/lib/Transforms/Vectorize/VPlanValue.h b/llvm/lib/Transforms/Vectorize/VPlanValue.h
index a7aa0523ad5d0..9af4de724a06f 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanValue.h
+++ b/llvm/lib/Transforms/Vectorize/VPlanValue.h
@@ -260,13 +260,27 @@ struct VPIRValue : public VPValue {
}
};
-/// An overlay on VPIRValue for VPValues that wrap a ConstantInt. Provides
-/// convenient accessors for the underlying constant.
-struct VPConstantInt : public VPIRValue {
- VPConstantInt(ConstantInt *CI) : VPIRValue(CI) {}
+/// An overlay on VPIRValue for VPValues that wrap a Constant. May be an
+/// integer, floating-point, or even a vector constant.
+struct VPConstant : public VPIRValue {
+ VPConstant(Constant *C) : VPIRValue(C) {}
static bool classof(const VPValue *V) {
- return isa<VPIRValue>(V) && isa<ConstantInt>(V->getUnderlyingValue());
+ auto *IRV = dyn_cast<VPIRValue>(V);
+ return IRV && isa<Constant>(IRV->getValue());
+ }
+
+ const Constant *getConstant() const { return cast<Constant>(getValue()); }
+};
+
+/// An overlay on VPConstant for VPValues that wrap a ConstantInt. Provides
+/// convenient accessors for the underlying APInt.
+struct VPConstantInt : public VPConstant {
+ VPConstantInt(ConstantInt *CI) : VPConstant(CI) {}
+
+ static bool classof(const VPValue *V) {
+ auto *VPC = dyn_cast<VPConstant>(V);
+ return VPC && isa<ConstantInt>(VPC->getConstant());
}
bool isOne() const { return getAPInt().isOne(); }
``````````
</details>
https://github.com/llvm/llvm-project/pull/207387
More information about the llvm-commits
mailing list