[llvm] [BOLT] Add pre-parsed perf script support (PR #163785)

[via llvm-commits]

DmitriiMartynov wrote:

Hi @kaadam  !
I faced test failures when building for X86 only (-DLLVM_TARGETS_TO_BUILD="X86").
All failures start from the newly added file bolt/unittests/Profile/PerfScripts.cpp.
Please check the logs:
<pre>
Note: This is test shard 16 of 20.
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from PerfScriptTestHelper
[ RUN      ] PerfScriptTestHelper.CheckMissingEventAndSizeContent
Failure value returned from cantFail wrapped call
<b>BOLT-ERROR: invalid target 'aarch64'.</b>
UNREACHABLE executed at /home/user/repos/llvm-project/llvm/include/llvm/Support/Error.h:810!
 #0 0x000056871038798c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x9a198c)
 #1 0x0000568710384aa4 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #2 0x000071f865245cb0 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x45cb0)
 #3 0x000071f8652a648c __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
 #4 0x000071f8652a648c __pthread_kill_internal ./nptl/pthread_kill.c:89:10
 #5 0x000071f8652a648c pthread_kill ./nptl/pthread_kill.c:100:10
 #6 0x000071f865245b7e raise ./signal/../sysdeps/posix/raise.c:27:6
 #7 0x000071f8652288ec internal_signal_block_all ./stdlib/../sysdeps/unix/sysv/linux/internal-signals.h:81:3
 #8 0x000071f8652288ec __abort_lock_wrlock ./stdlib/abort.c:62:3
 #9 0x000071f8652288ec abort ./stdlib/abort.c:85:3
#10 0x00005687103198ee (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x9338ee)
#11 0x000056870fcd0e49 std::unique_ptr<llvm::bolt::BinaryContext, std::default_delete<llvm::bolt::BinaryContext>> llvm::cantFail<std::unique_ptr<llvm::bolt::BinaryContext, std::default_delete<llvm::bolt::BinaryContext>>>(llvm::Expected<std::unique_ptr<llvm::bolt::BinaryContext, std::default_delete<llvm::bolt::BinaryContext>>>, char const*) /home/user/repos/llvm-project/llvm/include/llvm/Support/Error.h:812:1
<b>#12 0x000056870fcda2b7 llvm::bolt::PerfScriptTestHelper::initializeBOLT() /home/user/repos/llvm-project/bolt/unittests/Profile/PerfScripts.cpp:66:70</b>
#13 0x000056870fcd9f42 llvm::bolt::PerfScriptTestHelper::SetUp() /home/user/repos/llvm-project/bolt/unittests/Profile/PerfScripts.cpp:39:3
#14 0x00005687103a2687 testing::Test::Run() (.part.0) gtest-all.cc:0:0
#15 0x00005687103ae4c2 testing::TestInfo::Run() (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x9c84c2)
#16 0x00005687103bad1c testing::TestSuite::Run() (.part.0) gtest-all.cc:0:0
#17 0x00005687103bb771 testing::internal::UnitTestImpl::RunAllTests() (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x9d5771)
#18 0x00005687103bbebe testing::UnitTest::Run() (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x9d5ebe)
#19 0x000056870fc5f1b7 main (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x2791b7)
#20 0x000071f86522a601 __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:83:3
#21 0x000071f86522a718 call_init ./csu/../csu/libc-start.c:128:20
#22 0x000071f86522a718 __libc_start_main ./csu/../csu/libc-start.c:347:5
#23 0x000056870fcc6bc5 _start (/home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests+0x2e0bc5)

--
exit: -6
--
shard JSON output does not exist: /home/user/repos/llvm-project/build/tools/bolt/unittests/Profile/./ProfileTests-BOLT-Unit-389716-15-20.json
********************
********************
Failed Tests (7):
  BOLT-Unit :: Profile/./ProfileTests/13/20
  BOLT-Unit :: Profile/./ProfileTests/14/20
  BOLT-Unit :: Profile/./ProfileTests/15/20
  BOLT-Unit :: Profile/./ProfileTests/16/20
  BOLT-Unit :: Profile/./ProfileTests/17/20
  BOLT-Unit :: Profile/./ProfileTests/18/20
  BOLT-Unit :: Profile/./ProfileTests/19/20
</pre>

https://github.com/llvm/llvm-project/pull/163785