[llvm] 981651d - [MSP430] Port AsmPrinter to NewPM

via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 21:53:36 PDT 2026


Author: Aiden Grossman
Date: 2026-07-02T04:53:33Z
New Revision: 981651d01e42081c4939202f072b8c52523b859d

URL: https://github.com/llvm/llvm-project/commit/981651d01e42081c4939202f072b8c52523b859d
DIFF: https://github.com/llvm/llvm-project/commit/981651d01e42081c4939202f072b8c52523b859d.diff

LOG: [MSP430] Port AsmPrinter to NewPM

Similar to Lanai (f3b58ad68cca340bdd12e3fd289048e5ecf0ad8d) and X86. Use
a separate header to be consistent with the other backends.

Reviewers: asl

Pull Request: https://github.com/llvm/llvm-project/pull/206822

Added: 
    llvm/lib/Target/MSP430/MSP430AsmPrinter.h

Modified: 
    llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp
    llvm/lib/Target/MSP430/MSP430CodeGenPassBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp b/llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp
index 44eea8149c594..13feb873166fe 100644
--- a/llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp
+++ b/llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp
@@ -11,16 +11,22 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "MSP430AsmPrinter.h"
 #include "MCTargetDesc/MSP430InstPrinter.h"
 #include "MSP430MCInstLower.h"
 #include "MSP430TargetMachine.h"
 #include "TargetInfo/MSP430TargetInfo.h"
 #include "llvm/BinaryFormat/ELF.h"
 #include "llvm/CodeGen/AsmPrinter.h"
+#include "llvm/CodeGen/AsmPrinterAnalysis.h"
 #include "llvm/CodeGen/MachineConstantPool.h"
+#include "llvm/CodeGen/MachineFunctionAnalysisManager.h"
 #include "llvm/CodeGen/MachineInstr.h"
 #include "llvm/CodeGen/MachineModuleInfo.h"
+#include "llvm/CodeGen/MachinePassManager.h"
+#include "llvm/IR/Analysis.h"
 #include "llvm/IR/Mangler.h"
+#include "llvm/IR/PassManager.h"
 #include "llvm/MC/MCAsmInfo.h"
 #include "llvm/MC/MCInst.h"
 #include "llvm/MC/MCSectionELF.h"
@@ -194,3 +200,33 @@ extern "C" LLVM_ABI LLVM_EXTERNAL_VISIBILITY void
 LLVMInitializeMSP430AsmPrinter() {
   RegisterAsmPrinter<MSP430AsmPrinter> X(getTheMSP430Target());
 }
+
+PreservedAnalyses MSP430AsmPrinterBeginPass::run(Module &M,
+                                                 ModuleAnalysisManager &MAM) {
+  MSP430AsmPrinter &AsmPrinter = static_cast<MSP430AsmPrinter &>(
+      MAM.getResult<AsmPrinterAnalysis>(M).getPrinter());
+  setupModuleAsmPrinter(M, MAM, AsmPrinter);
+  AsmPrinter.doInitialization(M);
+  return PreservedAnalyses::all();
+}
+
+PreservedAnalyses
+MSP430AsmPrinterPass::run(MachineFunction &MF,
+                          MachineFunctionAnalysisManager &MFAM) {
+  MSP430AsmPrinter &AsmPrinter = static_cast<MSP430AsmPrinter &>(
+      MFAM.getResult<ModuleAnalysisManagerMachineFunctionProxy>(MF)
+          .getCachedResult<AsmPrinterAnalysis>(*MF.getFunction().getParent())
+          ->getPrinter());
+  setupMachineFunctionAsmPrinter(MFAM, MF, AsmPrinter);
+  AsmPrinter.runOnMachineFunction(MF);
+  return PreservedAnalyses::all();
+}
+
+PreservedAnalyses MSP430AsmPrinterEndPass::run(Module &M,
+                                               ModuleAnalysisManager &MAM) {
+  MSP430AsmPrinter &AsmPrinter = static_cast<MSP430AsmPrinter &>(
+      MAM.getResult<AsmPrinterAnalysis>(M).getPrinter());
+  setupModuleAsmPrinter(M, MAM, AsmPrinter);
+  AsmPrinter.doFinalization(M);
+  return PreservedAnalyses::all();
+}

diff  --git a/llvm/lib/Target/MSP430/MSP430AsmPrinter.h b/llvm/lib/Target/MSP430/MSP430AsmPrinter.h
new file mode 100644
index 0000000000000..392d0a03a74af
--- /dev/null
+++ b/llvm/lib/Target/MSP430/MSP430AsmPrinter.h
@@ -0,0 +1,39 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIB_TARGET_MSP430_MSP430ASMPRINTER_H
+#define LLVM_LIB_TARGET_MSP430_MSP430ASMPRINTER_H
+
+#include "llvm/CodeGen/MachineFunctionAnalysisManager.h"
+#include "llvm/IR/Analysis.h"
+#include "llvm/IR/PassManager.h"
+
+namespace llvm {
+
+class MSP430AsmPrinterBeginPass
+    : public RequiredPassInfoMixin<MSP430AsmPrinterBeginPass> {
+public:
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
+};
+
+class MSP430AsmPrinterPass
+    : public RequiredPassInfoMixin<MSP430AsmPrinterPass> {
+public:
+  PreservedAnalyses run(MachineFunction &MF,
+                        MachineFunctionAnalysisManager &MFAM);
+};
+
+class MSP430AsmPrinterEndPass
+    : public RequiredPassInfoMixin<MSP430AsmPrinterEndPass> {
+public:
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
+};
+
+} // namespace llvm
+
+#endif // LLVM_LIB_TARGET_MSP430_MSP430ASMPRINTER_H

diff  --git a/llvm/lib/Target/MSP430/MSP430CodeGenPassBuilder.cpp b/llvm/lib/Target/MSP430/MSP430CodeGenPassBuilder.cpp
index c7ca6cc055e05..a15ae42891268 100644
--- a/llvm/lib/Target/MSP430/MSP430CodeGenPassBuilder.cpp
+++ b/llvm/lib/Target/MSP430/MSP430CodeGenPassBuilder.cpp
@@ -7,6 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "MSP430.h"
+#include "MSP430AsmPrinter.h"
 #include "MSP430TargetMachine.h"
 
 #include "llvm/CodeGen/AtomicExpand.h"
@@ -34,6 +35,9 @@ class MSP430CodeGenPassBuilder
   void addIRPasses(PassManagerWrapper &PMW) const;
   Error addInstSelector(PassManagerWrapper &PMW) const;
   void addPreEmitPass(PassManagerWrapper &PMW) const;
+  void addAsmPrinterBegin(PassManagerWrapper &PMW) const;
+  void addAsmPrinter(PassManagerWrapper &PMW) const;
+  void addAsmPrinterEnd(PassManagerWrapper &PMW) const;
 };
 
 void MSP430CodeGenPassBuilder::addIRPasses(PassManagerWrapper &PMW) const {
@@ -51,6 +55,19 @@ void MSP430CodeGenPassBuilder::addPreEmitPass(PassManagerWrapper &PMW) const {
   addMachineFunctionPass(MSP430BranchSelectPass(), PMW);
 }
 
+void MSP430CodeGenPassBuilder::addAsmPrinterBegin(
+    PassManagerWrapper &PMW) const {
+  addModulePass(MSP430AsmPrinterBeginPass(), PMW, /*Force=*/true);
+}
+
+void MSP430CodeGenPassBuilder::addAsmPrinter(PassManagerWrapper &PMW) const {
+  addMachineFunctionPass(MSP430AsmPrinterPass(), PMW);
+}
+
+void MSP430CodeGenPassBuilder::addAsmPrinterEnd(PassManagerWrapper &PMW) const {
+  addModulePass(MSP430AsmPrinterEndPass(), PMW);
+}
+
 } // namespace
 
 void MSP430TargetMachine::registerPassBuilderCallbacks(PassBuilder &PB){


        


More information about the llvm-commits mailing list