[compiler-rt] compiler-rt: ubsan: match suppressions against inlined frames (PR #206735)

[via llvm-commits]

================

----------------
maflcko wrote:

Hmm, I was preparing a reply to your question, but I think I was confused when I wrote the patch here, and I am not sure the code here actually is the desired behavior change.

My understanding is that all suppressions should only match the top stack frame. IIUC this is the current and correct behavior.

However, my patch here as-is will likely break that, because function matching is done on any stack frame. This means a suppression in a function may expand to any unrelated inlined function, just because it happens to be inlined into the function.

Given that no pre-existing tests failed with my patch here, my recommendation would be to first submit a test-only change to lock in the current and desired behavior. Then re-visit the fix here.

I've turned this into a draft for now. Let's continue by adding a test first?




https://github.com/llvm/llvm-project/pull/206735