[llvm] [X86] Fold FP UNORD/ORD compare against known-non-NaN to self-compare (PR #206943)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 03:54:49 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/X86/X86ISelLowering.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 5b29795e7..50feae4e8 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -24974,10 +24974,10 @@ static SDValue LowerVSETCC(SDValue Op, const X86Subtarget &Subtarget,
     bool IsAlwaysSignaling;
     unsigned SSECC = translateX86FSETCC(Cond, Op0, Op1, IsAlwaysSignaling);
     // depending if and only if operand is NaN.. reference UNORD 3 and ORD 7
-    if ((SSECC == 3 || SSECC == 7) && Op0 != Op1){
-      if(DAG.isKnownNeverNaN(Op1))
+    if ((SSECC == 3 || SSECC == 7) && Op0 != Op1) {
+      if (DAG.isKnownNeverNaN(Op1))
         Op1 = Op0;
-      else if(DAG.isKnownNeverNaN(Op0))
+      else if (DAG.isKnownNeverNaN(Op0))
         Op0 = Op1;
     }
     if (!Subtarget.hasAVX()) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/206943


More information about the llvm-commits mailing list