[llvm] [DAGCombiner] Fold smax(X, -1)/smin(X, 0) to bitwise shift forms (PR #206242)
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 30 06:08:06 PDT 2026
================
@@ -239,37 +244,52 @@ define i64 @test_i64_smin(i64 %a) nounwind {
}
define i128 @test_i128_smax(i128 %a) nounwind {
-; X64-LABEL: test_i128_smax:
-; X64: # %bb.0:
-; X64-NEXT: movq %rdi, %rax
-; X64-NEXT: xorl %edx, %edx
-; X64-NEXT: testq %rsi, %rsi
-; X64-NEXT: cmovsq %rdx, %rax
-; X64-NEXT: cmovgq %rsi, %rdx
-; X64-NEXT: retq
+; X64-BMI-LABEL: test_i128_smax:
+; X64-BMI: # %bb.0:
+; X64-BMI-NEXT: xorl %eax, %eax
+; X64-BMI-NEXT: testq %rsi, %rsi
+; X64-BMI-NEXT: cmovnsq %rdi, %rax
+; X64-BMI-NEXT: movq %rsi, %rcx
+; X64-BMI-NEXT: sarq $63, %rcx
+; X64-BMI-NEXT: andnq %rsi, %rcx, %rdx
+; X64-BMI-NEXT: retq
+;
+; X64-NOBMI-LABEL: test_i128_smax:
+; X64-NOBMI: # %bb.0:
+; X64-NOBMI-NEXT: movq %rdi, %rax
+; X64-NOBMI-NEXT: xorl %edx, %edx
+; X64-NOBMI-NEXT: testq %rsi, %rsi
+; X64-NOBMI-NEXT: cmovsq %rdx, %rax
+; X64-NOBMI-NEXT: cmovgq %rsi, %rdx
+; X64-NOBMI-NEXT: retq
;
; X86-BMI-LABEL: test_i128_smax:
; X86-BMI: # %bb.0:
+; X86-BMI-NEXT: pushl %ebx
; X86-BMI-NEXT: pushl %edi
; X86-BMI-NEXT: pushl %esi
-; X86-BMI-NEXT: pushl %eax
; X86-BMI-NEXT: movl {{[0-9]+}}(%esp), %eax
+; X86-BMI-NEXT: movl {{[0-9]+}}(%esp), %edx
+; X86-BMI-NEXT: xorl %ecx, %ecx
+; X86-BMI-NEXT: testl %edx, %edx
+; X86-BMI-NEXT: movl $0, %esi
+; X86-BMI-NEXT: movl $0, %edi
+; X86-BMI-NEXT: js .LBB8_2
+; X86-BMI-NEXT: # %bb.1:
; X86-BMI-NEXT: movl {{[0-9]+}}(%esp), %ecx
-; X86-BMI-NEXT: xorl %edx, %edx
-; X86-BMI-NEXT: testl %ecx, %ecx
-; X86-BMI-NEXT: cmovlel %edx, %ecx
; X86-BMI-NEXT: movl {{[0-9]+}}(%esp), %esi
-; X86-BMI-NEXT: cmovsl %edx, %esi
; X86-BMI-NEXT: movl {{[0-9]+}}(%esp), %edi
-; X86-BMI-NEXT: cmovsl %edx, %edi
-; X86-BMI-NEXT: cmovnsl {{[0-9]+}}(%esp), %edx
-; X86-BMI-NEXT: movl %ecx, 12(%eax)
-; X86-BMI-NEXT: movl %edx, 8(%eax)
-; X86-BMI-NEXT: movl %edi, 4(%eax)
-; X86-BMI-NEXT: movl %esi, (%eax)
-; X86-BMI-NEXT: addl $4, %esp
+; X86-BMI-NEXT: .LBB8_2:
+; X86-BMI-NEXT: movl %edx, %ebx
+; X86-BMI-NEXT: sarl $31, %ebx
+; X86-BMI-NEXT: andnl %edx, %ebx, %edx
+; X86-BMI-NEXT: movl %edx, 12(%eax)
+; X86-BMI-NEXT: movl %edi, 8(%eax)
+; X86-BMI-NEXT: movl %esi, 4(%eax)
+; X86-BMI-NEXT: movl %ecx, (%eax)
; X86-BMI-NEXT: popl %esi
; X86-BMI-NEXT: popl %edi
+; X86-BMI-NEXT: popl %ebx
----------------
RKSimon wrote:
regression
https://github.com/llvm/llvm-project/pull/206242
More information about the llvm-commits
mailing list