[llvm] [InstCombine] Preserve all load metadata when folding load of select (PR #206663)

[Nikita Popov via llvm-commits]

https://github.com/nikic requested changes to this pull request.

> Each new load performs the same access as the original load on one arm of the select and executes only when that arm is chosen, so the original load's metadata remains valid for the new loads.

This is incorrect. The loads execute *unconditionally*, which is why the code must drop any metadata that results in immediate undefinde behavior.

https://github.com/llvm/llvm-project/pull/206663