[llvm] [RISCV] Make getArgGPRs take a const RISCVSubtarget & (NFC) (PR #206327)
Lucas Chollet via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 28 05:26:27 PDT 2026
https://github.com/LucasChollet created https://github.com/llvm/llvm-project/pull/206327
This aligns the signature with getArgFPRs(), as suggested here: https://github.com/llvm/llvm-project/pull/204929#discussion_r3462814724
>From b270b13bea1a787788e450164db3bf251bed6672 Mon Sep 17 00:00:00 2001
From: Lucas Chollet <lucas.chollet at serenityos.org>
Date: Sun, 28 Jun 2026 14:23:01 +0200
Subject: [PATCH] [RISCV] Make getArgGPRs take a const RISCVSubtarget & (NFC)
This aligns the signature with getArgFPRs(), as suggested here:
https://github.com/llvm/llvm-project/pull/204929#discussion_r3462814724
---
llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp | 2 +-
llvm/lib/Target/RISCV/RISCVCallingConv.cpp | 8 +++++---
llvm/lib/Target/RISCV/RISCVCallingConv.h | 2 +-
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | 2 +-
llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp | 2 +-
5 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp b/llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp
index 85a7408ba63a2..29d67ddcb5344 100644
--- a/llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp
+++ b/llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp
@@ -432,7 +432,7 @@ void RISCVCallLowering::saveVarArgRegisters(
MachineFunction &MF = MIRBuilder.getMF();
const RISCVSubtarget &Subtarget = MF.getSubtarget<RISCVSubtarget>();
unsigned XLenInBytes = Subtarget.getXLen() / 8;
- ArrayRef<MCPhysReg> ArgRegs = RISCV::getArgGPRs(Subtarget.getTargetABI());
+ ArrayRef<MCPhysReg> ArgRegs = RISCV::getArgGPRs(Subtarget);
MachineRegisterInfo &MRI = MF.getRegInfo();
unsigned Idx = CCInfo.getFirstUnallocated(ArgRegs);
MachineFrameInfo &MFI = MF.getFrameInfo();
diff --git a/llvm/lib/Target/RISCV/RISCVCallingConv.cpp b/llvm/lib/Target/RISCV/RISCVCallingConv.cpp
index e513dcf560e24..76bc813d63c43 100644
--- a/llvm/lib/Target/RISCV/RISCVCallingConv.cpp
+++ b/llvm/lib/Target/RISCV/RISCVCallingConv.cpp
@@ -165,7 +165,9 @@ static const MCPhysReg ArgVRN4M2s[] = {
static const MCPhysReg ArgVRN2M4s[] = {RISCV::V8M4_V12M4, RISCV::V12M4_V16M4,
RISCV::V16M4_V20M4};
-ArrayRef<MCPhysReg> RISCV::getArgGPRs(const RISCVABI::ABI ABI) {
+ArrayRef<MCPhysReg> RISCV::getArgGPRs(const RISCVSubtarget &STI) {
+ RISCVABI::ABI ABI = STI.getTargetABI();
+
// The GPRs used for passing arguments in the ILP32* and LP64* ABIs, except
// the ILP32E ABI.
static const MCPhysReg ArgIGPRs[] = {RISCV::X10, RISCV::X11, RISCV::X12,
@@ -307,7 +309,7 @@ static bool CC_RISCVAssign2XLen(CCState &State, CCValAssign VA1,
RISCVABI::ABI ABI = Subtarget.getTargetABI();
bool EABI = ABI == RISCVABI::ABI_ILP32E || ABI == RISCVABI::ABI_LP64E;
- ArrayRef<MCPhysReg> ArgGPRs = RISCV::getArgGPRs(ABI);
+ ArrayRef<MCPhysReg> ArgGPRs = RISCV::getArgGPRs(Subtarget);
if (MCRegister Reg = State.AllocateReg(ArgGPRs)) {
// At least one half can be passed via register.
@@ -495,7 +497,7 @@ static bool CC_RISCV_Impl(unsigned ValNo, MVT ValVT, MVT LocVT,
}
}
- ArrayRef<MCPhysReg> ArgGPRs = RISCV::getArgGPRs(ABI);
+ ArrayRef<MCPhysReg> ArgGPRs = RISCV::getArgGPRs(Subtarget);
// Zdinx use GPR without a bitcast when possible.
if (LocVT == MVT::f64 && XLen == 64 && Subtarget.hasStdExtZdinx()) {
diff --git a/llvm/lib/Target/RISCV/RISCVCallingConv.h b/llvm/lib/Target/RISCV/RISCVCallingConv.h
index fadbc95a2090f..42b115a68c1b6 100644
--- a/llvm/lib/Target/RISCV/RISCVCallingConv.h
+++ b/llvm/lib/Target/RISCV/RISCVCallingConv.h
@@ -25,7 +25,7 @@ class RISCVSubtarget;
namespace RISCV {
-ArrayRef<MCPhysReg> getArgGPRs(const RISCVABI::ABI ABI);
+ArrayRef<MCPhysReg> getArgGPRs(const RISCVSubtarget &STI);
ArrayRef<MCPhysReg> getArgFPRs(const RISCVSubtarget &STI);
} // end namespace RISCV
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index e5ce36afb7b2f..2358dc3d679ad 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -25001,7 +25001,7 @@ SDValue RISCVTargetLowering::LowerFormalArguments(
MF.getInfo<RISCVMachineFunctionInfo>()->setIsVectorCall();
if (IsVarArg) {
- ArrayRef<MCPhysReg> ArgRegs = RISCV::getArgGPRs(Subtarget.getTargetABI());
+ ArrayRef<MCPhysReg> ArgRegs = RISCV::getArgGPRs(Subtarget);
unsigned Idx = CCInfo.getFirstUnallocated(ArgRegs);
const TargetRegisterClass *RC = &RISCV::GPRRegClass;
MachineFrameInfo &MFI = MF.getFrameInfo();
diff --git a/llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp b/llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp
index 7828f07cdbaa5..7dbdc881ea6c0 100644
--- a/llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp
+++ b/llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp
@@ -830,7 +830,7 @@ bool RISCVRegisterInfo::isArgumentRegister(const MachineFunction &MF,
const RISCVRegisterInfo *TRI = STI.getRegisterInfo();
if (TRI->isGeneralPurposeRegister(MF, Reg))
- return llvm::is_contained(RISCV::getArgGPRs(STI.getTargetABI()), Reg);
+ return llvm::is_contained(RISCV::getArgGPRs(STI), Reg);
if (TRI->isFPRegister(Reg))
return llvm::is_contained(RISCV::getArgFPRs(STI), Reg);
More information about the llvm-commits
mailing list