[llvm] [VPlan] Drop dead CostCtx/Range arg sfrom getScaledReductions (NFC) (PR #206285)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 27 13:08:20 PDT 2026
https://github.com/fhahn created https://github.com/llvm/llvm-project/pull/206285
Neither parameter is referenced; the cost-checking they described moved to createPartialReductions. Also remove the stale comment.
>From 07436d58bd4f1842fa1a6b147f800ce259086ce5 Mon Sep 17 00:00:00 2001
From: Florian Hahn <flo at fhahn.com>
Date: Wed, 24 Jun 2026 10:41:31 +0100
Subject: [PATCH] [VPlan] Drop dead CostCtx/Range arg sfrom getScaledReductions
(NFC)
Neither parameter is referenced; the cost-checking they described moved to
createPartialReductions. Also remove the stale comment.
---
llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index cfe21de1c7595..7604e09aa8210 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -6951,8 +6951,7 @@ matchExtendedReductionOperand(VPWidenRecipe *UpdateR, VPValue *Op) {
/// per-iteration input VF and narrower PHI VF. If successful, returns the chain
/// of operations in the reduction.
static std::optional<SmallVector<VPPartialReductionChain>>
-getScaledReductions(VPReductionPHIRecipe *RedPhiR, VPCostContext &CostCtx,
- VFRange &Range) {
+getScaledReductions(VPReductionPHIRecipe *RedPhiR) {
// Get the backedge value from the reduction PHI and find the
// ComputeReductionResult that uses it (directly or through a select for
// predicated reductions).
@@ -6993,9 +6992,6 @@ getScaledReductions(VPReductionPHIRecipe *RedPhiR, VPCostContext &CostCtx,
if (!PHISize.hasKnownScalarFactor(ExtSrcSize))
return std::nullopt;
- // Check if a partial reduction chain is supported by the target (i.e. does
- // not have an invalid cost) for the given VF range. Clamps the range and
- // returns true if feasible for any VF.
VPPartialReductionChain Link(
{UpdateR, *ExtendedOp, RK,
PrevValue == UpdateR->getOperand(0) ? 0U : 1U,
@@ -7025,7 +7021,7 @@ void VPlanTransforms::createPartialReductions(VPlan &Plan,
if (!RedPhiR)
continue;
- if (auto Chains = getScaledReductions(RedPhiR, CostCtx, Range))
+ if (auto Chains = getScaledReductions(RedPhiR))
ChainsByPhi.try_emplace(RedPhiR, std::move(*Chains));
}
More information about the llvm-commits
mailing list