[llvm] [DirectX][ObjectYAML] Attempt to fix flaky PRIVPart.yaml (PR #206278)
Vladislav Dzhidzhoev via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 27 12:21:33 PDT 2026
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/206278
This test was meant to round-trip YAML twice, to ensure correct processing of non-4-byte-padded PRIV section.
However, second invocation of yaml2obj had wrong arguments (it was reading from test file instead of stdin). Fix that.
Also, round-trips were split into two RUN lines, to make it clear on which line an error occurs if the test is still flaky.
>From d36c4de77ea9c20c562596c54409e5b3999b3f0a Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev <vdzhidzhoev at accesssoftek.com>
Date: Sat, 27 Jun 2026 21:17:10 +0200
Subject: [PATCH] [DirectX][ObjectYAML] Attempt to fix flaky PRIVPart.yaml
This test was meant to round-trip YAML twice, to ensure correct
processing of non-4-byte-padded PRIV section.
However, second invocation of yaml2obj had wrong arguments (it was
reading from test file instead of stdin). Fix that.
Also, round-trips were split in two RUN lines, to check on which line an
error occurs if the test is still flaky.
---
llvm/test/tools/obj2yaml/DXContainer/PRIVPart.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/llvm/test/tools/obj2yaml/DXContainer/PRIVPart.yaml b/llvm/test/tools/obj2yaml/DXContainer/PRIVPart.yaml
index 0d429a1381413..72db3f55b37b4 100644
--- a/llvm/test/tools/obj2yaml/DXContainer/PRIVPart.yaml
+++ b/llvm/test/tools/obj2yaml/DXContainer/PRIVPart.yaml
@@ -2,7 +2,8 @@
## part size is not a multiple of 4. The pipeline is run twice to ensure obj2yaml
## output with a non-multiple-of-4 FileSize can be fed back through yaml2obj.
-# RUN: yaml2obj %s 2>&1 | obj2yaml 2>&1 | yaml2obj %s 2>&1 | obj2yaml 2>&1 | FileCheck %s
+# RUN: yaml2obj %s 2>&1 | obj2yaml -o %t.yaml
+# RUN: yaml2obj %t.yaml 2>&1 | obj2yaml 2>&1 | FileCheck %s
--- !dxcontainer
Header:
More information about the llvm-commits
mailing list