[llvm] [X86] Mark AsmPrinter Module Passes as Required (PR #206164)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 12:54:43 PDT 2026


https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/206164

This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.

>From deab2012c75f1b331b03bfb1449d305507c988b0 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Fri, 26 Jun 2026 19:53:32 +0000
Subject: [PATCH] [X86] Mark AsmPrinter Module Passes as Required

This won't impact them working on optnone functions, but could impact
whether or not they get called in opt-bisect, which would be wrong.
---
 llvm/lib/Target/X86/X86AsmPrinter.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Target/X86/X86AsmPrinter.h b/llvm/lib/Target/X86/X86AsmPrinter.h
index 142b68839501d..450c45e915414 100644
--- a/llvm/lib/Target/X86/X86AsmPrinter.h
+++ b/llvm/lib/Target/X86/X86AsmPrinter.h
@@ -206,7 +206,7 @@ class LLVM_LIBRARY_VISIBILITY X86AsmPrinter : public AsmPrinter {
 };
 
 class X86AsmPrinterBeginPass
-    : public OptionalPassInfoMixin<X86AsmPrinterBeginPass> {
+    : public RequiredPassInfoMixin<X86AsmPrinterBeginPass> {
 public:
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
 };
@@ -219,7 +219,7 @@ class X86AsmPrinterPass : public RequiredPassInfoMixin<X86AsmPrinterPass> {
 };
 
 class X86AsmPrinterEndPass
-    : public OptionalPassInfoMixin<X86AsmPrinterEndPass> {
+    : public RequiredPassInfoMixin<X86AsmPrinterEndPass> {
 public:
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
 };



More information about the llvm-commits mailing list