[llvm] [VPlan] Consolidate VPIWithType and VPI (NFC) (PR #203019)

[Luke Lau via llvm-commits]

================
@@ -1313,10 +1328,15 @@ InstructionCost VPRecipeWithIRFlags::getCostForRecipeWithOpcode(
 
 InstructionCost VPInstruction::computeCost(ElementCount VF,
                                            VPCostContext &Ctx) const {
-  if (Instruction::isBinaryOp(getOpcode())) {
-    if (!getUnderlyingValue() && getOpcode() != Instruction::FMul) {
-      // TODO: Compute cost for VPInstructions without underlying values once
-      // the legacy cost model has been retired.
+  // NOTE: At the moment it seems only possible to expose this path for
+  // the trunc, zext and sext opcodes. However, isScalarCast also covers
+  // int<>fp conversions, bitcasts, ptr<>int conversions, etc.
----------------
lukel97 wrote:

Is this comment still relevant? Can we remove it?

https://github.com/llvm/llvm-project/pull/203019