[llvm] [Hexagon] Fix unused variable in non-assert builds (KCFI) (PR #205491)
Brian Cain via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 23 23:25:39 PDT 2026
https://github.com/androm3da created https://github.com/llvm/llvm-project/pull/205491
Without asserts, we see failures like so:
/repo/llvm/llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp:982:43: error: unused variable 'NextI' [-Werror,-Wunused-variable]
982 | MachineBasicBlock::const_instr_iterator NextI = std::next(MI.getIterator());
| ^~~~~
1 error generated.
Mark NextI `maybe_unused` to address the issue.
Fixes a regression introduced by f8aa5f66209d.
>From 3766cda06900ee97ce9a66a71454cc12fb2d8f97 Mon Sep 17 00:00:00 2001
From: Brian Cain <brian.cain at oss.qualcomm.com>
Date: Wed, 24 Jun 2026 01:23:44 -0500
Subject: [PATCH] [Hexagon] Fix unused variable in non-assert builds (KCFI)
Without asserts, we see failures like so:
/repo/llvm/llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp:982:43: error: unused variable 'NextI' [-Werror,-Wunused-variable]
982 | MachineBasicBlock::const_instr_iterator NextI = std::next(MI.getIterator());
| ^~~~~
1 error generated.
Mark NextI `maybe_unused` to address the issue.
Fixes a regression introduced by f8aa5f66209d.
---
llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp b/llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp
index 61ca9020bb689..3925f9fea668a 100644
--- a/llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp
@@ -979,7 +979,8 @@ void HexagonAsmPrinter::LowerPATCHABLE_EVENT_CALL(const MachineInstr &MI,
void HexagonAsmPrinter::LowerKCFI_CHECK(const MachineInstr &MI) {
Register AddrReg = MI.getOperand(0).getReg();
const int64_t Type = MI.getOperand(1).getImm();
- MachineBasicBlock::const_instr_iterator NextI = std::next(MI.getIterator());
+ [[maybe_unused]] MachineBasicBlock::const_instr_iterator NextI =
+ std::next(MI.getIterator());
assert(NextI != MI.getParent()->instr_end() && NextI->isCall() &&
"KCFI_CHECK not followed by a call instruction");
assert(NextI->getOperand(0).getReg() == AddrReg &&
More information about the llvm-commits
mailing list