[llvm] [InstCombine] signum: or (ashr X, BW-1), (lshr (-X), BW-1) --> scmp(X, 0) (PR #205365)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 08:53:17 PDT 2026


https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/205365

>From 3e4eaf392196ac147061f8d3cc24faa055ed8490 Mon Sep 17 00:00:00 2001
From: AZero13 <gfunni234 at gmail.com>
Date: Tue, 23 Jun 2026 11:21:26 -0400
Subject: [PATCH 1/3] Pre-commit tests (NFC)

---
 llvm/test/Transforms/InstCombine/or.ll | 45 ++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/llvm/test/Transforms/InstCombine/or.ll b/llvm/test/Transforms/InstCombine/or.ll
index 4126d653d2ad1..8f5b87e14c944 100644
--- a/llvm/test/Transforms/InstCombine/or.ll
+++ b/llvm/test/Transforms/InstCombine/or.ll
@@ -2386,3 +2386,48 @@ define i32 @signum_i32_or_wrong_ext(i32 %x) {
   %r = or i32 %signbit, %sgt0ext
   ret i32 %r
 }
+
+define i32 @signum_i32_or_lshr_neg(i32 %x) {
+; CHECK-LABEL: @signum_i32_or_lshr_neg(
+; CHECK-NEXT:    [[SIGNBIT:%.*]] = ashr i32 [[X:%.*]], 31
+; CHECK-NEXT:    [[NEG:%.*]] = sub i32 0, [[X]]
+; CHECK-NEXT:    [[ZGT0:%.*]] = lshr i32 [[NEG]], 31
+; CHECK-NEXT:    [[R:%.*]] = or i32 [[SIGNBIT]], [[ZGT0]]
+; CHECK-NEXT:    ret i32 [[R]]
+;
+  %signbit = ashr i32 %x, 31
+  %neg = sub i32 0, %x
+  %zgt0 = lshr i32 %neg, 31
+  %r = or i32 %signbit, %zgt0
+  ret i32 %r
+}
+
+define i32 @signum_i32_or_lshr_neg_commuted(i32 %x) {
+; CHECK-LABEL: @signum_i32_or_lshr_neg_commuted(
+; CHECK-NEXT:    [[SIGNBIT:%.*]] = ashr i32 [[X:%.*]], 31
+; CHECK-NEXT:    [[NEG:%.*]] = sub i32 0, [[X]]
+; CHECK-NEXT:    [[ZGT0:%.*]] = lshr i32 [[NEG]], 31
+; CHECK-NEXT:    [[R:%.*]] = or i32 [[ZGT0]], [[SIGNBIT]]
+; CHECK-NEXT:    ret i32 [[R]]
+;
+  %signbit = ashr i32 %x, 31
+  %neg = sub i32 0, %x
+  %zgt0 = lshr i32 %neg, 31
+  %r = or i32 %zgt0, %signbit
+  ret i32 %r
+}
+
+define <2 x i5> @signum_v2i5_or_lshr_neg(<2 x i5> %x) {
+; CHECK-LABEL: @signum_v2i5_or_lshr_neg(
+; CHECK-NEXT:    [[SIGNBIT:%.*]] = ashr <2 x i5> [[X:%.*]], splat (i5 4)
+; CHECK-NEXT:    [[NEG:%.*]] = sub <2 x i5> zeroinitializer, [[X]]
+; CHECK-NEXT:    [[ZGT0:%.*]] = lshr <2 x i5> [[NEG]], splat (i5 4)
+; CHECK-NEXT:    [[R:%.*]] = or <2 x i5> [[SIGNBIT]], [[ZGT0]]
+; CHECK-NEXT:    ret <2 x i5> [[R]]
+;
+  %signbit = ashr <2 x i5> %x, <i5 4, i5 4>
+  %neg = sub <2 x i5> zeroinitializer, %x
+  %zgt0 = lshr <2 x i5> %neg, <i5 4, i5 4>
+  %r = or <2 x i5> %signbit, %zgt0
+  ret <2 x i5> %r
+}

>From cd249012999f3ec9d3b6d3b2c687d47b575994fe Mon Sep 17 00:00:00 2001
From: AZero13 <gfunni234 at gmail.com>
Date: Tue, 23 Jun 2026 11:22:32 -0400
Subject: [PATCH 2/3] [InstCombine] signum: or (ashr X, BW-1), (lshr (-X),
 BW-1) --> scmp(X, 0)

Alive2: https://alive2.llvm.org/ce/z/Fm6HH2
---
 .../InstCombine/InstCombineAndOrXor.cpp           | 14 ++++++++++++++
 llvm/test/Transforms/InstCombine/or.ll            | 15 +++------------
 2 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
index 50496065b8dfa..1b87419215f2f 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
@@ -4687,6 +4687,20 @@ Instruction *InstCombinerImpl::visitOr(BinaryOperator &I) {
                                      {X, Constant::getNullValue(Ty)}));
   }
 
+  // signum: or (ashr X, BW-1), (lshr (-X), BW-1) --> scmp(X, 0)
+  {
+    Value *X;
+    unsigned BitWidth = Ty->getScalarSizeInBits();
+    if (match(&I,
+              m_c_Or(m_AShr(m_Value(X), m_SpecificIntAllowPoison(BitWidth - 1)),
+                     m_LShr(m_Neg(m_Deferred(X)),
+                            m_SpecificIntAllowPoison(BitWidth - 1)))) &&
+        (Op0->hasOneUse() || Op1->hasOneUse()))
+      return replaceInstUsesWith(
+          I, Builder.CreateIntrinsic(Ty, Intrinsic::scmp,
+                                     {X, Constant::getNullValue(Ty)}));
+  }
+
   return nullptr;
 }
 
diff --git a/llvm/test/Transforms/InstCombine/or.ll b/llvm/test/Transforms/InstCombine/or.ll
index 8f5b87e14c944..da14ca1f5b8c3 100644
--- a/llvm/test/Transforms/InstCombine/or.ll
+++ b/llvm/test/Transforms/InstCombine/or.ll
@@ -2389,10 +2389,7 @@ define i32 @signum_i32_or_wrong_ext(i32 %x) {
 
 define i32 @signum_i32_or_lshr_neg(i32 %x) {
 ; CHECK-LABEL: @signum_i32_or_lshr_neg(
-; CHECK-NEXT:    [[SIGNBIT:%.*]] = ashr i32 [[X:%.*]], 31
-; CHECK-NEXT:    [[NEG:%.*]] = sub i32 0, [[X]]
-; CHECK-NEXT:    [[ZGT0:%.*]] = lshr i32 [[NEG]], 31
-; CHECK-NEXT:    [[R:%.*]] = or i32 [[SIGNBIT]], [[ZGT0]]
+; CHECK-NEXT:    [[R:%.*]] = call i32 @llvm.scmp.i32.i32(i32 [[X:%.*]], i32 0)
 ; CHECK-NEXT:    ret i32 [[R]]
 ;
   %signbit = ashr i32 %x, 31
@@ -2404,10 +2401,7 @@ define i32 @signum_i32_or_lshr_neg(i32 %x) {
 
 define i32 @signum_i32_or_lshr_neg_commuted(i32 %x) {
 ; CHECK-LABEL: @signum_i32_or_lshr_neg_commuted(
-; CHECK-NEXT:    [[SIGNBIT:%.*]] = ashr i32 [[X:%.*]], 31
-; CHECK-NEXT:    [[NEG:%.*]] = sub i32 0, [[X]]
-; CHECK-NEXT:    [[ZGT0:%.*]] = lshr i32 [[NEG]], 31
-; CHECK-NEXT:    [[R:%.*]] = or i32 [[ZGT0]], [[SIGNBIT]]
+; CHECK-NEXT:    [[R:%.*]] = call i32 @llvm.scmp.i32.i32(i32 [[X:%.*]], i32 0)
 ; CHECK-NEXT:    ret i32 [[R]]
 ;
   %signbit = ashr i32 %x, 31
@@ -2419,10 +2413,7 @@ define i32 @signum_i32_or_lshr_neg_commuted(i32 %x) {
 
 define <2 x i5> @signum_v2i5_or_lshr_neg(<2 x i5> %x) {
 ; CHECK-LABEL: @signum_v2i5_or_lshr_neg(
-; CHECK-NEXT:    [[SIGNBIT:%.*]] = ashr <2 x i5> [[X:%.*]], splat (i5 4)
-; CHECK-NEXT:    [[NEG:%.*]] = sub <2 x i5> zeroinitializer, [[X]]
-; CHECK-NEXT:    [[ZGT0:%.*]] = lshr <2 x i5> [[NEG]], splat (i5 4)
-; CHECK-NEXT:    [[R:%.*]] = or <2 x i5> [[SIGNBIT]], [[ZGT0]]
+; CHECK-NEXT:    [[R:%.*]] = call <2 x i5> @llvm.scmp.v2i5.v2i5(<2 x i5> [[X:%.*]], <2 x i5> zeroinitializer)
 ; CHECK-NEXT:    ret <2 x i5> [[R]]
 ;
   %signbit = ashr <2 x i5> %x, <i5 4, i5 4>

>From e7f63f00ca74d38a3fd40a924371e050f4e99ecc Mon Sep 17 00:00:00 2001
From: AZero13 <gfunni234 at gmail.com>
Date: Tue, 23 Jun 2026 11:49:11 -0400
Subject: [PATCH 3/3] s

---
 llvm/include/llvm/CodeGen/TargetLowering.h       |  6 ++++++
 llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp | 15 ++++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/llvm/include/llvm/CodeGen/TargetLowering.h b/llvm/include/llvm/CodeGen/TargetLowering.h
index 7a10a693934fd..3faa88e86f755 100644
--- a/llvm/include/llvm/CodeGen/TargetLowering.h
+++ b/llvm/include/llvm/CodeGen/TargetLowering.h
@@ -3605,6 +3605,12 @@ class LLVM_ABI TargetLoweringBase {
     return isOperationLegalOrCustom(Op, VT);
   }
 
+    /// scmp(x, 0) Can be specially lowered using bitwise
+  virtual bool preferBitwiseSignum(EVT VT) const {
+    return false;
+  }
+
+
   /// Should we prefer selects to doing arithmetic on boolean types
   virtual bool preferSelectsOverBooleanArithmetic(EVT VT) const {
     return false;
diff --git a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
index 5772ef37ec762..2be68da14f075 100644
--- a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -12563,11 +12563,24 @@ SDValue TargetLowering::expandCMP(SDNode *Node, SelectionDAG &DAG) const {
   unsigned Opcode = Node->getOpcode();
   SDValue LHS = Node->getOperand(0);
   SDValue RHS = Node->getOperand(1);
+
   EVT VT = LHS.getValueType();
   EVT ResVT = Node->getValueType(0);
-  EVT BoolVT = getSetCCResultType(DAG.getDataLayout(), *DAG.getContext(), VT);
   SDLoc dl(Node);
 
+  if (Opcode == ISD::SCMP && isNullConstant(RHS) && preferBitwiseSignum(VT)) {
+    LHS = DAG.getFreeze(LHS);
+    unsigned BitWidth = VT.getScalarSizeInBits();
+    SDValue ShiftAmount = DAG.getShiftAmountConstant(BitWidth - 1, VT, dl);
+    SDValue SignShift = DAG.getNode(ISD::SRA, dl, VT, LHS, ShiftAmount);
+    SDValue NegX = DAG.getNode(ISD::SUB, dl, VT, DAG.getConstant(0, dl, VT), LHS);
+    SDValue NegShift = DAG.getNode(ISD::SRL, dl, VT, NegX, ShiftAmount);
+    SDValue Or = DAG.getNode(ISD::OR, dl, VT, SignShift, NegShift);
+    return DAG.getSExtOrTrunc(Or, dl, ResVT);
+  }
+
+  EVT BoolVT = getSetCCResultType(DAG.getDataLayout(), *DAG.getContext(), VT);
+
   auto LTPredicate = (Opcode == ISD::UCMP ? ISD::SETULT : ISD::SETLT);
   auto GTPredicate = (Opcode == ISD::UCMP ? ISD::SETUGT : ISD::SETGT);
   SDValue IsLT = DAG.getSetCC(dl, BoolVT, LHS, RHS, LTPredicate);



More information about the llvm-commits mailing list